linting

protocol/common/message_processor.go

@@ -272,11 +272,11 @@ func (p *MessageProcessor) EncodeMembershipUpdate(
 
 	if chatEntity != nil {
 		chatEntityProtobuf := chatEntity.GetProtobuf()
-		switch chatEntityProtobuf.(type) {
+		switch chatEntityProtobuf := chatEntityProtobuf.(type) {
 		case *protobuf.ChatMessage:
-			message.Message = chatEntityProtobuf.(*protobuf.ChatMessage)
+			message.Message = chatEntityProtobuf
 		case *protobuf.EmojiReaction:
-			message.EmojiReaction = chatEntityProtobuf.(*protobuf.EmojiReaction)
+			message.EmojiReaction = chatEntityProtobuf
 
 		}
 	}

protocol/message.go

@@ -11,8 +11,8 @@ import (
 	"unicode/utf8"
 
 	"github.com/golang/protobuf/proto"
-
 	"github.com/status-im/markdown"
+
 	"github.com/status-im/status-go/protocol/protobuf"
 )
 

protocol/message_persistence.go

@@ -505,6 +505,7 @@ func (db sqlitePersistence) EmojiReactionsByChatID(chatID string, currCursor str
 	// NOTE: We match against local_chat_id for security reasons.
 	// As a user could potentially send an emoji reaction for a one to
 	// one/group chat that has no access to.
+	// nolint: gosec
 	query := fmt.Sprintf(`
 			SELECT
 			    e.clock_value,

protocol/messenger.go

@@ -3243,7 +3243,7 @@ func (m *Messenger) SendEmojiReaction(ctx context.Context, chatID, messageID str
 			Clock:     clock,
 			MessageId: messageID,
 			ChatId:    chatID,
-			Type:      protobuf.EmojiReaction_Type(emojiID),
+			Type:      emojiID,
 		},
 		LocalChatID: chatID,
 		From:        types.EncodeHex(crypto.FromECDSAPub(&m.identity.PublicKey)),

protocol/messenger_emoji_test.go

@@ -90,7 +90,7 @@ func (s *MessengerEmojiSuite) TestSendEmoji() {
 
 	bob := s.newMessengerWithKey(s.shh, key)
 
-	chatID := "status"
+	chatID := statusChatID
 
 	chat := CreatePublicChat(chatID, alice.transport)