status-im
/
status-go
mirror of https://github.com/status-im/status-go.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(config)_: KeycardPairingDataFile is not required 

Without this change `cmd/spiff-workflow` fails to start with:
```
INFO [05-14|19:08:39.025|github.com/status-im/status-go/api/geth_backend.go:786]  failed to start node                     package=status-go/api.GethStatusBackend
ERROR[05-14|17:00:04.279|spiff-workflow/main.go:125] failed import account                       package=status-go/cmd/statusd err="Key: 'NodeConfig.KeycardPairingDataFile' Error:Field validation for 'KeycardPairingDataFile' failed on the 'required' tag"
```
The alternative is to set `KeycardPairingDataFile` to any value:
```
	nodeConfig.KeycardPairingDataFile = "STUPID_BEYOND_BELIEF"
```
Which is even worse.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
This commit is contained in:
Jakub Sokołowski 2024-05-17 15:54:35 +02:00
parent 9ad8829ce0
commit 9f1c0a27b7
No known key found for this signature in database
GPG Key ID: FE65CD384D5BF7B4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
params/config.go
View File

@ -327,7 +327,7 @@ type NodeConfig struct {
// KeycardPairingDataFile is the file where we keep keycard pairings data. // KeycardPairingDataFile is the file where we keep keycard pairings data.
// note: this field won't be saved into db, it's local to the device. // note: this field won't be saved into db, it's local to the device.
KeycardPairingDataFile string `validate:"required"` KeycardPairingDataFile string
// NodeKey is the hex-encoded node ID (private key). Should be a valid secp256k1 private key that will be used for both // NodeKey is the hex-encoded node ID (private key). Should be a valid secp256k1 private key that will be used for both
// remote peer identification as well as network traffic encryption. // remote peer identification as well as network traffic encryption.