status-im
/
status-go
mirror of https://github.com/status-im/status-go.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: joining communities sync correct filters (#2740)

This commit is contained in:
Anthony Laibe 2022-07-07 10:33:50 +02:00 committed by GitHub
parent 3dee94e505
commit 8e9c5d31d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
waku/waku.go
View File

@ -1029,19 +1029,21 @@ func (w *Waku) GetFilter(id string) *common.Filter {
} }
// Unsubscribe removes an installed message handler. // Unsubscribe removes an installed message handler.
// TODO: This does not seem to update the bloom filter, but does update // TODO: This does not update the bloom filter, but does update
// the topic interest map // the topic interest map
func (w *Waku) Unsubscribe(id string) error { func (w *Waku) Unsubscribe(id string) error {
ok := w.filters.Uninstall(id) ok := w.filters.Uninstall(id)
if !ok { if !ok {
return fmt.Errorf("failed to unsubscribe: invalid ID '%s'", id) return fmt.Errorf("failed to unsubscribe: invalid ID '%s'", id)
} }
if !w.settings.BloomFilterMode {
return w.SetTopicInterest(w.filters.AllTopics()) return w.SetTopicInterest(w.filters.AllTopics())
}
return nil
} }
// Unsubscribe removes an installed message handler. // Unsubscribe removes an installed message handler.
// TODO: This does not seem to update the bloom filter, but does update // TODO: This does not update the bloom filter, but does update
// the topic interest map // the topic interest map
func (w *Waku) UnsubscribeMany(ids []string) error { func (w *Waku) UnsubscribeMany(ids []string) error {
for _, id := range ids { for _, id := range ids {
@ -1051,7 +1053,10 @@ func (w *Waku) UnsubscribeMany(ids []string) error {
w.logger.Warn("could not remove filter with id", zap.String("id", id)) w.logger.Warn("could not remove filter with id", zap.String("id", id))
} }
} }
return w.SetTopicInterest(w.filters.AllTopics()) if !w.settings.BloomFilterMode {
return w.SetTopicInterest(w.filters.AllTopics())
}
return nil
} }
// Send injects a message into the waku send queue, to be distributed in the // Send injects a message into the waku send queue, to be distributed in the