Ensure that `NewNodeConfigWithDefaults` builds a valid configuration

cmd/node-canary/main.go

@@ -253,6 +253,7 @@ func makeNodeConfig() (*params.NodeConfig, error) {
 		nodeConfig.LogFile = *logFile
 	}
 
+	nodeConfig.NoDiscovery = true
 	nodeConfig.ListenAddr = ""
 	if *staticEnodeAddr != "" {
 		nodeConfig.ClusterConfig.Enabled = true

config/cli/fleet-eth.beta.json

@@ -1,5 +1,6 @@
 {
   "Rendezvous": true,
+  "NoDiscovery": false,
   "ClusterConfig": {
     "Enabled": true,
     "Fleet": "eth.beta",

config/cli/fleet-eth.staging.json

@@ -1,5 +1,6 @@
 {
   "Rendezvous": true,
+  "NoDiscovery": false,
   "ClusterConfig": {
     "Enabled": true,
     "Fleet": "eth.staging",

config/cli/fleet-eth.test.json

@@ -1,5 +1,6 @@
 {
   "LogLevel": "DEBUG",
+  "NoDiscovery": false,
   "ClusterConfig": {
     "Enabled": true,
     "Fleet": "eth.test",

params/config.go

@@ -315,6 +315,7 @@ func WithFleet(fleet string) Option {
 		if fleet == FleetUndefined {
 			return nil
 		}
+		c.NoDiscovery = false
 		c.ClusterConfig.Enabled = true
 		return loadConfigFromAsset(fmt.Sprintf("../config/cli/fleet-%s.json", fleet), c)
 	}
@@ -342,7 +343,7 @@ func NewNodeConfigWithDefaults(dataDir string, networkID uint64, opts ...Option)
 		return nil, err
 	}
 
-	c.NoDiscovery = false
+	c.NoDiscovery = true
 	c.HTTPHost = ""
 	c.ListenAddr = ":30303"
 	c.LogEnabled = true