status-im/status-go
2
0
Fork 0
mirror of https://github.com/status-im/status-go.git synced 2025-01-29 16:06:47 +00:00
Code Issues Projects Releases Wiki Activity

chore(mentions)_: Add suggestion limit for mention recommendations (#5774)

Browse Source 
- Introduce a constant `suggestionsLimit` set to 15
- Apply the suggestion limit when calculating mention suggestions
- Replace unlimited suggestions (-1) with the new limit in relevant function calls
- This change aims to improve performance and user experience by limiting the number of mention suggestions displayed
This commit is contained in:
frank 2024-08-30 09:37:08 +08:00 committed by GitHub
parent 28e7a364c7
commit 82ba10ede7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
protocol/messenger_mention.go
View File

@ -30,6 +30,8 @@ const (
charCodeBlock = "`" charCodeBlock = "`"
intUnknown = -1 intUnknown = -1
suggestionsLimit = 10
) )
var ( var (
@ -370,7 +372,7 @@ func (m *MentionManager) calculateSuggestionsWithMentionableUsers(chatID string,
searchedText := strings.ToLower(subs(fullText, atSignIdx+1, end)) searchedText := strings.ToLower(subs(fullText, atSignIdx+1, end))
m.logger.Debug("calculateSuggestionsWithMentionableUsers", zap.Int("atSignIdx", atSignIdx), zap.String("searchedText", searchedText), zap.String("fullText", fullText), zap.Any("state", state), zap.Int("end", end)) m.logger.Debug("calculateSuggestionsWithMentionableUsers", zap.Int("atSignIdx", atSignIdx), zap.String("searchedText", searchedText), zap.String("fullText", fullText), zap.Any("state", state), zap.Int("end", end))
if end-atSignIdx <= 100 { if end-atSignIdx <= 100 {
suggestions = getUserSuggestions(mentionableUsers, searchedText, -1) suggestions = getUserSuggestions(mentionableUsers, searchedText, suggestionsLimit)
} }
} }
@ -729,7 +731,7 @@ func matchMention(text string, users map[string]*MentionableUser, mentionKeyIdx
searchedText = string(tt[:lastChar]) searchedText = string(tt[:lastChar])
} }
userSuggestions := getUserSuggestions(users, searchedText, -1) userSuggestions := getUserSuggestions(users, searchedText, suggestionsLimit)
userSuggestionsCnt := len(userSuggestions) userSuggestionsCnt := len(userSuggestions)
switch { switch {
case userSuggestionsCnt == 0: case userSuggestionsCnt == 0: