Fix state names and log messages for status changes API.

geth/api/api.go

@@ -240,7 +240,7 @@ func (api *StatusAPI) ConnectionChange(typ string, expensive bool) {
 func (api *StatusAPI) AppStateChange(state string) {
 	appState, err := ParseAppState(state)
 	if err != nil {
-		log.Error("AppStateChange failed, ignoring it:", err)
+		log.Error("AppStateChange failed, ignoring it.", "err", err)
 		return // and do nothing
 	}
 	api.b.AppStateChange(appState)

geth/api/app_state.go

@@ -15,7 +15,7 @@ func (a AppState) String() string {
 // Specific app states
 // see https://facebook.github.io/react-native/docs/appstate.html
 const (
-	AppStateForeground = AppState("foreground")
+	AppStateForeground = AppState("active") // these constant values are kept in sync with React Native
 	AppStateBackground = AppState("background")
 	AppStateInactive   = AppState("inactive")
 

geth/api/app_state_test.go

@@ -15,10 +15,10 @@ func TestParseAppType(t *testing.T) {
 		}
 	}
 
-	check("foreground", AppStateForeground, false)
+	check("active", AppStateForeground, false)
 	check("background", AppStateBackground, false)
 	check("inactive", AppStateInactive, false)
-	check(" forEGROUnd ", AppStateForeground, false)
+	check(" acTIVE ", AppStateForeground, false)
 	check("    backGROUND  ", AppStateBackground, false)
 	check("   INACTIVE   ", AppStateInactive, false)
 	check("", AppStateInvalid, true)

geth/api/backend.go

@@ -239,7 +239,7 @@ func (b *StatusBackend) ConnectionChange(state ConnectionState) {
 
 // AppStateChange handles app state changes (background/foreground).
 func (b *StatusBackend) AppStateChange(state AppState) {
-	log.Info("App State changed: %s", state)
+	log.Info("App State changed.", "new-state", state)
 
 	// TODO: put node in low-power mode if the app is in background (or inactive)
 	// and normal mode if the app is in foreground.