feat: check member permission funds periodically

This adds a periodic member permission check for every admin community
such that member funds are checked every hour.
This commit is contained in:
Pascal Precht 2023-03-20 13:26:20 +01:00 committed by Follow the white rabbit
parent 128f82df09
commit 5ec9e1ac46
2 changed files with 125 additions and 62 deletions

View File

@ -49,6 +49,8 @@ var pieceLength = 100 * 1024
const maxArchiveSizeInBytes = 30000000 const maxArchiveSizeInBytes = 30000000
var memberPermissionsCheckInterval = 1 * time.Hour
var ErrTorrentTimedout = errors.New("torrent has timed out") var ErrTorrentTimedout = errors.New("torrent has timed out")
type Manager struct { type Manager struct {
@ -68,6 +70,7 @@ type Manager struct {
torrentClient *torrent.Client torrentClient *torrent.Client
historyArchiveTasksWaitGroup sync.WaitGroup historyArchiveTasksWaitGroup sync.WaitGroup
historyArchiveTasks map[string]chan struct{} historyArchiveTasks map[string]chan struct{}
periodicMemberPermissionsTasks map[string]chan struct{}
torrentTasks map[string]metainfo.Hash torrentTasks map[string]metainfo.Hash
historyArchiveDownloadTasks map[string]*HistoryArchiveDownloadTask historyArchiveDownloadTasks map[string]*HistoryArchiveDownloadTask
} }
@ -142,6 +145,7 @@ func NewManager(identity *ecdsa.PrivateKey, db *sql.DB, encryptor *encryption.Pr
transport: transport, transport: transport,
torrentConfig: torrentConfig, torrentConfig: torrentConfig,
historyArchiveTasks: make(map[string]chan struct{}), historyArchiveTasks: make(map[string]chan struct{}),
periodicMemberPermissionsTasks: make(map[string]chan struct{}),
torrentTasks: make(map[string]metainfo.Hash), torrentTasks: make(map[string]metainfo.Hash),
historyArchiveDownloadTasks: make(map[string]*HistoryArchiveDownloadTask), historyArchiveDownloadTasks: make(map[string]*HistoryArchiveDownloadTask),
persistence: &Persistence{ persistence: &Persistence{
@ -506,6 +510,13 @@ func (m *Manager) CreateCommunityTokenPermission(request *requests.CreateCommuni
m.publish(&Subscription{Community: community}) m.publish(&Subscription{Community: community})
// check existing member permission once, then check periodically
err = m.checkMemberPermissions(community.ID())
if err != nil {
return nil, nil, err
}
go m.CheckMemberPermissionsPeriodically(community.ID())
return community, changes, nil return community, changes, nil
} }
@ -537,10 +548,26 @@ func (m *Manager) EditCommunityTokenPermission(request *requests.EditCommunityTo
// //
// We do this in a separate routine to not block // We do this in a separate routine to not block
// this function // this function
go func() {
if tokenPermission.Type == protobuf.CommunityTokenPermission_BECOME_MEMBER { if tokenPermission.Type == protobuf.CommunityTokenPermission_BECOME_MEMBER {
go func() {
err := m.checkMemberPermissions(community.ID())
if err != nil {
m.logger.Debug("failed to check member permissions", zap.Error(err))
}
}()
}
return community, changes, nil
}
func (m *Manager) checkMemberPermissions(communityID types.HexBytes) error {
community, err := m.GetByID(communityID)
if err != nil {
return err
}
becomeMemberPermissions := community.TokenPermissionsByType(protobuf.CommunityTokenPermission_BECOME_MEMBER) becomeMemberPermissions := community.TokenPermissionsByType(protobuf.CommunityTokenPermission_BECOME_MEMBER)
if len(becomeMemberPermissions) > 0 {
for memberKey, member := range community.Members() { for memberKey, member := range community.Members() {
if memberKey == common.PubkeyToHex(&m.identity.PublicKey) { if memberKey == common.PubkeyToHex(&m.identity.PublicKey) {
continue continue
@ -553,27 +580,49 @@ func (m *Manager) EditCommunityTokenPermission(request *requests.EditCommunityTo
hasPermission, err := m.checkPermissionToJoin(becomeMemberPermissions, walletAddresses) hasPermission, err := m.checkPermissionToJoin(becomeMemberPermissions, walletAddresses)
if err != nil { if err != nil {
m.logger.Debug("failed to check permission to join", zap.Error(err)) return err
continue
} }
if !hasPermission { if !hasPermission {
pk, err := common.HexToPubkey(memberKey) pk, err := common.HexToPubkey(memberKey)
if err != nil { if err != nil {
m.logger.Debug("failed to convert hex key to pubkey", zap.Error(err)) return err
continue
} }
_, err = community.RemoveUserFromOrg(pk) _, err = community.RemoveUserFromOrg(pk)
if err != nil { if err != nil {
m.logger.Debug("failed to remove member from community", zap.Error(err)) return err
}
} }
} }
} }
m.publish(&Subscription{Community: community}) m.publish(&Subscription{Community: community})
} return nil
}() }
return community, changes, nil func (m *Manager) CheckMemberPermissionsPeriodically(communityID types.HexBytes) {
if _, exists := m.periodicMemberPermissionsTasks[communityID.String()]; exists {
return
}
cancel := make(chan struct{})
m.periodicMemberPermissionsTasks[communityID.String()] = cancel
ticker := time.NewTicker(memberPermissionsCheckInterval)
defer ticker.Stop()
for {
select {
case <-ticker.C:
err := m.checkMemberPermissions(communityID)
if err != nil {
m.logger.Debug("failed to check member permissions", zap.Error(err))
}
case <-cancel:
delete(m.periodicMemberPermissionsTasks, communityID.String())
return
}
}
} }
func (m *Manager) DeleteCommunityTokenPermission(request *requests.DeleteCommunityTokenPermission) (*Community, *CommunityChanges, error) { func (m *Manager) DeleteCommunityTokenPermission(request *requests.DeleteCommunityTokenPermission) (*Community, *CommunityChanges, error) {
@ -595,6 +644,14 @@ func (m *Manager) DeleteCommunityTokenPermission(request *requests.DeleteCommuni
return nil, nil, err return nil, nil, err
} }
// Check if there's stil BECOME_MEMBER permissions,
// if not we can stop checking token criteria on-chain
// for members
becomeMemberPermissions := community.TokenPermissionsByType(protobuf.CommunityTokenPermission_BECOME_MEMBER)
if cancel, exists := m.periodicMemberPermissionsTasks[community.IDString()]; exists && len(becomeMemberPermissions) == 0 {
close(cancel)
}
m.publish(&Subscription{Community: community}) m.publish(&Subscription{Community: community})
return community, changes, nil return community, changes, nil

View File

@ -729,6 +729,12 @@ func (m *Messenger) Start() (*MessengerResponse, error) {
<-available <-available
m.InitHistoryArchiveTasks(adminCommunities) m.InitHistoryArchiveTasks(adminCommunities)
}() }()
for _, c := range adminCommunities {
if c.Joined() {
go m.communitiesManager.CheckMemberPermissionsPeriodically(c.ID())
}
}
} }
} }