status-im/status-go
2
0
Fork 0
mirror of https://github.com/status-im/status-go.git synced 2025-02-18 01:37:22 +00:00
Code Issues Projects Releases Wiki Activity

Whitelist media.giphy.com

Browse Source
This commit is contained in:
Shivek Khurana 2021-02-03 16:57:04 +05:30 committed by Andrea Maria Piana
parent 55f7ad7496
commit 499f1702d1
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
protocol/urls/urls.go
View File

@ -73,6 +73,11 @@ func LinkPreviewWhitelist() []Site {
Address: "giphy.com", Address: "giphy.com",
ImageSite: true, ImageSite: true,
}, },
Site{
Title: "GIPHY GIFs subdomain",
Address: "media.giphy.com",
ImageSite: true,
},
Site{ Site{
Title: "GitHub", Title: "GitHub",
Address: "github.com", Address: "github.com",

17
protocol/urls/urls_test.go
View File

@ -32,6 +32,11 @@ func TestGetLinkPreviewData(t *testing.T) {
} }
// split at "." and ignore the first item
func thumbnailUrlWithoutSubdomain(url string) []string {
return strings.Split(url, ".")[1:]
}
func TestGetGiphyPreviewData(t *testing.T) { func TestGetGiphyPreviewData(t *testing.T) {
validGiphyLink := "https://giphy.com/gifs/FullMag-robot-boston-dynamics-dance-lcG3qwtTKSNI2i5vst" validGiphyLink := "https://giphy.com/gifs/FullMag-robot-boston-dynamics-dance-lcG3qwtTKSNI2i5vst"
previewData, err := GetGiphyPreviewData(validGiphyLink) previewData, err := GetGiphyPreviewData(validGiphyLink)
@ -46,11 +51,21 @@ func TestGetGiphyPreviewData(t *testing.T) {
// Giphy oembed returns links to different servers: https://media1.giphy.com, https://media2.giphy.com and so on // Giphy oembed returns links to different servers: https://media1.giphy.com, https://media2.giphy.com and so on
// We don't care about the server as long as other parts are equal, so we split at "." and ignore the first item // We don't care about the server as long as other parts are equal, so we split at "." and ignore the first item
require.Equal(t, strings.Split(bostonDynamicsEthGifData.ThumbnailURL, ".")[1:], strings.Split(previewData.ThumbnailURL, ".")[1:]) require.Equal(t, thumbnailUrlWithoutSubdomain(bostonDynamicsEthGifData.ThumbnailURL), thumbnailUrlWithoutSubdomain(previewData.ThumbnailURL))
invalidGiphyLink := "https://giphy.com/gifs/this-gif-does-not-exist-44444" invalidGiphyLink := "https://giphy.com/gifs/this-gif-does-not-exist-44444"
_, err = GetGiphyPreviewData(invalidGiphyLink) _, err = GetGiphyPreviewData(invalidGiphyLink)
require.Error(t, err) require.Error(t, err)
// Other link shapes
// shortLink := "https://gph.is/g/aXLyK7P"
mediaLink := "https://media.giphy.com/media/lcG3qwtTKSNI2i5vst/giphy.gif"
// shortLinkData, _ := GetGiphyPreviewData(shortLink)
mediaLinkData, _ := GetGiphyPreviewData(mediaLink)
require.Equal(t, thumbnailUrlWithoutSubdomain(mediaLinkData.ThumbnailURL), thumbnailUrlWithoutSubdomain(previewData.ThumbnailURL))
} }
func TestGetTenorPreviewData(t *testing.T) { func TestGetTenorPreviewData(t *testing.T) {