fix_: profile name not displayed on the login page for synced device in the fallback flow (#5876)

This commit is contained in:
Parvesh Monu 2024-09-27 20:18:53 +05:30 committed by GitHub
parent 7a23ac59c4
commit 42f715f123
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 28 additions and 0 deletions

View File

@ -1647,6 +1647,7 @@ func TestRestoreAccountAndLogin(t *testing.T) {
account, err := backend.RestoreAccountAndLogin(restoreRequest)
require.NoError(t, err)
require.NotNil(t, account)
require.Equal(t, "Account1", account.Name)
// Test case 2: Invalid restore account request
invalidRequest := &requests.RestoreAccount{}
@ -1660,6 +1661,29 @@ func TestRestoreAccountAndLogin(t *testing.T) {
require.Empty(t, mnemonic)
}
func TestRestoreAccountAndLoginWithoutDisplayName(t *testing.T) {
utils.Init()
tmpdir := t.TempDir()
backend := NewGethStatusBackend()
// Test case: Valid restore account request without DisplayName
restoreRequest := &requests.RestoreAccount{
Mnemonic: "test test test test test test test test test test test test",
FetchBackup: false,
CreateAccount: requests.CreateAccount{
DeviceName: "StatusIM",
Password: "password",
CustomizationColor: "0x000000",
RootDataDir: tmpdir,
},
}
account, err := backend.RestoreAccountAndLogin(restoreRequest)
require.NoError(t, err)
require.NotNil(t, account)
require.NotEmpty(t, account.Name)
}
func TestCreateAccountPathsValidation(t *testing.T) {
tmpdir := t.TempDir()

View File

@ -1492,6 +1492,10 @@ func (b *GethStatusBackend) prepareNodeAccount(request *requests.CreateAccount,
return nil, errors.Wrap(err, "failed to prepare settings")
}
if response.account.Name == "" {
response.account.Name = response.settings.Name
}
response.nodeConfig, err = b.prepareConfig(request, input, response.settings.InstallationID)
if err != nil {
return nil, errors.Wrap(err, "failed to prepare node config")