status-im
/
status-go
mirror of https://github.com/status-im/status-go.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed weird flow quirks

This commit is contained in:
Samuel Hawksby-Robinson 2024-03-14 12:48:12 +00:00
parent f6da4749f9
commit 0f55d60faf
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
_docs/policies/tests.md
View File

@ -37,17 +37,19 @@ Determine who caused the flaky test.
```mermaid ```mermaid
flowchart TB flowchart TB
A[PR ready for merge] --> B{Have any test failed?} A([PR ready for merge]) --> B{Have any test failed?}
B -->|No| C[🎉 Proceed with merge 🪄] B -->|No| C[🎉 Proceed with merge 🪄]
B -->|Yes| D{Did you write the test for this PR?} B -->|Yes| D{Did you write the test for this PR?}
D -->|No| E[Check rerun reports.] D -->|No| E[Check rerun reports.]
D -->|Yes| F[You MUST fix the test before merge is acceptable.] D -->|Yes| F[
It is likely your changes introduced the flakiness.
You MUST fix the test before merge is acceptable.
]
F --> A F --> A
E --> G{Does the test appear in `E:Flaky Test` issues<br/> or in the last three nightly test runs?<br/>} E --> G{Does the test appear in `E:Flaky Test` issues<br/> or in the last three nightly test runs?<br/>}
G -->|Yes| I[The flakiness MUST be reported] G -->|Yes| I[The flakiness needs reporting]
G -->|No| H[It is likely your changes introduced the flakiness] G -->|No| F
H --> F I --> J([Proceed to Reporting flow])
I --> J[Proceed to Reporting flow]
``` ```
#### Reporting Flaky Tests #### Reporting Flaky Tests
@ -74,8 +76,8 @@ flowchart TB
C -->|No| D[ C -->|No| D[
Create a new issue Create a new issue
- The issue title should include the flaky test name - The issue title should include the flaky test name
- The issue should use the https://github.com/status-im/status-go/labels/E%3AFlaky%20Test label - The issue should use the `E:Flaky Test` label
] ]
D --> E[ D --> E[
Detail which test is flaky and in what context: Detail which test is flaky and in what context:
local vs CI, link to the PR or branch. local vs CI, link to the PR or branch.