declare all parameters, fix names of files on release (#1392)

Signed-off-by: Jakub Sokołowski <jakub@status.im>

Makefile

@@ -220,7 +220,6 @@ release:
 
 gomobile-install:
 	go get -u golang.org/x/mobile/cmd/gomobile
-	gomobile init
 
 release-install:
 	go get -u github.com/c4milo/github-release

_assets/ci/Jenkinsfile

@@ -2,10 +2,15 @@ pipeline {
   agent { label 'linux' }
 
   parameters {
+    string(
+      name: 'BRANCH',
+      defaultValue: 'develop',
+      description: 'Name of branch to build.'
+    )
     booleanParam(
       name: 'RELEASE',
-      description: 'Enable to create a new release on GitHub and DigitalOcean Space.',
       defaultValue: false,
+      description: 'Enable to create a new release on GitHub and DigitalOcean Space.',
     )
   }
 

_assets/ci/Jenkinsfile.android

@@ -1,6 +1,19 @@
 pipeline {
   agent { label 'linux' }
 
+  parameters {
+    string(
+      name: 'BRANCH',
+      defaultValue: 'develop',
+      description: 'Name of branch to build.'
+    )
+    booleanParam(
+      name: 'RELEASE',
+      defaultValue: false,
+      description: 'Enable to create build for release.',
+    )
+  }
+
   options {
     timestamps()
     disableConcurrentBuilds()

_assets/ci/Jenkinsfile.ios

@@ -1,6 +1,19 @@
 pipeline {
   agent { label 'macos' }
 
+  parameters {
+    string(
+      name: 'BRANCH',
+      defaultValue: 'develop',
+      description: 'Name of branch to build.'
+    )
+    booleanParam(
+      name: 'RELEASE',
+      defaultValue: false,
+      description: 'Enable to create build for release.',
+    )
+  }
+
   options {
     timestamps()
     disableConcurrentBuilds()

_assets/ci/Jenkinsfile.linux

@@ -1,6 +1,19 @@
 pipeline {
   agent { label 'linux' }
 
+  parameters {
+    string(
+      name: 'BRANCH',
+      defaultValue: 'develop',
+      description: 'Name of branch to build.'
+    )
+    booleanParam(
+      name: 'RELEASE',
+      defaultValue: false,
+      description: 'Enable to create build for release.',
+    )
+  }
+
   options {
     timestamps()
     disableConcurrentBuilds()

_assets/ci/lib.groovy

@@ -62,8 +62,10 @@ def buildBranch(name = null, buildType = null) {
     /* this allows us to analize the job even after failure */
     propagate: false,
     parameters: [
-      [name: 'BRANCH',     value: branchName,    $class: 'StringParameterValue'],
+      [name: 'BRANCH',  value: branchName,     $class: 'StringParameterValue'],
-  ])
+      [name: 'RELEASE', value: params.RELEASE, $class: 'BooleanParameterValue'],
+    ]
+  )
   /* BlueOcean seems to not show child-build links */
   println "Build: ${resp.getAbsoluteUrl()} (${resp.result})"
   if (resp.result != 'SUCCESS') {