status-im
/
status-go
mirror of https://github.com/status-im/status-go.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
status-go/protocol/messenger_contact_verificat...

718 lines
33 KiB
Go
Raw Normal View History

Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
package protocol
import (
"context"
"testing"
"github.com/status-im/status-go/eth-node/crypto"
"github.com/status-im/status-go/protocol/common"
"github.com/status-im/status-go/protocol/requests"
"github.com/status-im/status-go/protocol/verification"
"github.com/stretchr/testify/suite"
"github.com/status-im/status-go/eth-node/types"
)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
func TestMessengerVerificationRequests(t *testing.T) { // nolint: deadcode,unused
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
suite.Run(t, new(MessengerVerificationRequests))
}
type MessengerVerificationRequests struct {
fix: close messenger's databases in tests
2023-11-27 17:01:13 +00:00
MessengerBaseTestSuite
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
}
func (s *MessengerVerificationRequests) SetupTest() {
fix: close messenger's databases in tests
2023-11-27 17:01:13 +00:00
s.MessengerBaseTestSuite.SetupTest()
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
// We start the messenger in order to receive installations
_, err := s.m.Start()
s.Require().NoError(err)
}
func (s *MessengerVerificationRequests) mutualContact(theirMessenger *Messenger) {
messageText := "hello!"
contactID := types.EncodeHex(crypto.FromECDSAPub(&theirMessenger.identity.PublicKey))
request := &requests.SendContactRequest{
Add spiff workflow cmd
2022-10-14 08:50:36 +00:00
ID: contactID,
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
Message: messageText,
}
// Send contact request
resp, err := s.m.SendContactRequest(context.Background(), request)
s.Require().NoError(err)
s.Require().NotNil(resp)
Add system message for mutual contact state updates (#3519) * feat: add mutual state update system message * feat: send mutual state update on accepting CR * feat: send mutual state update when removing a contact * fix: don't send MutualStateUpdateMessage over wire * fix: mutual state update message text fixed * fix: new clock to ensure system message after CR and add chat to the response * feat: add AC notification for contact removal * feat: replace "sent" mutual state system message with "added"
2023-06-08 12:00:19 +00:00
s.Require().Len(resp.Messages(), 2)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
// Make sure it's not returned as coming from us
contactRequests, _, err := s.m.PendingContactRequests("", 10)
s.Require().NoError(err)
s.Require().Len(contactRequests, 0)
// Make sure contact is added on the sender side
contacts := s.m.AddedContacts()
s.Require().Len(contacts, 1)
Split clock values for contacts
2023-01-20 14:28:30 +00:00
s.Require().Equal(ContactRequestStateSent, contacts[0].ContactRequestLocalState)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
theirMessenger,
func(r *MessengerResponse) bool {
return len(r.Contacts) > 0 && len(r.Messages()) > 0 && len(r.ActivityCenterNotifications()) > 0
},
"no messages",
)
// Check contact request has been received
s.Require().NoError(err)
// Check activity center notification is of the right type
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(ActivityCenterNotificationTypeContactRequest, resp.ActivityCenterNotifications()[0].Type)
s.Require().NotNil(resp.ActivityCenterNotifications()[0].Message)
s.Require().Equal(common.ContactRequestStatePending, resp.ActivityCenterNotifications()[0].Message.ContactRequestState)
// Check the contact state is correctly set
s.Require().Len(resp.Contacts, 1)
Split clock values for contacts
2023-01-20 14:28:30 +00:00
s.Require().Equal(ContactRequestStateReceived, resp.Contacts[0].ContactRequestRemoteState)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
// Make sure it's the pending contact requests
contactRequests, _, err = theirMessenger.PendingContactRequests("", 10)
s.Require().NoError(err)
s.Require().Len(contactRequests, 1)
s.Require().Equal(contactRequests[0].ContactRequestState, common.ContactRequestStatePending)
// Accept contact request, receiver side
resp, err = theirMessenger.AcceptContactRequest(context.Background(), &requests.AcceptContactRequest{ID: types.Hex2Bytes(contactRequests[0].ID)})
s.Require().NoError(err)
// Make sure the message is updated
s.Require().NotNil(resp)
Add system message for mutual contact state updates (#3519) * feat: add mutual state update system message * feat: send mutual state update on accepting CR * feat: send mutual state update when removing a contact * fix: don't send MutualStateUpdateMessage over wire * fix: mutual state update message text fixed * fix: new clock to ensure system message after CR and add chat to the response * feat: add AC notification for contact removal * feat: replace "sent" mutual state system message with "added"
2023-06-08 12:00:19 +00:00
s.Require().Len(resp.Messages(), 2)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), contactRequests[0].ID)
s.Require().NotNil(resp.ActivityCenterNotifications()[0].Message)
s.Require().Equal(common.ContactRequestStateAccepted, resp.ActivityCenterNotifications()[0].Message.ContactRequestState)
// Check the contact state is correctly set
s.Require().Len(resp.Contacts, 1)
Split clock values for contacts
2023-01-20 14:28:30 +00:00
s.Require().True(resp.Contacts[0].mutual())
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
// Make sure the sender is added to our contacts
contacts = theirMessenger.AddedContacts()
s.Require().Len(contacts, 1)
// Make sure we consider them a mutual contact, receiver side
mutualContacts := theirMessenger.MutualContacts()
s.Require().Len(mutualContacts, 1)
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
s.m,
func(r *MessengerResponse) bool {
Add system message for mutual contact state updates (#3519) * feat: add mutual state update system message * feat: send mutual state update on accepting CR * feat: send mutual state update when removing a contact * fix: don't send MutualStateUpdateMessage over wire * fix: mutual state update message text fixed * fix: new clock to ensure system message after CR and add chat to the response * feat: add AC notification for contact removal * feat: replace "sent" mutual state system message with "added"
2023-06-08 12:00:19 +00:00
return len(r.Contacts) == 1 && len(r.Messages()) == 2 && len(r.ActivityCenterNotifications()) == 1
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
},
"no messages",
)
s.Require().NoError(err)
// Check activity center notification is of the right type
s.Require().Equal(ActivityCenterNotificationTypeContactRequest, resp.ActivityCenterNotifications()[0].Type)
s.Require().NotNil(resp.ActivityCenterNotifications()[0].Message)
s.Require().Equal(common.ContactRequestStateAccepted, resp.ActivityCenterNotifications()[0].Message.ContactRequestState)
// Make sure the message is updated, sender s2de
s.Require().NotNil(resp)
Add system message for mutual contact state updates (#3519) * feat: add mutual state update system message * feat: send mutual state update on accepting CR * feat: send mutual state update when removing a contact * fix: don't send MutualStateUpdateMessage over wire * fix: mutual state update message text fixed * fix: new clock to ensure system message after CR and add chat to the response * feat: add AC notification for contact removal * feat: replace "sent" mutual state system message with "added"
2023-06-08 12:00:19 +00:00
s.Require().Len(resp.Messages(), 2)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
// Make sure we consider them a mutual contact, sender side
mutualContacts = s.m.MutualContacts()
s.Require().Len(mutualContacts, 1)
// Check the contact state is correctly set
s.Require().Len(resp.Contacts, 1)
Split clock values for contacts
2023-01-20 14:28:30 +00:00
s.Require().True(resp.Contacts[0].mutual())
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
}
Handle identity verifications
2022-10-24 11:33:47 +00:00
func (s *MessengerVerificationRequests) TestAcceptVerificationRequests() {
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
theirMessenger := s.newMessenger(s.shh)
_, err := theirMessenger.Start()
s.Require().NoError(err)
fix: close messenger's databases in tests
2023-11-27 17:01:13 +00:00
defer TearDownMessenger(&s.Suite, theirMessenger)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.mutualContact(theirMessenger)
theirPk := types.EncodeHex(crypto.FromECDSAPub(&theirMessenger.identity.PublicKey))
challenge := "challenge"
resp, err := s.m.SendContactVerificationRequest(context.Background(), theirPk, challenge)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
verificationRequestID := resp.VerificationRequests()[0].ID
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Len(resp.Messages(), 1)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.Require().NotEmpty(resp.Messages()[0].OutgoingStatus)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.Messages()[0].ContactVerificationState)
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
theirMessenger,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1 && len(r.ActivityCenterNotifications()) == 1
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Type, ActivityCenterNotificationTypeContactVerification)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusPENDING)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().NotNil(resp.ActivityCenterNotifications()[0].Message)
s.Require().Equal(challenge, resp.ActivityCenterNotifications()[0].Message.Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
s.Require().Len(resp.Messages(), 1)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.Require().Empty(resp.Messages()[0].OutgoingStatus)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.Messages()[0].ContactVerificationState)
resp, err = theirMessenger.AcceptContactVerificationRequest(context.Background(), verificationRequestID, "hello back")
s.Require().NoError(err)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
s.Require().Equal(resp.VerificationRequests()[0].RequestStatus, verification.RequestStatusACCEPTED)
s.Require().NotEmpty(resp.VerificationRequests()[0].RepliedAt)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusACCEPTED)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
feat: Add seen/unseen activity center setting (#3148) * feat: Add seen/unseen activity center state * feat: ActivityCenterState for grouping ActivityCenter unread messages cnt and seen state * feat: always use messenger's addActivityCenterNotification & add state to the response * Remove unused activity center endpoints form api and fix test
2023-02-17 10:08:08 +00:00
s.Require().Len(resp.Messages(), 2)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, resp.Messages()[0].ContactVerificationState)
Add reply message
2022-10-28 09:51:54 +00:00
s.Require().NotNil(resp.ActivityCenterNotifications()[0].ReplyMessage)
s.Require().NotEmpty(resp.ActivityCenterNotifications()[0].ReplyMessage.OutgoingStatus)
s.Require().Equal("hello back", resp.ActivityCenterNotifications()[0].ReplyMessage.Text)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
s.m,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
messages := resp.Messages()
Add reply message
2022-10-28 09:51:54 +00:00
s.Require().Len(messages, 2)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
var originalMessage *common.Message
var replyMessage *common.Message
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
if messages[0].ID == resp.VerificationRequests()[0].ID {
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
originalMessage = messages[0]
replyMessage = messages[1]
} else {
originalMessage = messages[1]
replyMessage = messages[0]
}
s.Require().Equal(common.ContactVerificationStateAccepted, originalMessage.ContactVerificationState)
// Not sure this is the right state for this, it should probably be pendingtrustedverification or something
s.Require().Equal(common.ContactVerificationStateAccepted, replyMessage.ContactVerificationState)
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusACCEPTED)
s.Require().Equal(common.ContactVerificationStateAccepted, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
s.Require().NotNil(resp.ActivityCenterNotifications()[0].ReplyMessage)
s.Require().Empty(resp.ActivityCenterNotifications()[0].ReplyMessage.OutgoingStatus)
s.Require().Equal("hello back", resp.ActivityCenterNotifications()[0].ReplyMessage.Text)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
resp, err = s.m.VerifiedTrusted(context.Background(), &requests.VerifiedTrusted{ID: types.FromHex(verificationRequestID)})
s.Require().NoError(err)
s.Require().NotNil(resp)
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusTRUSTED)
s.Require().Equal(common.ContactVerificationStateTrusted, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
s.Require().Len(resp.Messages(), 1)
s.Require().Equal(common.ContactVerificationStateTrusted, resp.Messages()[0].ContactVerificationState)
}
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
func (s *MessengerVerificationRequests) TestTrustedVerificationRequests() {
theirMessenger := s.newMessenger(s.shh)
_, err := theirMessenger.Start()
s.Require().NoError(err)
fix: close messenger's databases in tests
2023-11-27 17:01:13 +00:00
defer TearDownMessenger(&s.Suite, theirMessenger)
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
s.mutualContact(theirMessenger)
theirPk := types.EncodeHex(crypto.FromECDSAPub(&theirMessenger.identity.PublicKey))
challenge := "challenge"
resp, err := s.m.SendContactVerificationRequest(context.Background(), theirPk, challenge)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
verificationRequestID := resp.VerificationRequests()[0].ID
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
s.Require().Len(resp.Messages(), 1)
s.Require().NotEmpty(resp.Messages()[0].OutgoingStatus)
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.Messages()[0].ContactVerificationState)
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
theirMessenger,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1 && len(r.ActivityCenterNotifications()) == 1
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Type, ActivityCenterNotificationTypeContactVerification)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusPENDING)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
s.Require().NotNil(resp.ActivityCenterNotifications()[0].Message)
s.Require().Equal(challenge, resp.ActivityCenterNotifications()[0].Message.Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
s.Require().Len(resp.Messages(), 1)
s.Require().Empty(resp.Messages()[0].OutgoingStatus)
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.Messages()[0].ContactVerificationState)
resp, err = theirMessenger.AcceptContactVerificationRequest(context.Background(), verificationRequestID, "hello back")
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
s.Require().Equal(resp.VerificationRequests()[0].RequestStatus, verification.RequestStatusACCEPTED)
s.Require().NotEmpty(resp.VerificationRequests()[0].RepliedAt)
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusACCEPTED)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
feat: Add seen/unseen activity center setting (#3148) * feat: Add seen/unseen activity center state * feat: ActivityCenterState for grouping ActivityCenter unread messages cnt and seen state * feat: always use messenger's addActivityCenterNotification & add state to the response * Remove unused activity center endpoints form api and fix test
2023-02-17 10:08:08 +00:00
s.Require().Len(resp.Messages(), 2)
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, resp.Messages()[0].ContactVerificationState)
s.Require().NotNil(resp.ActivityCenterNotifications()[0].ReplyMessage)
s.Require().NotEmpty(resp.ActivityCenterNotifications()[0].ReplyMessage.OutgoingStatus)
s.Require().Equal("hello back", resp.ActivityCenterNotifications()[0].ReplyMessage.Text)
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
s.m,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
messages := resp.Messages()
s.Require().Len(messages, 2)
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusACCEPTED)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
s.Require().NotNil(resp.ActivityCenterNotifications()[0].ReplyMessage)
s.Require().Empty(resp.ActivityCenterNotifications()[0].ReplyMessage.OutgoingStatus)
s.Require().Equal("hello back", resp.ActivityCenterNotifications()[0].ReplyMessage.Text)
resp, err = s.m.VerifiedTrusted(context.Background(), &requests.VerifiedTrusted{ID: types.FromHex(verificationRequestID)})
s.Require().NoError(err)
s.Require().NotNil(resp)
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusTRUSTED)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
feat(ActivityCenter): Add missing AC notifications for verification requests (#3029) * feat(ActivityCenter): Add missing AC notifications for verification requests * fix(Contacts): Fix updates for trusted and untrustworthy statuses * feat(ActivityCenter): Add test for trusted verification request and AC notifications * feat(Contacts): Trusted and untrustworthy statuses should be unknown for verificated side
2022-12-26 04:35:46 +00:00
s.Require().Equal(common.ContactVerificationStateTrusted, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
s.Require().Len(resp.Messages(), 1)
s.Require().Equal(common.ContactVerificationStateTrusted, resp.Messages()[0].ContactVerificationState)
}
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
func (s *MessengerVerificationRequests) TestUnthrustworthyVerificationRequests() {
theirMessenger := s.newMessenger(s.shh)
_, err := theirMessenger.Start()
s.Require().NoError(err)
fix: close messenger's databases in tests
2023-11-27 17:01:13 +00:00
defer TearDownMessenger(&s.Suite, theirMessenger)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.mutualContact(theirMessenger)
theirPk := types.EncodeHex(crypto.FromECDSAPub(&theirMessenger.identity.PublicKey))
challenge := "challenge"
resp, err := s.m.SendContactVerificationRequest(context.Background(), theirPk, challenge)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
verificationRequestID := resp.VerificationRequests()[0].ID
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.Require().Len(resp.Messages(), 1)
s.Require().NotEmpty(resp.Messages()[0].OutgoingStatus)
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.Messages()[0].ContactVerificationState)
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
theirMessenger,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1 && len(r.ActivityCenterNotifications()) == 1
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Type, ActivityCenterNotificationTypeContactVerification)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusPENDING)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.Require().NotNil(resp.ActivityCenterNotifications()[0].Message)
s.Require().Equal(challenge, resp.ActivityCenterNotifications()[0].Message.Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
s.Require().Len(resp.Messages(), 1)
s.Require().Empty(resp.Messages()[0].OutgoingStatus)
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.Messages()[0].ContactVerificationState)
Add reply message
2022-10-28 09:51:54 +00:00
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
resp, err = theirMessenger.AcceptContactVerificationRequest(context.Background(), verificationRequestID, "hello back")
s.Require().NoError(err)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
s.Require().Equal(resp.VerificationRequests()[0].RequestStatus, verification.RequestStatusACCEPTED)
s.Require().NotEmpty(resp.VerificationRequests()[0].RepliedAt)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusACCEPTED)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
feat: Add seen/unseen activity center setting (#3148) * feat: Add seen/unseen activity center state * feat: ActivityCenterState for grouping ActivityCenter unread messages cnt and seen state * feat: always use messenger's addActivityCenterNotification & add state to the response * Remove unused activity center endpoints form api and fix test
2023-02-17 10:08:08 +00:00
s.Require().Len(resp.Messages(), 2)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, resp.Messages()[0].ContactVerificationState)
s.Require().NotNil(resp.ActivityCenterNotifications()[0].ReplyMessage)
s.Require().NotEmpty(resp.ActivityCenterNotifications()[0].ReplyMessage.OutgoingStatus)
s.Require().Equal("hello back", resp.ActivityCenterNotifications()[0].ReplyMessage.Text)
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
s.m,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
messages := resp.Messages()
s.Require().Len(messages, 2)
var originalMessage *common.Message
var replyMessage *common.Message
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
if messages[0].ID == resp.VerificationRequests()[0].ID {
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
originalMessage = messages[0]
replyMessage = messages[1]
} else {
originalMessage = messages[1]
replyMessage = messages[0]
}
Add reply message
2022-10-28 09:51:54 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, originalMessage.ContactVerificationState)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
// Not sure this is the right state for this, it should probably be pendingtrustedverification or something
Add reply message
2022-10-28 09:51:54 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, replyMessage.ContactVerificationState)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusACCEPTED)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
s.Require().Equal(common.ContactVerificationStateAccepted, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
Add reply message
2022-10-28 09:51:54 +00:00
s.Require().NotNil(resp.ActivityCenterNotifications()[0].ReplyMessage)
s.Require().Empty(resp.ActivityCenterNotifications()[0].ReplyMessage.OutgoingStatus)
s.Require().Equal("hello back", resp.ActivityCenterNotifications()[0].ReplyMessage.Text)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
resp, err = s.m.VerifiedUntrustworthy(context.Background(), &requests.VerifiedUntrustworthy{ID: types.FromHex(verificationRequestID)})
s.Require().NoError(err)
s.Require().NotNil(resp)
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusUNTRUSTWORTHY)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
Add notification for trustworthy/untrustworthy
2022-10-28 11:37:46 +00:00
s.Require().Equal(common.ContactVerificationStateUntrustworthy, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
s.Require().Len(resp.Messages(), 1)
s.Require().Equal(common.ContactVerificationStateUntrustworthy, resp.Messages()[0].ContactVerificationState)
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
}
Handle identity verifications
2022-10-24 11:33:47 +00:00
func (s *MessengerVerificationRequests) TestDeclineVerificationRequests() {
theirMessenger := s.newMessenger(s.shh)
_, err := theirMessenger.Start()
s.Require().NoError(err)
fix: close messenger's databases in tests
2023-11-27 17:01:13 +00:00
defer TearDownMessenger(&s.Suite, theirMessenger)
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.mutualContact(theirMessenger)
theirPk := types.EncodeHex(crypto.FromECDSAPub(&theirMessenger.identity.PublicKey))
challenge := "challenge"
resp, err := s.m.SendContactVerificationRequest(context.Background(), theirPk, challenge)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
verificationRequestID := resp.VerificationRequests()[0].ID
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().Len(resp.Messages(), 1)
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.Messages()[0].ContactVerificationState)
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
theirMessenger,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1 && len(r.ActivityCenterNotifications()) == 1
Handle identity verifications
2022-10-24 11:33:47 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Type, ActivityCenterNotificationTypeContactVerification)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusPENDING)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().NotNil(resp.ActivityCenterNotifications()[0].Message)
s.Require().Equal(challenge, resp.ActivityCenterNotifications()[0].Message.Text)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Message.ContactVerificationState, common.ContactVerificationStatePending)
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().Len(resp.Messages(), 1)
s.Require().Equal(challenge, resp.Messages()[0].Text)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Equal(resp.Messages()[0].ContactVerificationState, common.ContactVerificationStatePending)
Handle identity verifications
2022-10-24 11:33:47 +00:00
// Make sure it's stored and retrieved correctly
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
notification, err := theirMessenger.ActivityCenterNotification(types.FromHex(verificationRequestID))
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().NoError(err)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().NotNil(notification)
s.Require().Equal(notification.ContactVerificationStatus, verification.RequestStatusPENDING)
s.Require().Equal(notification.Message.ContactVerificationState, common.ContactVerificationStatePending)
s.Require().Equal(notification.Read, false)
s.Require().Equal(notification.Accepted, false)
s.Require().Equal(notification.Dismissed, false)
Handle identity verifications
2022-10-24 11:33:47 +00:00
resp, err = theirMessenger.DeclineContactVerificationRequest(context.Background(), verificationRequestID)
s.Require().NoError(err)
s.Require().NotNil(resp)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
s.Require().Equal(resp.VerificationRequests()[0].RequestStatus, verification.RequestStatusDECLINED)
s.Require().NotEmpty(resp.VerificationRequests()[0].RepliedAt)
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusDECLINED)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Message.ContactVerificationState, common.ContactVerificationStateDeclined)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, true)
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().Len(resp.Messages(), 1)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Equal(resp.Messages()[0].ContactVerificationState, common.ContactVerificationStateDeclined)
Handle identity verifications
2022-10-24 11:33:47 +00:00
// Make sure it's stored and retrieved correctly
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
notification, err = theirMessenger.ActivityCenterNotification(types.FromHex(verificationRequestID))
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().NoError(err)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().NotNil(notification)
s.Require().Equal(notification.ContactVerificationStatus, verification.RequestStatusDECLINED)
s.Require().Equal(notification.Message.ContactVerificationState, common.ContactVerificationStateDeclined)
s.Require().Equal(notification.Read, true)
s.Require().Equal(notification.Accepted, false)
s.Require().Equal(notification.Dismissed, true)
Handle identity verifications
2022-10-24 11:33:47 +00:00
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
s.m,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1
Handle identity verifications
2022-10-24 11:33:47 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().Len(resp.Messages(), 1)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Equal(resp.Messages()[0].ContactVerificationState, common.ContactVerificationStateDeclined)
Handle identity verifications
2022-10-24 11:33:47 +00:00
s.Require().Len(resp.ActivityCenterNotifications(), 1)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ID.String(), verificationRequestID)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusDECLINED)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Message.ContactVerificationState, common.ContactVerificationStateDeclined)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, true)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
}
func (s *MessengerVerificationRequests) TestCancelVerificationRequest() {
theirMessenger := s.newMessenger(s.shh)
_, err := theirMessenger.Start()
s.Require().NoError(err)
fix: close messenger's databases in tests
2023-11-27 17:01:13 +00:00
defer TearDownMessenger(&s.Suite, theirMessenger)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.mutualContact(theirMessenger)
theirPk := types.EncodeHex(crypto.FromECDSAPub(&theirMessenger.identity.PublicKey))
challenge := "challenge"
resp, err := s.m.SendContactVerificationRequest(context.Background(), theirPk, challenge)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
verificationRequestID := resp.VerificationRequests()[0].ID
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Len(resp.Messages(), 1)
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.Messages()[0].ContactVerificationState)
// Wait for the message to reach its destination
resp, err = WaitOnMessengerResponse(
theirMessenger,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1 && len(r.ActivityCenterNotifications()) == 1
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Type, ActivityCenterNotificationTypeContactVerification)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusPENDING)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().NotNil(resp.ActivityCenterNotifications()[0].Message)
s.Require().Equal(challenge, resp.ActivityCenterNotifications()[0].Message.Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.ActivityCenterNotifications()[0].Message.ContactVerificationState)
s.Require().Len(resp.Messages(), 1)
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(common.ContactVerificationStatePending, resp.Messages()[0].ContactVerificationState)
// Make sure it's stored and retrieved correctly
feat: refactor activity center endpoints (#3237) * feat: refactor activity center endpoints * fix: restore activity center tests using new endpoints * feat: Remove from activity center endpoints accepted flag * feat: Activity Center review fixes
2023-03-03 14:31:48 +00:00
notifications, err := theirMessenger.ActivityCenterNotifications(
ActivityCenterNotificationsRequest{
Cursor: "",
Limit: 4,
ActivityTypes: []ActivityCenterType{ActivityCenterNotificationTypeContactVerification},
ReadType: ActivityCenterQueryParamsReadUnread,
},
feat: Support fetching accepted Activity Center notifications by multiple types (#3088) Summary ======= - [x] Changes endpoint ActivityCenterNotificationsBy to support fetching multiple types of notification in a single query. - [x] Adds endpoint UnreadAndAcceptedActivityCenterNotificationsCount to allow the mobile client to fetch the count of unread & accepted notifications. - [x] Add `golangci-lint` to Nix shell. This was possible since PR https://github.com/status-im/status-go/pull/3087 was merged. Notes ===== - If you'd like to understand why these changes are needed, please see the mobile PR https://github.com/status-im/status-mobile/pull/14785, or issue https://github.com/status-im/status-mobile/issues/14712 - All changes should be completely backwards compatible, and there should be no impact for the desktop app. - The mobile client has been already tested using this branch.
2023-01-20 12:45:32 +00:00
)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().NoError(err)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Greater(len(notifications.Notifications), 0)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Equal(notifications.Notifications[0].ContactVerificationStatus, verification.RequestStatusPENDING)
s.Require().Equal(common.ContactVerificationStatePending, notifications.Notifications[0].Message.ContactVerificationState)
resp, err = s.m.CancelVerificationRequest(context.Background(), verificationRequestID)
s.Require().NoError(err)
s.Require().NotNil(resp)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
s.Require().Equal(resp.VerificationRequests()[0].RequestStatus, verification.RequestStatusCANCELED)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
// Check canceled state on the receiver's side
resp, err = WaitOnMessengerResponse(
theirMessenger,
func(r *MessengerResponse) bool {
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
return len(r.VerificationRequests()) == 1 && len(r.ActivityCenterNotifications()) == 1
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
},
"no messages",
)
s.Require().NoError(err)
Fix duplicated notifications on receiving contact update This commit fixes an issue where when accepting a contact request the other end would display an extra notification. It also changes WaitOnResponse to collect results. This should make tests less flaky, since sometimes messages are processed in different batches. Now we need to be though exact on what we expect from the response (i.e use == instead of >, otherwise the same behavior applies) This uncovered a couple of issues with messenger.Merge, so I have moved the struct to use a map based collection instead of an array.
2023-02-13 20:09:20 +00:00
s.Require().Len(resp.VerificationRequests(), 1)
s.Require().Equal(resp.VerificationRequests()[0].ID, verificationRequestID)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Type, ActivityCenterNotificationTypeContactVerification)
s.Require().Equal(resp.ActivityCenterNotifications()[0].ContactVerificationStatus, verification.RequestStatusCANCELED)
Mark as read acivated notifications with CTA (#3126) * fix: Accepting or dismissing contact request should mark AC notification as read * fix: Accepting or declining community request should mark AC notification as read * fix: Read notification status fo identity verification requests * fix: Save whole notification object while handling contact requests * fix: Remove unused functions from activity_center_persistence * fix: Use Accepted and Dismissed flags for AC notifications with CTA * fix: Mark notification as unread when we handle accepted verification request * fix: Replace Warn with Error on fail to save notification, test fixes * fix: Fix conditions for fetching AC notifications from the db * fix: Review fixes for err name and conditions array
2023-01-28 09:52:53 +00:00
s.Require().Equal(resp.ActivityCenterNotifications()[0].Read, true)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Accepted, false)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Dismissed, false)
feat(ActivityCenter): Add message for canceling contact requests (#2992) * feat(ActivityCenter): Add message for canceling contact requests * feat(Contacts): GetVerificationRequestSentTo returns last verification request * Fix error message in protocol/messenger_contact_verification.go Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com> Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
2022-12-14 08:27:02 +00:00
s.Require().NotNil(resp.ActivityCenterNotifications()[0].Message)
s.Require().Equal(challenge, resp.ActivityCenterNotifications()[0].Message.Text)
s.Require().Equal(resp.ActivityCenterNotifications()[0].Message.ContactVerificationState, common.ContactVerificationStateCanceled)
s.Require().Len(resp.Messages(), 1)
s.Require().Equal(challenge, resp.Messages()[0].Text)
s.Require().Equal(resp.Messages()[0].ContactVerificationState, common.ContactVerificationStateCanceled)
Handle identity verifications
2022-10-24 11:33:47 +00:00
}
Add read/unread messenger functions for activity center
2022-08-31 14:41:58 +00:00
func (s *MessengerVerificationRequests) newMessenger(shh types.Waku) *Messenger {
privateKey, err := crypto.GenerateKey()
s.Require().NoError(err)
messenger, err := newMessengerWithKey(s.shh, privateKey, s.logger, nil)
s.Require().NoError(err)
return messenger
}