2017-03-28 09:04:52 +00:00
|
|
|
package main
|
|
|
|
|
|
|
|
import (
|
2018-01-30 11:51:48 +00:00
|
|
|
"context"
|
2018-05-08 21:57:29 +00:00
|
|
|
"errors"
|
2017-11-03 22:07:13 +00:00
|
|
|
"flag"
|
2017-03-28 09:04:52 +00:00
|
|
|
"fmt"
|
2018-03-23 13:26:28 +00:00
|
|
|
stdlog "log"
|
2017-03-28 09:04:52 +00:00
|
|
|
"os"
|
2018-01-23 05:16:13 +00:00
|
|
|
"os/signal"
|
2017-03-28 09:04:52 +00:00
|
|
|
"runtime"
|
2017-11-03 22:07:13 +00:00
|
|
|
"strings"
|
2017-03-28 09:04:52 +00:00
|
|
|
|
2018-04-22 16:50:34 +00:00
|
|
|
"github.com/status-im/status-go/logutils"
|
|
|
|
|
2018-03-20 18:35:28 +00:00
|
|
|
"github.com/ethereum/go-ethereum/log"
|
2018-04-10 06:44:09 +00:00
|
|
|
"github.com/ethereum/go-ethereum/p2p/discv5"
|
2017-12-02 18:51:55 +00:00
|
|
|
"github.com/status-im/status-go/cmd/statusd/debug"
|
2018-04-09 06:26:06 +00:00
|
|
|
"github.com/status-im/status-go/cmd/statusd/topics"
|
2017-05-16 12:09:52 +00:00
|
|
|
"github.com/status-im/status-go/geth/api"
|
2018-03-27 16:30:37 +00:00
|
|
|
"github.com/status-im/status-go/geth/node"
|
2017-03-28 09:04:52 +00:00
|
|
|
"github.com/status-im/status-go/geth/params"
|
2018-01-30 11:51:48 +00:00
|
|
|
nodemetrics "github.com/status-im/status-go/metrics/node"
|
2018-03-23 13:58:40 +00:00
|
|
|
"github.com/status-im/status-go/profiling"
|
2017-03-28 09:04:52 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
2017-11-03 22:07:13 +00:00
|
|
|
gitCommit = "N/A" // rely on linker: -ldflags -X main.GitCommit"
|
|
|
|
buildStamp = "N/A" // rely on linker: -ldflags -X main.buildStamp"
|
2017-03-28 09:04:52 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
2018-03-19 16:22:09 +00:00
|
|
|
clusterConfigFile = flag.String("clusterconfig", "", "Cluster configuration file")
|
|
|
|
nodeKeyFile = flag.String("nodekey", "", "P2P node key file (private key)")
|
|
|
|
dataDir = flag.String("datadir", params.DataDir, "Data directory for the databases and keystore")
|
|
|
|
networkID = flag.Int("networkid", params.RopstenNetworkID, "Network identifier (integer, 1=Homestead, 3=Ropsten, 4=Rinkeby, 777=StatusChain)")
|
2018-03-21 08:45:50 +00:00
|
|
|
lesEnabled = flag.Bool("les", false, "Enable LES protocol")
|
|
|
|
whisperEnabled = flag.Bool("shh", false, "Enable Whisper protocol")
|
2018-05-08 21:57:29 +00:00
|
|
|
statusService = flag.String("status", "", `Enable StatusService, possible values: "ipc", "http"`)
|
2018-03-21 08:45:50 +00:00
|
|
|
swarmEnabled = flag.Bool("swarm", false, "Enable Swarm protocol")
|
2018-03-19 16:22:09 +00:00
|
|
|
maxPeers = flag.Int("maxpeers", 25, "maximum number of p2p peers (including all protocols)")
|
2018-03-21 08:45:50 +00:00
|
|
|
httpEnabled = flag.Bool("http", false, "Enable HTTP RPC endpoint")
|
2018-03-19 16:22:09 +00:00
|
|
|
httpHost = flag.String("httphost", "127.0.0.1", "HTTP RPC host of the listening socket")
|
|
|
|
httpPort = flag.Int("httpport", params.HTTPPort, "HTTP RPC server's listening port")
|
2018-05-28 16:37:09 +00:00
|
|
|
httpModules = flag.String("httpmodules", params.APIModules, "Comma separated list of HTTP RPC APIs")
|
2018-03-21 08:45:50 +00:00
|
|
|
ipcEnabled = flag.Bool("ipc", false, "Enable IPC RPC endpoint")
|
2018-05-09 23:59:05 +00:00
|
|
|
ipcFile = flag.String("ipcfile", "", "Set IPC file path")
|
2018-03-19 16:22:09 +00:00
|
|
|
cliEnabled = flag.Bool("cli", false, "Enable debugging CLI server")
|
|
|
|
cliPort = flag.String("cliport", debug.CLIPort, "CLI server's listening port")
|
2018-03-23 13:58:40 +00:00
|
|
|
pprofEnabled = flag.Bool("pprof", false, "Enable runtime profiling via pprof")
|
|
|
|
pprofPort = flag.Int("pprofport", 52525, "Port for runtime profiling via pprof")
|
2018-03-19 16:22:09 +00:00
|
|
|
logLevel = flag.String("log", "INFO", `Log level, one of: "ERROR", "WARN", "INFO", "DEBUG", and "TRACE"`)
|
|
|
|
logFile = flag.String("logfile", "", "Path to the log file")
|
|
|
|
version = flag.Bool("version", false, "Print version")
|
2018-01-17 20:07:45 +00:00
|
|
|
|
|
|
|
listenAddr = flag.String("listenaddr", ":30303", "IP address and port of this node (e.g. 127.0.0.1:30303)")
|
|
|
|
standalone = flag.Bool("standalone", true, "Don't actively connect to peers, wait for incoming connections")
|
2018-01-23 05:16:13 +00:00
|
|
|
bootnodes = flag.String("bootnodes", "", "A list of bootnodes separated by comma")
|
2018-02-06 12:53:04 +00:00
|
|
|
discovery = flag.Bool("discovery", false, "Enable discovery protocol")
|
2018-01-17 20:07:45 +00:00
|
|
|
|
2018-02-05 19:25:40 +00:00
|
|
|
// don't change the name of this flag, https://github.com/ethereum/go-ethereum/blob/master/metrics/metrics.go#L41
|
2018-05-16 15:36:59 +00:00
|
|
|
metrics = flag.Bool("metrics", false, "Expose ethereum metrics with debug_metrics jsonrpc call.")
|
2018-01-17 20:07:45 +00:00
|
|
|
// shh stuff
|
|
|
|
passwordFile = flag.String("shh.passwordfile", "", "Password file (password is used for symmetric encryption)")
|
|
|
|
minPow = flag.Float64("shh.pow", params.WhisperMinimumPoW, "PoW for messages to be added to queue, in float format")
|
|
|
|
ttl = flag.Int("shh.ttl", params.WhisperTTL, "Time to live for messages, in seconds")
|
2018-03-02 09:25:30 +00:00
|
|
|
lightClient = flag.Bool("shh.lightclient", false, "Start with empty bloom filter, and don't forward messages")
|
2018-01-17 20:07:45 +00:00
|
|
|
|
|
|
|
// MailServer
|
|
|
|
enableMailServer = flag.Bool("shh.mailserver", false, "Delivers expired messages on demand")
|
|
|
|
|
|
|
|
// Push Notification
|
|
|
|
firebaseAuth = flag.String("shh.firebaseauth", "", "FCM Authorization Key used for sending Push Notifications")
|
2018-02-07 10:48:03 +00:00
|
|
|
|
|
|
|
syncAndExit = flag.Int("sync-and-exit", -1, "Timeout in minutes for blockchain sync and exit, zero means no timeout unless sync is finished")
|
2018-04-10 06:44:09 +00:00
|
|
|
|
|
|
|
// Topics that will be search and registered by discovery v5.
|
2018-04-09 06:26:06 +00:00
|
|
|
searchTopics = topics.TopicLimitsFlag{}
|
|
|
|
registerTopics = topics.TopicFlag{}
|
2017-11-03 22:07:13 +00:00
|
|
|
)
|
2017-05-03 14:24:48 +00:00
|
|
|
|
2018-03-20 18:35:28 +00:00
|
|
|
// All general log messages in this package should be routed through this logger.
|
|
|
|
var logger = log.New("package", "status-go/cmd/statusd")
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
func main() {
|
2018-04-10 06:44:09 +00:00
|
|
|
flag.Var(&searchTopics, "topic.search", "Topic that will be searched in discovery v5, e.g (mailserver=1,1)")
|
|
|
|
flag.Var(®isterTopics, "topic.register", "Topic that will be registered using discovery v5.")
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
flag.Usage = printUsage
|
|
|
|
flag.Parse()
|
2018-05-17 13:03:23 +00:00
|
|
|
if flag.NArg() > 0 {
|
|
|
|
stdlog.Printf("Extra args in command line: %v", flag.Args())
|
|
|
|
printUsage()
|
|
|
|
os.Exit(1)
|
|
|
|
}
|
2017-05-03 14:24:48 +00:00
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
config, err := makeNodeConfig()
|
|
|
|
if err != nil {
|
2018-05-08 21:57:29 +00:00
|
|
|
stdlog.Fatalf("Making config failed, %s", err)
|
2017-05-16 03:24:56 +00:00
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
if *version {
|
|
|
|
printVersion(config, gitCommit, buildStamp)
|
|
|
|
return
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
2017-05-03 14:24:48 +00:00
|
|
|
|
2018-04-26 16:28:42 +00:00
|
|
|
if err := logutils.OverrideRootLog(config.LogEnabled, config.LogLevel, config.LogFile, true); err != nil {
|
2018-03-23 13:26:28 +00:00
|
|
|
stdlog.Fatalf("Error initializing logger: %s", err)
|
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
backend := api.NewStatusBackend()
|
2018-02-09 13:37:56 +00:00
|
|
|
err = backend.StartNode(config)
|
2017-11-03 22:07:13 +00:00
|
|
|
if err != nil {
|
2018-03-20 18:35:28 +00:00
|
|
|
logger.Error("Node start failed", "error", err)
|
2017-11-03 22:07:13 +00:00
|
|
|
return
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
2017-05-03 14:24:48 +00:00
|
|
|
|
2018-01-23 05:16:13 +00:00
|
|
|
// handle interrupt signals
|
2018-04-05 09:45:26 +00:00
|
|
|
interruptCh := haltOnInterruptSignal(backend.StatusNode())
|
2018-03-23 13:58:40 +00:00
|
|
|
|
2017-12-02 18:51:55 +00:00
|
|
|
// Check if debugging CLI connection shall be enabled.
|
|
|
|
if *cliEnabled {
|
|
|
|
err := startDebug(backend)
|
|
|
|
if err != nil {
|
2018-03-20 18:35:28 +00:00
|
|
|
logger.Error("Starting debugging CLI server failed", "error", err)
|
2017-12-02 18:51:55 +00:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-23 13:58:40 +00:00
|
|
|
// Check if profiling shall be enabled.
|
|
|
|
if *pprofEnabled {
|
|
|
|
profiling.NewProfiler(*pprofPort).Go()
|
|
|
|
}
|
|
|
|
|
2018-01-30 11:51:48 +00:00
|
|
|
// Run stats server.
|
2018-05-16 15:36:59 +00:00
|
|
|
if *metrics {
|
|
|
|
go startCollectingNodeMetrics(interruptCh, backend.StatusNode())
|
2018-01-30 11:51:48 +00:00
|
|
|
}
|
|
|
|
|
2018-02-07 10:48:03 +00:00
|
|
|
// Sync blockchain and stop.
|
|
|
|
if *syncAndExit >= 0 {
|
2018-04-05 09:45:26 +00:00
|
|
|
exitCode := syncAndStopNode(interruptCh, backend.StatusNode(), *syncAndExit)
|
2018-02-08 08:51:53 +00:00
|
|
|
// Call was interrupted. Wait for graceful shutdown.
|
|
|
|
if exitCode == -1 {
|
2018-04-16 12:36:09 +00:00
|
|
|
if node := backend.StatusNode().GethNode(); node != nil {
|
2018-02-08 08:51:53 +00:00
|
|
|
node.Wait()
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
// Otherwise, exit immediately with a returned exit code.
|
2018-02-07 10:48:03 +00:00
|
|
|
os.Exit(exitCode)
|
|
|
|
}
|
|
|
|
|
2018-04-16 12:36:09 +00:00
|
|
|
node := backend.StatusNode().GethNode()
|
|
|
|
if node != nil {
|
|
|
|
// wait till node has been stopped
|
|
|
|
node.Wait()
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
2017-11-03 22:07:13 +00:00
|
|
|
}
|
2017-05-03 14:24:48 +00:00
|
|
|
|
2017-12-02 18:51:55 +00:00
|
|
|
// startDebug starts the debugging API server.
|
|
|
|
func startDebug(backend *api.StatusBackend) error {
|
|
|
|
statusAPI := api.NewStatusAPIWithBackend(backend)
|
|
|
|
_, err := debug.New(statusAPI, *cliPort)
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2018-01-30 11:51:48 +00:00
|
|
|
// startCollectingStats collects various stats about the node and other protocols like Whisper.
|
2018-05-16 15:36:59 +00:00
|
|
|
func startCollectingNodeMetrics(interruptCh <-chan struct{}, statusNode *node.StatusNode) {
|
|
|
|
logger.Info("Starting collecting node metrics")
|
2018-01-30 11:51:48 +00:00
|
|
|
|
2018-04-16 12:36:09 +00:00
|
|
|
node := statusNode.GethNode()
|
|
|
|
if node == nil {
|
|
|
|
logger.Error("Failed to run metrics because it could not get the node")
|
2018-01-30 11:51:48 +00:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
|
|
defer cancel()
|
|
|
|
go func() {
|
|
|
|
if err := nodemetrics.SubscribeServerEvents(ctx, node); err != nil {
|
2018-03-20 18:35:28 +00:00
|
|
|
logger.Error("Failed to subscribe server events", "error", err)
|
2018-01-30 11:51:48 +00:00
|
|
|
}
|
|
|
|
}()
|
|
|
|
|
|
|
|
<-interruptCh
|
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
// makeNodeConfig parses incoming CLI options and returns node configuration object
|
|
|
|
func makeNodeConfig() (*params.NodeConfig, error) {
|
2018-04-26 17:59:57 +00:00
|
|
|
nodeConfig, err := params.NewNodeConfig(*dataDir, *clusterConfigFile, uint64(*networkID))
|
2017-11-03 22:07:13 +00:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
2017-09-01 18:44:50 +00:00
|
|
|
}
|
|
|
|
|
2018-02-06 12:53:04 +00:00
|
|
|
nodeConfig.ListenAddr = *listenAddr
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
// TODO(divan): move this logic into params package
|
|
|
|
if *nodeKeyFile != "" {
|
|
|
|
nodeConfig.NodeKeyFile = *nodeKeyFile
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
if *logLevel != "" {
|
|
|
|
nodeConfig.LogLevel = *logLevel
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
2018-04-26 16:28:42 +00:00
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
if *logFile != "" {
|
|
|
|
nodeConfig.LogFile = *logFile
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
|
|
|
|
2018-04-26 16:28:42 +00:00
|
|
|
if *logLevel != "" || *logFile != "" {
|
|
|
|
nodeConfig.LogEnabled = true
|
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
nodeConfig.RPCEnabled = *httpEnabled
|
|
|
|
nodeConfig.WhisperConfig.Enabled = *whisperEnabled
|
2018-02-05 10:12:57 +00:00
|
|
|
nodeConfig.MaxPeers = *maxPeers
|
2018-01-17 20:07:45 +00:00
|
|
|
|
2018-02-12 14:17:10 +00:00
|
|
|
nodeConfig.HTTPHost = *httpHost
|
2018-01-17 20:07:45 +00:00
|
|
|
nodeConfig.HTTPPort = *httpPort
|
2018-05-28 16:37:09 +00:00
|
|
|
nodeConfig.APIModules = *httpModules
|
2018-01-17 20:07:45 +00:00
|
|
|
nodeConfig.IPCEnabled = *ipcEnabled
|
|
|
|
|
2018-05-09 23:59:05 +00:00
|
|
|
if *ipcFile != "" {
|
|
|
|
nodeConfig.IPCEnabled = true
|
|
|
|
nodeConfig.IPCFile = *ipcFile
|
|
|
|
}
|
|
|
|
|
2018-01-17 21:40:14 +00:00
|
|
|
nodeConfig.LightEthConfig.Enabled = *lesEnabled
|
2017-11-03 22:07:13 +00:00
|
|
|
nodeConfig.SwarmConfig.Enabled = *swarmEnabled
|
2017-03-28 09:04:52 +00:00
|
|
|
|
2018-01-23 05:16:13 +00:00
|
|
|
if *standalone {
|
2018-03-20 14:05:21 +00:00
|
|
|
nodeConfig.ClusterConfig.Enabled = false
|
|
|
|
nodeConfig.ClusterConfig.BootNodes = nil
|
2018-01-23 05:16:13 +00:00
|
|
|
}
|
|
|
|
|
2018-05-10 11:45:51 +00:00
|
|
|
nodeConfig.NoDiscovery = !(*discovery)
|
2018-04-10 06:44:09 +00:00
|
|
|
nodeConfig.RequireTopics = map[discv5.Topic]params.Limits(searchTopics)
|
|
|
|
nodeConfig.RegisterTopics = []discv5.Topic(registerTopics)
|
2018-02-06 12:53:04 +00:00
|
|
|
|
2018-01-23 05:16:13 +00:00
|
|
|
// Even if standalone is true and discovery is disabled,
|
2018-03-20 14:05:21 +00:00
|
|
|
// it's possible to use bootnodes.
|
2018-01-23 05:16:13 +00:00
|
|
|
if *bootnodes != "" {
|
2018-03-20 14:05:21 +00:00
|
|
|
nodeConfig.ClusterConfig.BootNodes = strings.Split(*bootnodes, ",")
|
2018-01-23 05:16:13 +00:00
|
|
|
}
|
|
|
|
|
2018-05-08 21:57:29 +00:00
|
|
|
nodeConfig, err = configureStatusService(*statusService, nodeConfig)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
2018-01-17 20:07:45 +00:00
|
|
|
if *whisperEnabled {
|
|
|
|
return whisperConfig(nodeConfig)
|
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
// RPC configuration
|
|
|
|
if !*httpEnabled {
|
|
|
|
nodeConfig.HTTPHost = "" // HTTP RPC is disabled
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
2017-11-03 22:07:13 +00:00
|
|
|
|
|
|
|
return nodeConfig, nil
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
|
|
|
|
2018-05-08 21:57:29 +00:00
|
|
|
var errStatusServiceRequiresIPC = errors.New("to enable the StatusService on IPC, -ipc flag must be set")
|
|
|
|
var errStatusServiceRequiresHTTP = errors.New("to enable the StatusService on HTTP, -http flag must be set")
|
|
|
|
var errStatusServiceInvalidFlag = errors.New("-status flag valid values are: ipc, http")
|
|
|
|
|
|
|
|
func configureStatusService(flagValue string, nodeConfig *params.NodeConfig) (*params.NodeConfig, error) {
|
|
|
|
switch flagValue {
|
|
|
|
case "ipc":
|
|
|
|
if !nodeConfig.IPCEnabled {
|
|
|
|
return nil, errStatusServiceRequiresIPC
|
|
|
|
}
|
|
|
|
nodeConfig.StatusServiceEnabled = true
|
|
|
|
case "http":
|
|
|
|
if !nodeConfig.RPCEnabled {
|
|
|
|
return nil, errStatusServiceRequiresHTTP
|
|
|
|
}
|
|
|
|
nodeConfig.StatusServiceEnabled = true
|
|
|
|
nodeConfig.AddAPIModule("status")
|
|
|
|
case "":
|
|
|
|
nodeConfig.StatusServiceEnabled = false
|
|
|
|
default:
|
|
|
|
return nil, errStatusServiceInvalidFlag
|
|
|
|
}
|
|
|
|
|
|
|
|
return nodeConfig, nil
|
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
// printVersion prints verbose output about version and config.
|
|
|
|
func printVersion(config *params.NodeConfig, gitCommit, buildStamp string) {
|
|
|
|
if gitCommit != "" && len(gitCommit) > 8 {
|
|
|
|
params.Version += "-" + gitCommit[:8]
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
fmt.Println(strings.Title(params.ClientIdentifier))
|
|
|
|
fmt.Println("Version:", params.Version)
|
|
|
|
if gitCommit != "" {
|
|
|
|
fmt.Println("Git Commit:", gitCommit)
|
2017-09-01 18:44:50 +00:00
|
|
|
}
|
2017-11-03 22:07:13 +00:00
|
|
|
if buildStamp != "" {
|
|
|
|
fmt.Println("Build Stamp:", buildStamp)
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
fmt.Println("Network Id:", config.NetworkID)
|
|
|
|
fmt.Println("Go Version:", runtime.Version())
|
|
|
|
fmt.Println("OS:", runtime.GOOS)
|
|
|
|
fmt.Printf("GOPATH=%s\n", os.Getenv("GOPATH"))
|
|
|
|
fmt.Printf("GOROOT=%s\n", runtime.GOROOT())
|
|
|
|
|
|
|
|
config.LightEthConfig.Genesis = "SKIP"
|
|
|
|
fmt.Println("Loaded Config: ", config)
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
|
|
|
|
2017-11-03 22:07:13 +00:00
|
|
|
func printUsage() {
|
2018-01-17 16:46:21 +00:00
|
|
|
usage := `
|
|
|
|
Usage: statusd [options]
|
2017-11-03 22:07:13 +00:00
|
|
|
Examples:
|
|
|
|
statusd # run status node with defaults
|
|
|
|
statusd -networkid 4 # run node on Rinkeby network
|
|
|
|
statusd -datadir /dir # specify different dir for data
|
|
|
|
statusd -ipc # enable IPC for usage with "geth attach"
|
2017-12-02 18:51:55 +00:00
|
|
|
statusd -cli # enable connection by statusd-cli on default port
|
2017-11-03 22:07:13 +00:00
|
|
|
|
|
|
|
Options:
|
2018-01-17 16:46:21 +00:00
|
|
|
`
|
Remove //nolint: gas directives from fmt.Fprintf #590 (#656)
Summary:
Filter out gas linter error checks for fmt.Fprintf commands. This required defining a custom linter around gas that additionally included the offending code.
Notes:
Gas format, without piping it through gometalinter, gives output like this:
$ gas -fmt=csv geth/jail/console/console.go
geth/jail/console/console.go,21,Errors unhandled.,LOW,HIGH,"fmt.Fprintf(w, ""%s: %s"", consoleEventName, formatForConsole(fn.ArgumentList))"
Gometalinter, by default, does not grab the line of code when it filters gas errors. To resolve this, I created a wrapper around gas (I wasn't sure what to call this "gas wrapper", I opted for gasv2, open to other names).
The first part of the regular expression was taken directly from gometalinter (see https://github.com/alecthomas/gometalinter/blob/master/linters.go#L236), and I then appended ,\".*\" to additionally grab the line of code of the offending line. Lastly, I excluded ".*Errors unhandled.*fmt.Fprintf.*" to filter out only fmt.Fprintf errors around omitted errors.
Also as a result of this change, gas lint output will now include the offending code.
Closes #590
2018-02-14 17:58:20 +00:00
|
|
|
fmt.Fprintf(os.Stderr, usage)
|
2017-11-03 22:07:13 +00:00
|
|
|
flag.PrintDefaults()
|
2017-03-28 09:04:52 +00:00
|
|
|
}
|
2018-01-23 05:16:13 +00:00
|
|
|
|
|
|
|
// haltOnInterruptSignal catches interrupt signal (SIGINT) and
|
|
|
|
// stops the node. It times out after 5 seconds
|
|
|
|
// if the node can not be stopped.
|
2018-04-05 09:45:26 +00:00
|
|
|
func haltOnInterruptSignal(statusNode *node.StatusNode) <-chan struct{} {
|
2018-01-30 11:51:48 +00:00
|
|
|
interruptCh := make(chan struct{})
|
|
|
|
go func() {
|
|
|
|
signalCh := make(chan os.Signal, 1)
|
|
|
|
signal.Notify(signalCh, os.Interrupt)
|
|
|
|
defer signal.Stop(signalCh)
|
|
|
|
<-signalCh
|
|
|
|
close(interruptCh)
|
2018-03-20 18:35:28 +00:00
|
|
|
logger.Info("Got interrupt, shutting down...")
|
2018-04-05 09:45:26 +00:00
|
|
|
if err := statusNode.Stop(); err != nil {
|
2018-03-20 18:35:28 +00:00
|
|
|
logger.Error("Failed to stop node", "error", err)
|
2018-01-30 11:51:48 +00:00
|
|
|
os.Exit(1)
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
return interruptCh
|
2018-01-23 05:16:13 +00:00
|
|
|
}
|