status-im
/
status-go
mirror of https://github.com/status-im/status-go.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
status-go/protocol/message_validator_test.go

418 lines
9.9 KiB
Go
Raw Normal View History

Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
package protocol
import (
"testing"
"github.com/stretchr/testify/suite"
Use goimports instead of gofmt
2020-01-02 09:10:19 +00:00
"github.com/status-im/status-go/protocol/protobuf"
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
)
type MessageValidatorSuite struct {
suite.Suite
}
func TestMessageValidatorSuite(t *testing.T) {
suite.Run(t, new(MessageValidatorSuite))
}
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
func (s *MessageValidatorSuite) TestValidateRequestAddressForTransaction() {
testCases := []struct {
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name string
WhisperTimestamp uint64
Valid bool
Message protobuf.RequestAddressForTransaction
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
}{
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "valid message",
WhisperTimestamp: 30,
Valid: true,
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
Message: protobuf.RequestAddressForTransaction{
Clock: 30,
Value: "0.34",
Contract: "some contract",
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "missing clock value",
WhisperTimestamp: 30,
Valid: false,
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
Message: protobuf.RequestAddressForTransaction{
Value: "0.34",
Contract: "some contract",
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "missing value",
WhisperTimestamp: 30,
Valid: false,
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
Message: protobuf.RequestAddressForTransaction{
Clock: 30,
Contract: "some contract",
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "non number value",
WhisperTimestamp: 30,
Valid: false,
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
Message: protobuf.RequestAddressForTransaction{
Clock: 30,
Value: "most definitely not a number",
Contract: "some contract",
},
},
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
{
Name: "Clock value too high",
WhisperTimestamp: 30,
Valid: false,
Message: protobuf.RequestAddressForTransaction{
Clock: 151000,
Value: "0.34",
Contract: "some contract",
},
},
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
}
for _, tc := range testCases {
s.Run(tc.Name, func() {
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
err := ValidateReceivedRequestAddressForTransaction(&tc.Message, tc.WhisperTimestamp)
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
if tc.Valid {
s.Nil(err)
} else {
s.NotNil(err)
}
})
}
}
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
func (s *MessageValidatorSuite) TestValidatePlainTextMessage() {
testCases := []struct {
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name string
WhisperTimestamp uint64
Valid bool
Message protobuf.ChatMessage
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
}{
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "A valid message",
WhisperTimestamp: 2,
Valid: true,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Clock: 1,
Timestamp: 2,
Text: "some-text",
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Missing chatId",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
Clock: 1,
Timestamp: 2,
Text: "some-text",
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Missing clock",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Timestamp: 2,
Text: "some-text",
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Clock value too high",
WhisperTimestamp: 2,
Valid: false,
Message: protobuf.ChatMessage{
ChatId: "a",
Clock: 133000,
Timestamp: 1,
Text: "some-text",
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Name: "Missing timestamp",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Clock: 2,
Text: "some-text",
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Missing text",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Blank text",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Text: " \n \t \n ",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Unknown MessageType",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_UNKNOWN_MESSAGE_TYPE,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Unknown ContentType",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_UNKNOWN_CONTENT_TYPE,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "System message MessageType",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_SYSTEM_MESSAGE_PRIVATE_GROUP,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Request address for transaction message type",
WhisperTimestamp: 2,
Valid: false,
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_TRANSACTION_COMMAND,
},
},
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Valid emoji only emssage",
WhisperTimestamp: 2,
Valid: true,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Text: ":+1:",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_EMOJI,
},
},
// TODO: FIX ME
/* {
Name: "Invalid emoji only emssage",
Valid: false,
Message: protobuf.ChatMessage{
Remove protocol and eth-node submodules (#1835)
2020-02-10 11:22:37 +00:00
ChatID: "a",
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Text: ":+1: not valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_EMOJI,
},
}
,*/
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Valid sticker message",
WhisperTimestamp: 2,
Valid: true,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Sticker{
Sticker: &protobuf.StickerMessage{
Pack: 1,
Hash: "some-hash",
},
},
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_STICKER,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Invalid sticker message without Hash",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Sticker{
Sticker: &protobuf.StickerMessage{
Pack: 1,
},
},
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_STICKER,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Invalid sticker message without any content",
WhisperTimestamp: 2,
Valid: false,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_STICKER,
},
},
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
{
Name: "Valid image message",
WhisperTimestamp: 2,
Valid: true,
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Image{
Image: &protobuf.ImageMessage{
Type: 1,
Payload: []byte("some-payload"),
},
},
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_IMAGE,
},
},
{
Name: "Invalid image message, type unknown",
WhisperTimestamp: 2,
Valid: false,
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Image{
Image: &protobuf.ImageMessage{
Type: protobuf.ImageMessage_UNKNOWN_IMAGE_TYPE,
Payload: []byte("some-payload"),
},
},
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_STICKER,
},
},
{
Name: "Invalid image message, missing payload",
WhisperTimestamp: 2,
Valid: false,
Message: protobuf.ChatMessage{
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Image{
Image: &protobuf.ImageMessage{
Type: 1,
},
},
MessageType: protobuf.ChatMessage_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_IMAGE,
},
},
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
}
for _, tc := range testCases {
s.Run(tc.Name, func() {
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
err := ValidateReceivedChatMessage(&tc.Message, tc.WhisperTimestamp)
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
if tc.Valid {
s.Nil(err)
} else {
s.NotNil(err)
}
})
}
}