status-im
/
status-go
mirror of https://github.com/status-im/status-go.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
status-go/protocol/message_validator_test.go

598 lines
14 KiB
Go
Raw Normal View History

Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
package protocol
import (
Count runes and not characters
2020-09-25 08:12:02 +00:00
"strings"
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
"testing"
"github.com/stretchr/testify/suite"
Use goimports instead of gofmt
2020-01-02 09:10:19 +00:00
"github.com/status-im/status-go/protocol/protobuf"
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
)
type MessageValidatorSuite struct {
suite.Suite
}
func TestMessageValidatorSuite(t *testing.T) {
suite.Run(t, new(MessageValidatorSuite))
}
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
func (s *MessageValidatorSuite) TestValidateRequestAddressForTransaction() {
testCases := []struct {
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name string
WhisperTimestamp uint64
Valid bool
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message *protobuf.RequestAddressForTransaction
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
}{
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "valid message",
WhisperTimestamp: 30,
Valid: true,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.RequestAddressForTransaction{
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
Clock: 30,
Value: "0.34",
Contract: "some contract",
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "missing clock value",
WhisperTimestamp: 30,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.RequestAddressForTransaction{
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
Value: "0.34",
Contract: "some contract",
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "missing value",
WhisperTimestamp: 30,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.RequestAddressForTransaction{
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
Clock: 30,
Contract: "some contract",
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "non number value",
WhisperTimestamp: 30,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.RequestAddressForTransaction{
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
Clock: 30,
Value: "most definitely not a number",
Contract: "some contract",
},
},
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
{
Name: "Clock value too high",
WhisperTimestamp: 30,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.RequestAddressForTransaction{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Clock: 151000,
Value: "0.34",
Contract: "some contract",
},
},
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
}
for _, tc := range testCases {
s.Run(tc.Name, func() {
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
err := ValidateReceivedRequestAddressForTransaction(tc.Message, tc.WhisperTimestamp)
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
if tc.Valid {
s.Nil(err)
} else {
s.NotNil(err)
}
})
}
}
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
func (s *MessageValidatorSuite) TestValidatePlainTextMessage() {
testCases := []struct {
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name string
WhisperTimestamp uint64
Valid bool
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message *protobuf.ChatMessage
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
}{
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "A valid message",
WhisperTimestamp: 2,
Valid: true,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Clock: 1,
Timestamp: 2,
Count runes and not characters
2020-09-25 08:12:02 +00:00
Text: strings.Repeat("É", maxChatMessageTextLength),
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Missing chatId",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Clock: 1,
Timestamp: 2,
Text: "some-text",
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Missing clock",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Timestamp: 2,
Text: "some-text",
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Clock value too high",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
ChatId: "a",
Clock: 133000,
Timestamp: 1,
Text: "some-text",
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Name: "Missing timestamp",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Clock: 2,
Text: "some-text",
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Missing text",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Blank text",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Text: " \n \t \n ",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
Drop messages with text longer than 4096 characters (#2029)
2020-09-01 14:38:36 +00:00
{
Name: "Too long text",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Drop messages with text longer than 4096 characters (#2029)
2020-09-01 14:38:36 +00:00
ChatId: "a",
Clock: 1,
Timestamp: 2,
Count runes and not characters
2020-09-25 08:12:02 +00:00
Text: strings.Repeat("É", maxChatMessageTextLength+1),
Drop messages with text longer than 4096 characters (#2029)
2020-09-01 14:38:36 +00:00
ResponseTo: "",
EnsName: "",
MessageType: protobuf.MessageType_ONE_TO_ONE,
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Unknown MessageType",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_UNKNOWN_MESSAGE_TYPE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Unknown ContentType",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_UNKNOWN_CONTENT_TYPE,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "System message MessageType",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_SYSTEM_MESSAGE_PRIVATE_GROUP,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_TEXT_PLAIN,
},
},
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Request address for transaction message type",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Add Commands (#1731) This commit adds handling of Transaction commands.
2020-01-10 18:59:01 +00:00
ContentType: protobuf.ChatMessage_TRANSACTION_COMMAND,
},
},
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Valid emoji only emssage",
WhisperTimestamp: 2,
Valid: true,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Text: ":+1:",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_EMOJI,
},
},
// TODO: FIX ME
/* {
Name: "Invalid emoji only emssage",
Valid: false,
Message: protobuf.ChatMessage{
Remove protocol and eth-node submodules (#1835)
2020-02-10 11:22:37 +00:00
ChatID: "a",
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
Text: ":+1: not valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
add endpoint for getting emojis
2020-07-27 15:57:01 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_EMOJI,
},
}
,*/
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Valid sticker message",
WhisperTimestamp: 2,
Valid: true,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Sticker{
Sticker: &protobuf.StickerMessage{
Pack: 1,
Hash: "some-hash",
},
},
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_STICKER,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Invalid sticker message without Hash",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Sticker{
Sticker: &protobuf.StickerMessage{
Pack: 1,
},
},
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_STICKER,
},
},
{
Peg clock value to whisper timestamp (#1804) This commit pegs the clock value to maximum + 120 seconds from the whisper timestamp. In this way the we avoid the scenario where a client makes the timestamp increase arbitrarely.
2020-01-20 16:44:32 +00:00
Name: "Invalid sticker message without any content",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
ContentType: protobuf.ChatMessage_STICKER,
},
},
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
{
Name: "Valid image message",
WhisperTimestamp: 2,
Valid: true,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Image{
Image: &protobuf.ImageMessage{
(fix/status-go) fix profile picture update/removal (#4570) This PR fixes [9947](status-im/status-desktop#9947) and contains : - Commit to fix the changing of custom picture and having the change reflected on contact's side - Commit to fix the deleting of picture and having the change reflected on contact's side - Rename confusing `ImageType` to `ImageFormat`
2024-01-24 20:09:28 +00:00
Format: 1,
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
Payload: []byte("some-payload"),
},
},
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
ContentType: protobuf.ChatMessage_IMAGE,
},
},
{
Name: "Invalid image message, type unknown",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Image{
Image: &protobuf.ImageMessage{
(fix/status-go) fix profile picture update/removal (#4570) This PR fixes [9947](status-im/status-desktop#9947) and contains : - Commit to fix the changing of custom picture and having the change reflected on contact's side - Commit to fix the deleting of picture and having the change reflected on contact's side - Rename confusing `ImageType` to `ImageFormat`
2024-01-24 20:09:28 +00:00
Format: protobuf.ImageFormat_UNKNOWN_IMAGE_FORMAT,
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
Payload: []byte("some-payload"),
},
},
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
ContentType: protobuf.ChatMessage_STICKER,
},
},
{
Name: "Invalid image message, missing payload",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Image{
Image: &protobuf.ImageMessage{
(fix/status-go) fix profile picture update/removal (#4570) This PR fixes [9947](status-im/status-desktop#9947) and contains : - Commit to fix the changing of custom picture and having the change reflected on contact's side - Commit to fix the deleting of picture and having the change reflected on contact's side - Rename confusing `ImageType` to `ImageFormat`
2024-01-24 20:09:28 +00:00
Format: 1,
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
},
},
Updated all MessageType references
2020-07-25 11:46:43 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Add support for images This commit adds support for images in protobuf messages. The client can specify a path which will be used to load the image and set the corresponding fields. This makes the assumption that the RCP server runs on the same machine as the client and they have access to the same files. This holds currently for both status-react and status-console-client, we could revisit and adds an upload if that changes in the future.
2020-05-13 13:16:17 +00:00
ContentType: protobuf.ChatMessage_IMAGE,
},
},
Add audio messages Why make this change? We are adding support of audio recorded files, similarly to how we did with images What has changed? - Added protobuf definition, only AAC supported - Added migrations to store files - Fixed an issue with nil pointer when transaction would fail to be created, causing the application to crash
2020-06-17 18:55:49 +00:00
{
Name: "Valid audio message",
WhisperTimestamp: 2,
Valid: true,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Add audio messages Why make this change? We are adding support of audio recorded files, similarly to how we did with images What has changed? - Added protobuf definition, only AAC supported - Added migrations to store files - Fixed an issue with nil pointer when transaction would fail to be created, causing the application to crash
2020-06-17 18:55:49 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Audio{
Audio: &protobuf.AudioMessage{
Type: 1,
Payload: []byte("some-payload"),
},
},
add endpoint for getting emojis
2020-07-27 15:57:01 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Add audio messages Why make this change? We are adding support of audio recorded files, similarly to how we did with images What has changed? - Added protobuf definition, only AAC supported - Added migrations to store files - Fixed an issue with nil pointer when transaction would fail to be created, causing the application to crash
2020-06-17 18:55:49 +00:00
ContentType: protobuf.ChatMessage_AUDIO,
},
},
{
Name: "Invalid audio message, type unknown",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Add audio messages Why make this change? We are adding support of audio recorded files, similarly to how we did with images What has changed? - Added protobuf definition, only AAC supported - Added migrations to store files - Fixed an issue with nil pointer when transaction would fail to be created, causing the application to crash
2020-06-17 18:55:49 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Audio{
Audio: &protobuf.AudioMessage{
Type: protobuf.AudioMessage_UNKNOWN_AUDIO_TYPE,
Payload: []byte("some-payload"),
},
},
add endpoint for getting emojis
2020-07-27 15:57:01 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Add audio messages Why make this change? We are adding support of audio recorded files, similarly to how we did with images What has changed? - Added protobuf definition, only AAC supported - Added migrations to store files - Fixed an issue with nil pointer when transaction would fail to be created, causing the application to crash
2020-06-17 18:55:49 +00:00
ContentType: protobuf.ChatMessage_STICKER,
},
},
{
Name: "Invalid audio message, missing payload",
WhisperTimestamp: 2,
Valid: false,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.ChatMessage{
Add audio messages Why make this change? We are adding support of audio recorded files, similarly to how we did with images What has changed? - Added protobuf definition, only AAC supported - Added migrations to store files - Fixed an issue with nil pointer when transaction would fail to be created, causing the application to crash
2020-06-17 18:55:49 +00:00
ChatId: "a",
Text: "valid",
Clock: 2,
Timestamp: 3,
ResponseTo: "",
EnsName: "",
Payload: &protobuf.ChatMessage_Audio{
Audio: &protobuf.AudioMessage{
Type: 1,
},
},
add endpoint for getting emojis
2020-07-27 15:57:01 +00:00
MessageType: protobuf.MessageType_ONE_TO_ONE,
Add audio messages Why make this change? We are adding support of audio recorded files, similarly to how we did with images What has changed? - Added protobuf definition, only AAC supported - Added migrations to store files - Fixed an issue with nil pointer when transaction would fail to be created, causing the application to crash
2020-06-17 18:55:49 +00:00
ContentType: protobuf.ChatMessage_AUDIO,
},
},
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
}
for _, tc := range testCases {
s.Run(tc.Name, func() {
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
err := ValidateReceivedChatMessage(tc.Message, tc.WhisperTimestamp)
Handle membership update message This commit does a few things: 1) Handle membership updates using protobuf and adds the relevant endpoints. 2) Store in memory a map of chats + contacts for faster lookups, which are then flushed to disk on each update 3) Validate incoming messages Sorry for the large pr, but you know, v1 :)
2019-12-02 15:34:05 +00:00
if tc.Valid {
s.Nil(err)
} else {
s.NotNil(err)
}
})
}
}
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
func (s *MessageValidatorSuite) TestValidateEmojiReaction() {
testCases := []struct {
Name string
Valid bool
WhisperTimestamp uint64
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message *protobuf.EmojiReaction
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
}{
{
Name: "valid emoji reaction",
Valid: true,
WhisperTimestamp: 30,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.EmojiReaction{
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
Clock: 30,
ChatId: "chat-id",
MessageId: "message-id",
MessageType: protobuf.MessageType_ONE_TO_ONE,
Type: protobuf.EmojiReaction_LOVE,
},
},
{
Name: "valid emoji retraction",
Valid: true,
WhisperTimestamp: 30,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.EmojiReaction{
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
Clock: 30,
ChatId: "0.34",
MessageId: "message-id",
Type: protobuf.EmojiReaction_LOVE,
MessageType: protobuf.MessageType_ONE_TO_ONE,
Retracted: true,
},
},
{
Name: "missing chatID",
Valid: false,
WhisperTimestamp: 30,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.EmojiReaction{
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
Clock: 30,
MessageId: "message-id",
MessageType: protobuf.MessageType_ONE_TO_ONE,
Type: protobuf.EmojiReaction_LOVE,
},
},
{
Name: "missing messageID",
Valid: false,
WhisperTimestamp: 30,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.EmojiReaction{
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
Clock: 30,
ChatId: "chat-id",
MessageType: protobuf.MessageType_ONE_TO_ONE,
Type: protobuf.EmojiReaction_LOVE,
},
},
{
Name: "missing type",
Valid: false,
WhisperTimestamp: 30,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.EmojiReaction{
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
Clock: 30,
ChatId: "chat-id",
MessageId: "message-id",
MessageType: protobuf.MessageType_ONE_TO_ONE,
},
},
{
Name: "missing message type",
Valid: false,
WhisperTimestamp: 30,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.EmojiReaction{
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
Clock: 30,
ChatId: "chat-id",
MessageId: "message-id",
Type: protobuf.EmojiReaction_LOVE,
},
},
{
Name: "clock value too high",
Valid: false,
WhisperTimestamp: 30,
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
Message: &protobuf.EmojiReaction{
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
Clock: 900000,
ChatId: "chat-id",
MessageId: "message-id",
MessageType: protobuf.MessageType_ONE_TO_ONE,
Type: protobuf.EmojiReaction_LOVE,
},
},
}
for _, tc := range testCases {
s.Run(tc.Name, func() {
Always use protobufs by reference & generate handlers
2023-08-18 11:39:59 +00:00
err := ValidateReceivedEmojiReaction(tc.Message, tc.WhisperTimestamp)
Use local chat-id for matching messages
2020-07-28 07:53:32 +00:00
if tc.Valid {
s.Nil(err)
} else {
s.NotNil(err)
}
})
}
}