status-im
/
status-github-bot
mirror of https://github.com/status-im/status-github-bot.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

drop moving PRs to the TO REBASE column 

Signed-off-by: Jakub Sokołowski <jakub@status.im>
This commit is contained in:
Jakub Sokołowski 2023-05-19 16:54:22 +02:00
parent c4d66646fb
commit ff82b146ab
No known key found for this signature in database
GPG Key ID: FE65CD384D5BF7B4
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bot_scripts/assign-approved-pr-to-test.js
View File

@ -55,7 +55,6 @@ async function checkOpenPullRequests (robot, context) {
const testedPullRequestLabelName = projectBoardConfig['tested-pr-label-name'] const testedPullRequestLabelName = projectBoardConfig['tested-pr-label-name']
const contributorColumnName = projectBoardConfig['contributor-column-name'] const contributorColumnName = projectBoardConfig['contributor-column-name']
const toRebaseColumnName = projectBoardConfig['to-rebase-column-name']
const reviewColumnName = projectBoardConfig['review-column-name'] const reviewColumnName = projectBoardConfig['review-column-name']
const testColumnName = projectBoardConfig['test-column-name'] const testColumnName = projectBoardConfig['test-column-name']
const minReviewers = projectBoardConfig['min-reviewers'] || 1 const minReviewers = projectBoardConfig['min-reviewers'] || 1
@ -79,7 +78,6 @@ async function checkOpenPullRequests (robot, context) {
try { try {
const columns = { const columns = {
contributor: findColumnByName(ghcolumns, contributorColumnName), contributor: findColumnByName(ghcolumns, contributorColumnName),
rebase: findColumnByName(ghcolumns, toRebaseColumnName),
review: findColumnByName(ghcolumns, reviewColumnName), review: findColumnByName(ghcolumns, reviewColumnName),
test: findColumnByName(ghcolumns, testColumnName), test: findColumnByName(ghcolumns, testColumnName),
} }
@ -219,8 +217,6 @@ function getColumns (state, columns) {
return { srcColumns: [columns.contributor, columns.test], dstColumn: columns.review } return { srcColumns: [columns.contributor, columns.test], dstColumn: columns.review }
case 'changes_requested': case 'changes_requested':
return { srcColumns: [columns.review, columns.test], dstColumn: columns.contributor } return { srcColumns: [columns.review, columns.test], dstColumn: columns.contributor }
case 'needs_rebase':
return { srcColumns: [columns.contributor, columns.review, columns.test], dstColumn: columns.rebase }
case 'approved': case 'approved':
return { srcColumns: [columns.contributor, columns.review], dstColumn: columns.test } return { srcColumns: [columns.contributor, columns.review], dstColumn: columns.test }
default: default:

2
lib/github-helpers.js
View File

@ -57,8 +57,8 @@ async function _getReviewApprovalState (context, robot, prInfo, minReviewers, te
state = 'approved' state = 'approved'
break break
case 'dirty': case 'dirty':
/* Currently ignored. */
robot.log.debug(`PR #${prInfo.number} - pr.mergeable_state=${pr.mergeable_state}, pr.mergeable=${pr.mergeable}`) robot.log.debug(`PR #${prInfo.number} - pr.mergeable_state=${pr.mergeable_state}, pr.mergeable=${pr.mergeable}`)
state = 'needs_rebase'
break break
case 'unstable': case 'unstable':
if (filterIgnoredStatusContextFn) { if (filterIgnoredStatusContextFn) {