From 86c17d5426d71aec0fa726eac58c2d138468313f Mon Sep 17 00:00:00 2001 From: Pedro Pombeiro Date: Wed, 24 Jan 2018 11:41:15 +0100 Subject: [PATCH] Ignore COMMENT review state when computing whether to move a PR to IN TEST --- scripts/assign-approved-pr-to-test.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/assign-approved-pr-to-test.js b/scripts/assign-approved-pr-to-test.js index e8041d0..e74546f 100644 --- a/scripts/assign-approved-pr-to-test.js +++ b/scripts/assign-approved-pr-to-test.js @@ -40,7 +40,13 @@ async function getReviewApprovalState(github, robot, repo, pullRequest) { github.pullRequests.getReviews({owner: ownerName, repo: repoName, number: prNumber}), res => res.data) for (var review of ghreviews) { - finalReviewsMap.set(review.user.id, review.state) + switch (review.state) { + case 'APPROVED': + case 'CHANGES_REQUESTED': + case 'PENDING': + finalReviewsMap.set(review.user.id, review.state) + break + } } var finalReviews = Array.from(finalReviewsMap.values()) if (process.env.DRY_RUN_PR_TO_TEST) {