status-im
/
status-github-bot
mirror of https://github.com/status-im/status-github-bot.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove unused parameter

This commit is contained in:
Pedro Pombeiro 2018-01-24 14:37:48 +01:00
parent 6513d51dbb
commit 4c155ea864
No known key found for this signature in database
GPG Key ID: A65DEB11E4BBC647
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/assign-approved-pr-to-test.js
View File

@ -109,7 +109,7 @@ async function getProjectFromName(github, ownerName, repoName, projectBoardName)
return ghprojects.data.find(p => p.name === projectBoardName) return ghprojects.data.find(p => p.name === projectBoardName)
} }
async function getProjectCardForPullRequest(github, robot, columnId, pullRequestUrl) { async function getProjectCardForPullRequest(github, columnId, pullRequestUrl) {
const ghcards = await github.projects.getProjectCards({column_id: columnId}) const ghcards = await github.projects.getProjectCards({column_id: columnId})
ghcard = ghcards.data.find(c => c.content_url === pullRequestUrl) ghcard = ghcards.data.find(c => c.content_url === pullRequestUrl)
@ -207,7 +207,7 @@ async function assignPullRequestToCorrectColumn(github, robot, repo, pullRequest
// Look for PR card in source column // Look for PR card in source column
let ghcard = null let ghcard = null
try { try {
ghcard = await getProjectCardForPullRequest(github, robot, srcColumn.id, pullRequest.issue_url) ghcard = await getProjectCardForPullRequest(github, srcColumn.id, pullRequest.issue_url)
} catch (err) { } catch (err) {
robot.log.error(`Failed to retrieve project card for the PR, aborting: ${err}`, srcColumn.id, pullRequest.issue_url) robot.log.error(`Failed to retrieve project card for the PR, aborting: ${err}`, srcColumn.id, pullRequest.issue_url)
return return
@ -239,7 +239,7 @@ async function assignPullRequestToCorrectColumn(github, robot, repo, pullRequest
// Look for PR card in destination column // Look for PR card in destination column
try { try {
ghcard = await getProjectCardForPullRequest(github, robot, dstColumn.id, pullRequest.issue_url) ghcard = await getProjectCardForPullRequest(github, dstColumn.id, pullRequest.issue_url)
if (ghcard) { if (ghcard) {
robot.log.trace(`Found card in target column, ignoring`, ghcard.id, dstColumn.id) robot.log.trace(`Found card in target column, ignoring`, ghcard.id, dstColumn.id)
return return