mirror of
https://github.com/status-im/status-desktop.git
synced 2025-01-09 22:06:25 +00:00
Pascal Precht
18ea9dc2cd
fix: make reactions in 1-on-1 chats work
Turns out message reactions weren't functional in 1 on 1 chats. Reaction signals come with a `chatId` that they correspond to, which is then used to determine to channel and message list to apply/remove the reaction to. Inside of a 1 on 1 chat, the `chatId` of a reaction coming from the will always be the pubKey of the the user that receives it. A user however, usually doesn't store a chat item for her own pubKey unless it's of type `Profile`. This results in an illega storage access as reported in #1828 This commit fixes this bug by checking whether the reaction `chatId` matches the user's `pubKey`. If that's the case, we know that the reaction corresponds to the reaction's `fromAuthor` chat. Fixes #1828
Nim-status-client
Desktop client for the Status Network built with Nim and Qt
note: this documentation is wip
Getting started
Overview
Architecture & Development
Guides & Tutorials
Continuous Integration
API
Translations
License
Licensed under the Mozilla Public License Version 2.0
Description
Languages
QML
37.6%
JavaScript
30.4%
Nim
19%
Python
5.8%
C++
5.4%
Other
1.7%