Commit Graph

1688 Commits

Author SHA1 Message Date
Richard Ramos b3cda3e755 fix: download images 2022-05-12 15:07:29 -04:00
Richard Ramos ebce90368c feat: use ipfs rate limiter 2022-05-12 15:07:29 -04:00
Richard Ramos 3d9a2957de fix: chat key validation 2022-05-12 15:02:53 -04:00
Jonathan Rainville 7c0dbb554a fix(community): community would appear even if not activated
Fixes #5454
2022-05-12 14:19:01 -04:00
Jonathan Rainville ddbe4e236d fix(group-chat): fix changing group chat name 2022-05-12 14:13:13 -04:00
Jonathan Rainville c58a656a52 fix(group-chats): fix context menu and pinned messages popup 2022-05-12 14:13:13 -04:00
Jonathan Rainville 6828055087 fix(group-chats): fix adding new member to group chat 2022-05-12 14:13:13 -04:00
Jonathan Rainville 1fdef43d18 fix(group-chats): remove user from user list when they leave chat 2022-05-12 14:13:13 -04:00
Patryk Osmaczko a633d33ec5 fix(@desktop/messages): asssign user icon on contact update
fixes: #5463
2022-05-12 14:07:58 -04:00
Jonathan Rainville 24a662676e fix(user-list): 1-1 mentions not updating nickname + rearrange events
Fixes #5462
2022-05-12 14:04:16 -04:00
Jonathan Rainville 0358b6bf80 feat(community): make on request comm a check box and remove ensOnly
Fixes #5660
2022-05-12 13:31:48 -04:00
Jonathan Rainville 63c8e972c0 feat(CommunityColumn): add channels and categories admin banner
Fixes #5664
2022-05-12 13:11:45 -04:00
Noelia 4a782d3093 docs(general-cpp): Initial proposal / best general and cpp practices
Basic list of general and cpp specific rules and best practices for contributors.
2022-05-12 19:06:15 +02:00
Noelia 2154626a5b feat(Language&Currency): Add Date & Time Format
Added Date & Time selectors in `Language & Currency" screen.

Added new properties in `local_app_settings` to set the date and time format.

Created all the chain from view to service to update date and time format.

Added date and time format functions in `Utils`.

Updated `FetchMoreMessagesButton`, `ChatTimePanel`,  `AppSearch`, `TransactionBubbleView` and `TransactionDelegate` date and time text depending on the selected format.

Closes #5386
2022-05-12 18:42:06 +02:00
Patryk Osmaczko a5be90761b fix(@desktop/chat): fix chat member getter for community
fixes: #5582
2022-05-12 12:41:42 -04:00
Pascal Precht d70a23cb9a fix(CommunityService): ensure communitySettings aren't mistakenly
overwritten

When communities are edited, status-go sends a signal with the community
description, to ensure the network is updated to the latest changes.

However, that community description doesn't include `communitySettings`.
When we then compose the `CommunityDto` object from that signal, it will have
a default certain settings to `false` which might actually be `true`.

The result is that data in memory is incorrect.

To ensure we don't run into this issue, we check whether the attached
settings have an id, if they don't, we know the settings do not
originate from the signal data, meaning we can use the settings we
already have.
2022-05-12 12:20:23 -04:00
Anthony Laibe a0bebeb78b fix(@communities): Better error message when failing to import
community

fixes #5382
2022-05-12 13:29:15 +02:00
Anthony Laibe 50fef581a5 fix(@wallet): apply order to token list 2022-05-12 09:52:01 +02:00
Anthony Laibe 5e05a7613c fix(@settings): fix Gas selector for snt
fixes #5572
2022-04-21 14:05:31 +02:00
Anthony Laibe 538cd6ae06 feat(@wallet): prevent to duplicate token
fixes #5567
2022-04-21 11:51:37 +02:00
Anthony Laibe efd6412266 fix(@wallet): Token not displayed after upgrade
fixes #5563
2022-04-18 16:53:05 +02:00
Sale Djenic d94abcb31e fix(@desktop/onboarding): the profile image doesn't look good on the onboarding page
Fixes #5241
2022-04-14 12:10:53 +02:00
Sale Djenic 3cdc1358ba fix(@desktop/contacts): multiple contact related issues fixed
Fixes #5354 #5225 #5198
2022-04-13 16:40:34 -04:00
Anthony Laibe 6145b4b620 fix(@wallet): loading collectibles 2022-04-13 14:51:38 -04:00
Richard Ramos 717ca08d31 fix: don't save the node config twice when switching fleets 2022-04-13 14:51:07 -04:00
Pascal Precht afecbc1796 fix(main/controller): ensure mailserversService is initialized
Fixes #5353
2022-04-13 17:16:46 +02:00
Khushboo Mehta feaa91d062 feat(@desktop/wallet): Add derivation path to wallet account generation
fixes #5074
2022-04-13 11:17:53 +02:00
Pascal Precht 348516d5a5 chore: add safeguards when checking for community data in response
Also remove unnecessary signals
2022-04-13 10:22:55 +02:00
Anthony Laibe 3f71e1fe87 feat(@wallet): move visible token to status go 2022-04-13 10:12:58 +02:00
Anthony Laibe 159f90f48e re-disable wallet & browser by default
Fixes #5476
2022-04-12 17:48:06 -04:00
Sale Djenic 9c9d633065 fix(@desktop/activity-center): mentions and replies in the activity centre does not display community icon
Fixes #5302
2022-04-12 20:08:33 +02:00
Pascal Precht 8d4aa7dd56 feat: introduce communities settings and history archive support UI
control
2022-04-12 11:25:46 +02:00
Pascal Precht 1d934c7b26 feat: introduce advanced option to enable/disable community archive
protocol
2022-04-12 11:25:18 +02:00
Pascal Precht 1ee631c04e feat: introduce default torrent node config 2022-04-12 10:38:50 +02:00
Boris Melnik 431348314d fix(ContactRequests): Remove add myself to sent request model
Closes: #5460
2022-04-11 17:26:56 -04:00
Iuri Matias dbc16329c0 fix(@desktop/groups): group modal is missing context menu options 2022-04-11 13:19:19 -04:00
Jonathan Rainville 8763238369 fix(community): re-hook banning users
Fixes #5383
2022-04-11 11:55:33 -04:00
Pascal Precht 10f6d9e89b feat: reload community chats when history messages have been downloaded
This introduces the new signal types related to the community archive
protocol and makes Status Desktop listen to the download event which is
emitted by status-go every time history archives were downloaded.

If the downloaded archive covers data within the recent 7 days, it
causes Status Desktop to reload the corresponding chats.
2022-04-11 15:54:08 +02:00
Patryk Osmaczko 0038501eb2 fix(@desktop/appsearch): render mentions in app search module
fixes: #5423
2022-04-08 14:20:00 -04:00
Patryk Osmaczko 58d1319946 fix(@desktop): unify user avatar fallback color
issue: #5358
2022-04-08 14:04:21 -04:00
Patryk Osmaczko bf530a6cc4 fix(@desktop/onboarding): show identicon ring and colors for profiles
issue: #5358
2022-04-08 14:04:21 -04:00
Patryk Osmaczko f2898b6bf7 chore(@desktop): add utility to get color id for pubkey 2022-04-08 14:04:21 -04:00
Anthony Laibe bd8ad854fc fix(@wallet): link to tx hash 2022-04-08 10:02:51 -04:00
Jonathan Rainville 4b78c119c3 fix(members): fix error in logs when getting members for public chat 2022-04-07 10:51:02 -04:00
Jonathan Rainville 4e8e2e681f fix(chat): fix chat duplication
Fixes #5324

The problem was that signals sometimes came faster than the "normal" flow, so we added the chat without checking first for duplication
2022-04-07 10:51:02 -04:00
Richard Ramos f749f84886 Allow the usage of compressed chat keys when sending contact requests
Fixes #5359
2022-04-07 10:23:08 -04:00
Khushboo Mehta d2663d30a5 fix(@desktop/browser): Unable to sign message from simepledapp.eth 2022-04-07 10:28:16 +02:00
Anthony Laibe b1775357c3 fix(@wallet): estimate gas fail when not enough fund
fixes #5267
2022-04-06 13:40:57 +02:00
Anthony Laibe b84b56c3c0 refactor(@general): move all token related to status-go 2022-04-04 13:07:36 -04:00
Patryk Osmaczko 53c38624ef chore: add utility to compress pubkey 2022-04-04 12:55:31 -04:00
Boris Melnik 1f82a784d1 fix(change_pasword): Add error message to change password popup
Closes: #5190
2022-04-04 12:15:21 -04:00
Patryk Osmaczko ce36ee90ca chore(@desktop): rename ambiguous fields `identicon`->`icon` 2022-04-04 17:50:48 +02:00
Patryk Osmaczko 08caca2a60 fix(@desktop): use identicon ring/letter instead of identicon
fixes: #5149
2022-04-04 17:50:48 +02:00
Patryk Osmaczko 25c6a5f5ca chore(@desktop): remove identicon related code 2022-04-04 17:50:48 +02:00
Richard Ramos c03f0b9d4c fix: pubkey shown when importing a seedphrase 2022-04-04 11:13:52 -04:00
Richard Ramos 206c692845 fix: use correct pubkey during account generation 2022-04-04 11:13:52 -04:00
Anthony Laibe 87da64d70d fix(@browser): move post message async 2022-04-04 12:58:34 +02:00
Richard Ramos b1e5ecc115 feat: discV5 2022-04-01 17:43:09 -04:00
Jonathan Rainville 666c865112 feat(chat): implement new getChats API for the backend
Fixes #4878 but new issues will be created to split the implementation
2022-04-01 15:53:49 -04:00
Sale Djenic 57fb0882aa fix(@desktop/chat): contact lists should only shown mutual contacts
Fixes #5117
2022-04-01 14:00:21 +02:00
Sale Djenic 149ff69310 fix(@desktop/contacts): contacts updated to match more closely to requested design 2022-04-01 14:00:21 +02:00
Jonathan Rainville 2d44d53bec fix(users): user not added when joining group + only show joined users
Fixes #5202
2022-03-31 17:31:02 -04:00
Boris Melnik dd9653bdec fix(ActivityCenter): Hide pinned messages
Closes: #5205
2022-03-31 16:00:49 -04:00
Jonathan Rainville e1b9332ab3 refactor(user-list): implement getMembers to populate user list
Fixes #5122
2022-03-31 14:01:47 -04:00
Sale Djenic e83e5670a4 feat(@desktop/contacts): support sending contact request to chat key
Fixes #5175
2022-03-30 18:35:49 +02:00
Anthony Laibe b4606d0363 fix(@desktop): network serialization 2022-03-30 15:12:48 +01:00
Anthony Laibe 08131e1d2d feat(@wallet): move suggested fees to status-go 2022-03-30 09:41:10 +01:00
Khushboo Mehta 4b9b93a873 fix(@desktop/chat): Downlaoding/Copying an image from chat crashes the app
The issue was caused because the data being passed to the UI is now a URL and not image data.

Added support to download/copy image by URL

fixes #5194
2022-03-30 10:06:52 +02:00
Richard Ramos ff12bec631 feat: switch fleet 2022-03-29 22:02:00 -04:00
Anthony Laibe b732ad6e5c fix(@browser): deleted account with permission
fixes #5154
2022-03-29 17:13:30 -04:00
Boris Melnik 2a27aa17a7 feat(nodes): Add toggle to WakuNodesModal
Closes: #5000
2022-03-29 16:59:02 -04:00
Jonathan Rainville d35344834e fix(onboarding): show warning when trying to re-encrypt existing account
Fixes #5029
2022-03-29 16:48:09 -04:00
Anthony Laibe 4b22a709ba feat(@wallet): link test/prod networks 2022-03-29 13:49:30 +01:00
Anthony Laibe 696e8aba29 fix(@browser): shared assets/history view
fixes #5129
2022-03-29 12:48:04 +01:00
Alexandra Betouni dcab50fe09 feat(onboarding): ading create new keys screens
Closes #4956
2022-03-29 00:47:24 +03:00
Michal Iskierko 38031aba83 feature(desktop/general): Configurable logs
Log level can be chosen during application startup.
Logs are disabled for production build.

Fix #3609
2022-03-28 13:58:08 -04:00
Stefan D 022193fe8f fix(node): enable bandwith reporting in node view
Add entry to services.nim in oder to upgrade existing user config
that are missing this value

fixes #4990
2022-03-28 13:23:55 -04:00
Anthony Laibe f29e825af4 fix(@chat): handle status being nil in stickers
fixes #5195

The attribute Status is marked as omit empty in backend
2022-03-28 12:59:37 -04:00
Sale Djenic da22517138 fix(@desktop/search): search popup UI breaks when clearing the input field
Fixes #5138
2022-03-28 12:25:56 -04:00
Anthony Laibe 33216d5bb5 chores: move to backend part1 2022-03-28 12:11:34 -04:00
Anthony Laibe 6ebd8cb1cc chores(@backend): Add macros for api 2022-03-28 12:11:34 -04:00
Jonathan Rainville 942066f8b4 feat(updates): implement new download update page
Fixes #4231
2022-03-25 10:32:31 -04:00
Anthony Laibe 1e6a640c33 refactor(@wallet): simplify saved address 2022-03-25 14:31:34 +00:00
Anthony Laibe acb38a4c4c fix(@wallet): cache price to avoid multiple call
fixes #5144
2022-03-25 14:30:57 +00:00
Khushboo Mehta 33e3d2377e fix(@desktop/wallet): User stays on removed account view in wallet after account removal from settings
fixes #5037
2022-03-25 08:30:52 -04:00
Michal Iskierko fd04833610 fix(desktop/chat): Notifies when the user is mentioned in edited message
Introduce new signal in message service: SIGNAL_MENTIONED_IN_EDITED_MESSAGE.
Keeping mentioned users public keys in message item/model.
When message is edited, message module sends request to message service to
check if the current user is mentioned and emit SIGNAL_MENTIONED_IN_EDITED_MESSAGE.

Fixes #4475
2022-03-25 09:23:17 +01:00
Michal Iskierko 3711ab613a feature(desktop/internal): Improve log file naming convention
Logs are named app_yyyyMMdd_HHmmss.log
Version, commit and start date information are displayed in logs at the begining.
Injecting commit version from Makefile.
Moving DESKTOP_VERSION const to constants.nim

Fix #3611
2022-03-24 17:47:48 -04:00
Jonathan Rainville 16f61db2f7 fix(group-chat): fix function call to join public chat
Fixes #5041
2022-03-24 17:05:32 -04:00
Richard Ramos d7fb0af91d refactor: remove active mailserver disconnection 2022-03-24 16:46:46 -04:00
Richard Ramos 2fa620ad92 fix: remove EnableMailserverCycle 2022-03-24 16:46:46 -04:00
Richard Ramos c6b76f063d refactor: remove history request 2022-03-24 16:46:46 -04:00
Noelia 8f996992b2 feat(onboarding / privacy): Integrate password validation (zxcvbn lib) in new password screens
Use new `PrivacyStore` method getPasswordStrengthScore and link it to the new password strength bar value.

Used backend/general to call to `status-go` method and services/general to define the common `GetPasswordStrengthScore` service.

Added onboarding chain to get password strength score information from `OnboardingStore` to `status-go` call.

Closes #5096
2022-03-24 18:17:04 +01:00
Anthony Laibe 4b91888433 feat(@wallet): move fetch prices
also make only one call rather than one call per couple token/currency
2022-03-23 08:54:37 +00:00
Sale Djenic c5c92fcfd1 refactor(@desktop/general): remove interfaces for controllers, make a single module interface
Fixes #5093
2022-03-23 09:00:57 +01:00
Sale Djenic 1bf5882f25 refactor(@desktop/general): remove interfaces for services
Fixes #5093
2022-03-23 09:00:57 +01:00
Richard Ramos 8063fbe734 fix: missing changes on contacts for display name 2022-03-21 15:43:42 -04:00
Patryk Osmaczko 9e0b8c5e90 chore: make (emoji/color)Hash direct status_go call 2022-03-18 21:12:39 +01:00
Anthony Laibe 4b48bc69bd fix(@browser): unlink wallet account and browser account
fixes #5034
2022-03-18 15:17:04 -04:00
Noelia 317ac06e43 feat(privacy): Added password strength calls
Added all necessary methods to call to a new `status-go` endpoint that allows to get the password strength quality info.

Closes #4980
2022-03-18 13:43:01 +01:00
Stefan Dunca 5a4dde1d5c feat(chat): members availability and settings change
Don't show members in public chat
Show members in communities by default
Enable Gif Widget by default and remove settings entry
Enable Online users by default and remove settings entry

fixes #4906
2022-03-17 15:48:42 -04:00
Patryk Osmaczko e244260c81 fix(@desktop): make get(Emoji/Color)Hash global utility
Removed instances of VisualIdentityService as it was stateless.
Removed (emoji/color)Hash models as they were reduntant, hashes are
obtained only from global utility now.
2022-03-17 15:32:25 +01:00
Richard Ramos 45deb4072e fix: set display name in accountsDB 2022-03-16 15:29:19 -04:00
Boris Melnik d4c4fe1f41 fix(Communities): Fix community duplications in model
Closes: #5002
2022-03-16 15:22:46 -04:00
Patryk Osmaczko e130953634 feat(@desktop): use emoji hash and identicon ring
Closes: #4782
2022-03-16 18:34:57 +01:00
Khushboo Mehta ade6a22fda fix(@desktop/wallet): Disconnect button doesnt disconnect Wallet from Browser
fixes #4053
2022-03-16 12:36:58 +01:00
Anthony Laibe 6e453dbbba fix(@browser): Fix etherscan link
fixes #4786
fixes #5014

also fixed simpledapp.eth due to need to resolve previous issue
2022-03-16 11:10:42 +01:00
Jonathan Rainville a910a3e801 fix(chat): only add active chats (fixes chats reappearing after leaving)
Fixes #4903
2022-03-15 12:43:14 -04:00
Jonathan Rainville 13b81134de fix(community): join community when request is accepted
Fixes #4991
2022-03-15 09:29:56 -04:00
Richard Ramos b07910e27f feat: display name 2022-03-14 15:17:04 -04:00
Anthony Laibe d1d56c9ea8 fix(@wallet): pre-populate token details
fixes #5024
2022-03-14 14:35:58 +01:00
Anthony Laibe 0908b13ad5 feat(@settings): new dapp permissions view 2022-03-14 13:48:57 +01:00
Khushboo Mehta 6e0471c943 bash: py: command not found
feat(@desktop/wallet): Add emoji to Wallet accounts.
Support added to:
1. Wallet list
2. Adding a new account
3. Editing an account

fixes #4926
2022-03-13 08:54:28 -04:00
Jonathan Rainville aef8d0c4ab feat(community): enable choosing and changing community channel color
Fixes #4953
2022-03-11 16:01:22 -05:00
Richard Ramos 8183d4e317 chore: add status.prod fleet 2022-03-11 15:52:47 -05:00
Alexandra Betouni 8cab96fd24 feat(desktop/chat): Updated create new chat/group flow
As per new designs

Closes #4781
2022-03-11 14:31:51 -05:00
Boris Melnik 35bd8fb4ea fix(Contacts): Exclude myself from contacts
Closes: #5018
2022-03-11 14:05:31 -05:00
Jonathan Rainville f0d9eb9b04 fix(community): fix deleting community chat more reliable
Fixes #4913

The problem was that we relied only on the status-go signals, so there was a delay, and also they are not as reliable as deleting them ourselves from the array and calling the event
2022-03-11 09:52:39 -05:00
Sale Djenic 9821e160c1 fix(@dekstop/chat): editing a message does not update the reply
Fixes #4891
2022-03-11 14:44:44 +01:00
Sale Djenic 4ff700681f fix(@dekstop/chat): mentioning oneself display the full key instead of username
Fixes #4897
2022-03-11 13:14:14 +01:00
Anthony Laibe 9f7a90d486 fix(@wallet): Correctly load token at boot
The settings needs to be loaded before the token as they depends of it
2022-03-10 16:53:08 -05:00
Sale Djenic b9cc6c7d8e fix(@dekstop/chat): clicking on a mention or reply in the activity centre notifications list, does not take the user to the correct Community chat window
Fixes #4966
2022-03-10 16:51:24 -05:00
Richard Ramos 3c7779305b feat: move stickers business logic to status-go 2022-03-09 12:16:42 -04:00
Anthony Laibe 49ca009a7c feat(@settings): Display account information 2022-03-09 13:48:34 +01:00
Jonathan Rainville 68a4498d11 feat(privacy): reimplement show only contact pfp using status-go setting
Fixes #4900
2022-03-08 15:50:15 -05:00
Jonathan Rainville be9d2f94e2 feat: enable emojis as channel icons
Fixes #4809
2022-03-08 15:15:25 -05:00
Alexandra Betouni c2977e468f feat(onboarding): Added SplashScreen
- Added SplashScreen as initial screen before
onboard as per new designs.
- Also moved all onboarding related code from
main to onboarding section and switched to
import this and all other sections as
qml modules, exposing this way only
necessary files.
- Cleaned up unecessary qmldir files and
imports.

Closes #4954
2022-03-08 14:02:24 -05:00
Khushboo Mehta cc55f811b1 fix(@desktop/wallet): Re-add saved addresses view from Wallet V2
fixes #4747
2022-03-03 15:47:42 +01:00
Anthony Laibe 02bc62a9a2 feat(@settings): plug in accounts 2022-03-03 10:43:55 +01:00
Khushboo Mehta 44a8b6df0a fix(@desktop/wallet): add/re-add buy crypto feature
fixes #4925
2022-03-02 18:45:22 +01:00
Jonathan Rainville 6fa74b7ba9 refactor: re-hook disconnected and re-connected signals and banner 2022-03-02 09:27:45 -05:00
Anthony Laibe bfda545646 refactor: add back eip1559 2022-03-01 15:10:23 -05:00
Jonathan Rainville d2d57036b5 fix(notifications): fix windows tray icon and notifications
Fixes #4263
2022-03-01 10:01:22 -05:00
Jonathan Rainville d42a34ff3a fix(user-list): fix adding users to user list on new messages
Fixes #4898
2022-03-01 09:44:20 -05:00
Sale Djenic 40d10b0cbb fix(@dekstop/chat): timestamp for `Fetch messages` is wrong
Fixes #4850
2022-02-25 12:11:26 -05:00
Khushboo Mehta ec9a359a28 fix(@desktop/wallet): Sign transaction accepts incorrect password
Async methods for send transaction is not impolemented yet and this is a fix until the proper flow is implemented.
Also resolves the same issue observed in chat section.

fixes #4821
2022-02-25 11:58:15 -05:00
Khushboo-dev-cpp dcac7977d9 fix(@desktop/settings): Store pass to keychain does not validate current password which results to inability to login
fixes #4358
2022-02-25 11:56:47 -05:00
Sale Djenic 343ce69e29 fix(@dekstop/chat): members panel on the Community invite sender's app is only updated after the app is rebooted
Fixes #4870
2022-02-24 17:16:17 -05:00
Jonathan Rainville a51aee1683 fix(community): re-hook kick user from community
Fixes #2274
2022-02-24 17:04:56 -05:00
Jonathan Rainville 6c5594b576 fix(community): fix community edits not always working
Fixes #4842
2022-02-24 16:54:05 -05:00
Jonathan Rainville bd69d88163 feat(communities): add category signal handling (add, delete and edit)
Fixes #4753
2022-02-24 16:54:05 -05:00
Jonathan Rainville f7860310db fix(community-chats): fix community chats getting duplicated
Fixes #4859 and #4858
2022-02-24 16:54:05 -05:00
Jonathan Rainville 3985272037 fix(invitation): fix community invite not showing in 1-1 chats
Fixes #4851
2022-02-24 10:58:26 -05:00
Sale Djenic 52fb195b39 fix(@dekstop/chat): trying to unblock a contact by hitting 'Unblock' via the chat view does not do anything
Fixes #4835
2022-02-24 16:19:51 +01:00
Sale Djenic 0078961a67 fix(@dekstop/chat): dogfooding_3 crash
Fixes #4827
2022-02-24 15:46:36 +01:00
Sale Djenic 91e42aba6d fix(@dekstop/chat): creating a chat with numeric only crashes the app
Fixes #4860
2022-02-23 15:53:38 -05:00
Richard Ramos d4f8b63292 feat: add status.test fleet 2022-02-23 15:48:06 -05:00
Sale Djenic c855de98b6 fix(@dekstop/chat): higher cpu usage after opening gif selector
Fixes #4829
2022-02-23 15:43:21 -05:00
Sale Djenic 6f3ce63f51 fix(@dekstop/chat): wrong redirect when opening a profile -> send message inside of community
Fixes #4837
2022-02-23 15:38:55 -05:00
Jonathan Rainville 58935b82d7 fix(search): fix profile popup opened on search title clicked
Fixes #4795

Makes sure to only open the profile popup if the click is a pubkey.
Also opens the popup on ctrl+f
2022-02-23 15:17:51 -05:00
Richard Ramos 8c95e65ebf fix: code review 2022-02-21 17:30:50 -04:00