This commit brings a separation of concerns for the UI components involved in dApp interactions.
Issue: The UI components depend on the WalletConnectService and also on its dependencies like DAppsRequestHAndler. As a result the UI components have a hard dependency on the WalletConnect specifics and are incompatible with BC. This results in duplication of logic.
Issue: The UI components operate on WalletConnect specific JSON object. E.g. session objects, session proposal etc. As a result the UI is built around the WalletConnect message format.
Issue: The UI components operate on ListModel items received through functions and stored internally. Any change in the model would result in a crash.
Solution: Remove the WalletConnectService dependency from DAppsWorkflow. The DAppsWorkflow now operates with models, signals and functions. This is the first step in the broader refactoring. Moving the logic into the service itself will allow us to further refactor the WC and BC.
How does it work now:
Dependencies - The UI components have a dependency on models. SessionRequestsModel and DAppsModel.
Pairing - The pairing is initiated in the UI. On user input a pairingValidationRequested signal is emitted and the result is received as a function pairingValidated. If the url is valid the UI requests a pairingRequested. When the WalletConnectService is refactored we can go further and request only pairingRequested and to receive a pairingResult call as a function with the result. In the current implementation on pairingRequested we'll receive a connectDApp request.
Connecting dApps - The flow is initiated with connectDApp function. This call currently contains all the needed info as args. In the next step it could be replaced with a ConnectionRequests model. The connectDApp call triggered a connection popup if we're not currently showing one to the user. If we're currently showing one it will be queued (corner case). The connection can be accepted with connectionAccepted and rejected with connectionDeclined. Once the connection is accepted we're expecting a result connectionSuccessful or connectionFailed. The connectionSuccessful also expects a new id for the established connection.
Signing - The signing flow orbits around the SessionRequestsModel. Each item from the model will generate a popup showing the sign details to the user. Sign can be accepted or rejected using signRequestAccepted or signRequestRejected. No response is currently expected. The model is expected to remove the sign request item.
Initial separation of backend-independ and stateless content
from backend-dependent method/properties which are a subject
of further refactors.
Closes: #16481
- hide the permission from the `PermissionsRow` when it's set to private
and the conditions are not met
- display a tooltip "(Not) eligible to join" over the lock icon
- show the same info in both community portal and profile dialog's
community showcase tab
- speedup searching/filtering in the community portal
- fixup and extend the SB pages to demonstrate the new behavior
Fixes#14747
- restore previous context menu item spacing (ColumnLayout has an
implicit spacing of 5)
- don't wrap the MessageReactionsRow into an extra Item container; fixes
the emoji reactions row being garbled
- enhance the SB page so that the above can be seen/tested there and
rename it to match the component name
- some smaller cleanups
Fixes#16409
Fixes#15750
When the pairing fails, the UI now let's the user use the seed phrase instead.
When they do, a call is send to the original device and both instances will show an AC notif.
When the original device accepts the pairing, the call is made to pair and sync the devices and the AC notifs get deleted
Based on changes done in this PR https://github.com/status-im/status-go/pull/5807
we can simplify our client logic a lot.
This results in the removal of many lines of code that are no longer needed
Closes 1st part of #16336
Iterates #16043
* fix(admin): improve admin panel loading by putting sections in loaders
* fix(admin): speed up members tab by using nim model and real search
* fix(admin): speed up airdrop panel
* fix(admin): mint panel and airdrop panel interactions and previous btn
* fix(admin): speed up overview page
* fix(admin): speed up permissions page
refactor: make MessageContextMenu a functional component
refactor: make MessageContextMenu a functional component
remove root store
simplify signals in message context menu
abstract copyToClipboard as a signal
simplify code
fix menu not closing on emoji reaction
feature: add remove from group option to group chats
refactor ProfileContextMenu to make it a functional component
refactor ProfileContextMenu to make it a functional component
This refactor ProfileContextMenu to make it a functional component by:
refactored out direct calls to backend, and passing backend data structures and moved this logic to the callers, also refactored common calls between the callers
common types of context menus have been extracted to their sub components which removes a lot of logic too and makes the behaviour very clear
user verification workflow (which was already disabled) has been removed
refactor: use signals and call singletons on the parent instead
remove unused code for now from profile context menu
refactor profile context menu into two components; add property to storybook
extract blocked profile context menu and self profile context menu
use profileType instead of individual bools
refactor to pass trustStatus as an argument
make contact type a parameter
remove unnecessary method from RegularProfileContextMenu
add ensVerified property to ProfileContextMenu components
add onlineStatus property to ProfileContextMenu components
move ProfileContextMenu storybook controls to the right sidebar
move contactDetails logic up from the view
add local nickname property to ProfileContextMenu components
fix issue with missing signal; fix logs in storybook
use constant for profileType instead of string
refactor common code into a single method
refactor getProfileContext
remove references to contactDetails which are not longer needed
remove unnecessary comments
fix bridged constant
refactor into a single ProfileContextMenu component
refactor into a single ProfileContextMenu component
refactor into a single ProfileContextMenu component
simplify imports
remove unused store field
move methods from utils to contacts store
remove onClosed signal
remove unused param
feature: add remove from group option to group chats
feature: add remove from group option to group chats
add isAdmin property
move removeMemberFromGroupChat to root store
hide remove from group option from message context menu
refactor ProfileContextMenu to make it a functional component
refactor ProfileContextMenu to make it a functional component
refactor ProfileContextMenu to make it a functional component
This refactor ProfileContextMenu to make it a functional component by:
refactored out direct calls to backend, and passing backend data structures and moved this logic to the callers, also refactored common calls between the callers
common types of context menus have been extracted to their sub components which removes a lot of logic too and makes the behaviour very clear
user verification workflow (which was already disabled) has been removed
refactor: use signals and call singletons on the parent instead
remove unused code for now from profile context menu
refactor profile context menu into two components; add property to storybook
extract blocked profile context menu and self profile context menu
use profileType instead of individual bools
refactor to pass trustStatus as an argument
make contact type a parameter
remove unnecessary method from RegularProfileContextMenu
add ensVerified property to ProfileContextMenu components
add onlineStatus property to ProfileContextMenu components
move ProfileContextMenu storybook controls to the right sidebar
move contactDetails logic up from the view
add local nickname property to ProfileContextMenu components
fix issue with missing signal; fix logs in storybook
use constant for profileType instead of string
refactor common code into a single method
refactor getProfileContext
remove references to contactDetails which are not longer needed
remove unnecessary comments
fix bridged constant
refactor into a single ProfileContextMenu component
refactor into a single ProfileContextMenu component
refactor into a single ProfileContextMenu component
simplify imports
remove unused store field
move methods from utils to contacts store
remove onClosed signal
remove unused param
rename ProfileContextMenu variables
simplify signals in ProfileContextMenu
remove ;
refactor: do early return
simplify ifs
move ProfileContextMenu to its own storybook page
fix wrong params
fix profile context menu separator
add missing signals to profile context menu on the members tab panel
- StatusSuccessAction, despite its name, is a visual item (`MenuItem` ->
`AbstractButton`) which is not part of the `contentModel` but just added
to the menu container
- therefore we don't use a ListView but a ScrollView/Repeater instead
and set the width/maxWidth manually after the menu items have been added
to the layout
Fixes#14037
- clear search on close (AssetSelectorCompact)
- sectionProperty removed
- highlighting fixed in TokenSelectorPanel
- setCustom renamed to setSelection
- test data moved into Component object
- show countdown until which the sign (WalletConnect and Swap) dialogs
expire
- after expiration, hide the Reject/Sign buttons and display a plain
Close button
- make the dialogs non-closable by clicking outside or pressing Esc; the
user has to explicitely click some of the footer buttons
Fixes#16327Fixes#16314
- shows the remaining time until expiration with the circular progress
bar and a tooltip
- configurable timestamp and timeout in seconds (between 5 min and 7
days)
- add the respective storybook page
* refactor(community_tokens): only fetch holders when going to the page
Fixes#16307
Instead of fetching community token holders each time members change, we fetch when the page for the token is opened.
It shows a small loading text then the resulting holders.
If the list is already available (fetched previously, we show it directly).
There is still the timer to refresh the list if you stay on the page.
* add loading property to storybook
- simpler, standard property based API
- much lighter than deriving from the heavy StatusListItem
- should reduce RAM usage significantly, esp. with large communities
Iterates #11059
Sale Djenic
Alex Jbanca
Michał Cieślak
Lukáš Tinkl
Jonathan Rainville
Cuteivist
Iuri Matias
Khushboo Mehta
Dario Gabriel Lipicar
Anastasiya Semenkevich