From fdefaf5a545c29384bb6dc3162abe62d77de1679 Mon Sep 17 00:00:00 2001 From: Anastasiya Semenkevich Date: Fri, 6 Sep 2024 13:54:08 +0300 Subject: [PATCH] chore: do not expose seed phrase in allure reports in params fixture --- .../transactions_tests/test_buy_ens_name_in_settings.py | 9 +++++---- .../test_mint_owner_and_tokenmaster_tokens.py | 8 ++++---- .../e2e/tests/transactions_tests/test_wallet_send_eth.py | 8 ++++---- .../e2e/tests/transactions_tests/test_wallet_send_nft.py | 9 +++++---- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/test/e2e/tests/transactions_tests/test_buy_ens_name_in_settings.py b/test/e2e/tests/transactions_tests/test_buy_ens_name_in_settings.py index f8501f963e..9e0e60e309 100644 --- a/test/e2e/tests/transactions_tests/test_buy_ens_name_in_settings.py +++ b/test/e2e/tests/transactions_tests/test_buy_ens_name_in_settings.py @@ -33,12 +33,13 @@ def keys_screen(main_window) -> KeysView: 'Settings -> ENS usernames: buy ENS name on testnet') @pytest.mark.case(704597) @pytest.mark.transaction -@pytest.mark.parametrize('user_account', [ReturningUser( - seed_phrase=WALLET_SEED.split(), - status_address='0x44ddd47a0c7681a5b0fa080a56cbb7701db4bb43' -)]) @pytest.mark.parametrize('ens_name', [pytest.param(random_ens_string())]) def test_ens_name_purchase(keys_screen, main_window, user_account, ens_name): + + user_account = ReturningUser( + seed_phrase=WALLET_SEED.split(), + status_address='0x44ddd47a0c7681a5b0fa080a56cbb7701db4bb43') + with step('Open import seed phrase view and enter seed phrase'): input_view = keys_screen.open_import_seed_phrase_view().open_seed_phrase_input_view() diff --git a/test/e2e/tests/transactions_tests/test_mint_owner_and_tokenmaster_tokens.py b/test/e2e/tests/transactions_tests/test_mint_owner_and_tokenmaster_tokens.py index 0dcf367242..afe558df98 100644 --- a/test/e2e/tests/transactions_tests/test_mint_owner_and_tokenmaster_tokens.py +++ b/test/e2e/tests/transactions_tests/test_mint_owner_and_tokenmaster_tokens.py @@ -30,13 +30,13 @@ def keys_screen(main_window) -> KeysView: @allure.testcase('https://ethstatus.testrail.net/index.php?/cases/view/727245', 'Mint owner token') @pytest.mark.case(727245) -@pytest.mark.parametrize('user_account', [ReturningUser( - seed_phrase=WALLET_SEED.split(), - status_address='0x44ddd47a0c7681a5b0fa080a56cbb7701db4bb43' -)]) @pytest.mark.transaction @pytest.mark.skip('temp skip test to fix it using L2 networks') def test_mint_owner_and_tokenmaster_tokens(keys_screen, main_window, user_account): + user_account = ReturningUser( + seed_phrase=WALLET_SEED.split(), + status_address='0x44ddd47a0c7681a5b0fa080a56cbb7701db4bb43') + with step('Open import seed phrase view and enter seed phrase'): input_view = keys_screen.open_import_seed_phrase_view().open_seed_phrase_input_view() input_view.input_seed_phrase(user_account.seed_phrase, True) diff --git a/test/e2e/tests/transactions_tests/test_wallet_send_eth.py b/test/e2e/tests/transactions_tests/test_wallet_send_eth.py index f3079e2c03..c80ea1793b 100644 --- a/test/e2e/tests/transactions_tests/test_wallet_send_eth.py +++ b/test/e2e/tests/transactions_tests/test_wallet_send_eth.py @@ -27,15 +27,15 @@ def keys_screen(main_window) -> KeysView: 'Send: can send 0 ETH to address pasted into receiver field with Simple flow') @pytest.mark.case(704527) @pytest.mark.transaction -@pytest.mark.parametrize('user_account', [ReturningUser( - seed_phrase=WALLET_SEED.split(), - status_address='0x44ddd47a0c7681a5b0fa080a56cbb7701db4bb43' -)]) @pytest.mark.parametrize('receiver_account_address, amount, asset', [ pytest.param(WalletAddress.RECEIVER_ADDRESS.value, 0, 'ETH') ]) @pytest.mark.timeout(timeout=120) def test_wallet_send_0_eth(keys_screen, main_window, user_account, receiver_account_address, amount, asset): + user_account = ReturningUser( + seed_phrase=WALLET_SEED.split(), + status_address='0x44ddd47a0c7681a5b0fa080a56cbb7701db4bb43') + with step('Open import seed phrase view and enter seed phrase'): input_view = keys_screen.open_import_seed_phrase_view().open_seed_phrase_input_view() input_view.input_seed_phrase(user_account.seed_phrase, True) diff --git a/test/e2e/tests/transactions_tests/test_wallet_send_nft.py b/test/e2e/tests/transactions_tests/test_wallet_send_nft.py index e6d4d84947..e58c512e1e 100644 --- a/test/e2e/tests/transactions_tests/test_wallet_send_nft.py +++ b/test/e2e/tests/transactions_tests/test_wallet_send_nft.py @@ -28,10 +28,6 @@ def keys_screen(main_window) -> KeysView: 'Send: can send ERC 721 token (collectible) to address pasted into receiver field with Simple flow') @pytest.mark.case(704602) @pytest.mark.transaction -@pytest.mark.parametrize('user_account', [[ReturningUser( - seed_phrase=WALLET_SEED.split(), - status_address='0x44ddd47a0c7681a5b0fa080a56cbb7701db4bb43' -)]]) @pytest.mark.parametrize('tab, receiver_account_address, amount, collectible', [ pytest.param('Collectibles', '0x44ddd47a0c7681a5b0fa080a56cbb7701db4bb43', 1, 'Panda') ]) @@ -40,6 +36,11 @@ def keys_screen(main_window) -> KeysView: @pytest.mark.skip(reason="https://github.com/status-im/status-desktop/issues/14509") def test_wallet_send_nft(keys_screen, main_window, user_account, tab, receiver_account_address, amount, collectible): with step('Open import seed phrase view and enter seed phrase'): + + user_account = ReturningUser( + seed_phrase=WALLET_SEED.split(), + status_address='0x44ddd47a0c7681a5b0fa080a56cbb7701db4bb43') + input_view = keys_screen.open_import_seed_phrase_view().open_seed_phrase_input_view() input_view.input_seed_phrase(user_account.seed_phrase, True) profile_view = input_view.import_seed_phrase()