status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(statusApp): resolving qml errors/warnings pt2 

Closes #8864
This commit is contained in:
Alexandra Betouni 2023-01-24 19:31:20 +02:00 committed by Alexandra Betouni
parent dfcba80df2
commit f7294c00f5
7 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ui/app/AppLayouts/Browser/BrowserLayout.qml
View File

@ -228,10 +228,10 @@ StatusSectionLayout {
dappBrowserAccIcon: WalletStore.dappBrowserAccount.color
settingMenu: settingsMenu
walletMenu: browserWalletMenu
currentUrl: _internal.currentWebView.url
isLoading: _internal.currentWebView.loading
canGoBack: _internal.currentWebView.canGoBack
canGoForward: _internal.currentWebView.canGoForward
currentUrl: !!_internal.currentWebView ? _internal.currentWebView.url : ""
isLoading: (!!_internal.currentWebView && _internal.currentWebView.loading)
canGoBack: (!!_internal.currentWebView && _internal.currentWebView.canGoBack)
canGoForward: (!!_internal.currentWebView && _internal.currentWebView.canGoForward)
currentTabConnected: RootStore.currentTabConnected
onOpenHistoryPopup: historyMenu.popup(xPos, yPos)
onGoBack: _internal.currentWebView.goBack()
@ -274,7 +274,7 @@ StatusSectionLayout {
anchors.left: parent.left
anchors.right: parent.right
z: 50
tabComponent: webEngineView
tabComponent: !!webEngineView ? webEngineView : null
currentWebEngineProfile: _internal.currentWebView.profile
determineRealURL: function(url) {
return _internal.determineRealURL(url)

3
ui/app/AppLayouts/Chat/controls/community/CommunityLogoPicker.qml
View File

@ -29,7 +29,8 @@ Item {
ColumnLayout {
id: layout
anchors.fill: parent
implicitWidth: childrenRect.width
implicitHeight: childrenRect.height
spacing: 8

3
ui/app/AppLayouts/Onboarding/views/LoginView.qml
View File

@ -285,7 +285,8 @@ Item {
filters: [
ExpressionFilter {
expression: {
if (!root.startupStore.selectedLoginAccount.keycardCreatedAccount &&
if (!!root.startupStore.selectedLoginAccount &&
!root.startupStore.selectedLoginAccount.keycardCreatedAccount &&
model.username === d.lostKeycardItemKey) {
return false
}

4
ui/app/AppLayouts/Profile/ProfileLayout.qml
View File

@ -78,7 +78,7 @@ StatusSectionLayout {
currentIndex: Global.settingsSubsection
onCurrentIndexChanged: {
if (!children[currentIndex].active)
if (!!children[currentIndex] && !children[currentIndex].active)
children[currentIndex].active = true
root.store.backButtonName = ""
@ -285,6 +285,8 @@ StatusSectionLayout {
Loader {
active: false
asynchronous: true
Layout.fillWidth: true
Layout.fillHeight: true
sourceComponent: CommunitiesView {
implicitWidth: parent.width
implicitHeight: parent.height

2
ui/app/AppLayouts/Profile/views/AppearanceView.qml
View File

@ -39,7 +39,7 @@ SettingsContentBase {
Item {
id: appearanceContainer
anchors.left: parent.left
anchors.left: !!parent ? parent.left : undefined
anchors.leftMargin: Style.current.padding
width: appearanceView.contentWidth - 2 * Style.current.padding
height: childrenRect.height

2
ui/app/AppLayouts/Profile/views/CommunitiesView.qml
View File

@ -37,8 +37,8 @@ SettingsContentBase {
Item {
id: rootItem
height: childrenRect.height
width: root.contentWidth
height: childrenRect.height
ColumnLayout {
id: noCommunitiesLayout

2
ui/app/AppLayouts/Profile/views/DevicesView.qml
View File

@ -23,7 +23,7 @@ SettingsContentBase {
Item {
width: root.contentWidth
height: parent.height
height: !!parent ? parent.height : 0
Item {
id: firstTimeSetup