fix: code review

This commit is contained in:
Richard Ramos 2021-06-02 15:43:33 -04:00 committed by Iuri Matias
parent b89f2fddc4
commit efae828087
4 changed files with 9 additions and 9 deletions

View File

@ -41,7 +41,9 @@ SplitView {
Component {
id: communtiyColumnComponent
CommunityColumn {}
CommunityColumn {
pinnedMessagesPopupComponent: chatColumn.pinnedMessagesPopupComponent
}
}
Component {

View File

@ -12,6 +12,7 @@ import "./CommunityComponents"
Rectangle {
// TODO unhardcode
property int chatGroupsListViewCount: channelList.channelListCount
property Component pinnedMessagesPopupComponent
id: root
Layout.fillHeight: true
@ -20,6 +21,7 @@ Rectangle {
Component {
id: createChannelPopup
CreateChannelPopup {
pinnedMessagesPopupComponent: root.pinnedMessagesPopupComponent
onClosed: {
destroy()
}

View File

@ -14,6 +14,9 @@ ModalPopup {
property string categoryId: ""
readonly property int maxDescChars: 140
property string nameValidationError: ""
property Component pinnedMessagesPopupComponent
property bool isValid:
nameInput.isValid &&
descriptionTextArea.isValid
@ -173,14 +176,6 @@ ModalPopup {
// text: qsTrId("by-making-a-channel-private--only-members-with-selected-permission-will-be-able-to-access-it")
// }
Component {
id: pinnedMessagesPopupComponent
PinnedMessagesPopup {
id: pinnedMessagesPopup
onClosed: destroy()
}
}
CommunityPopupButton {
id: memberBtn
label: qsTr("Pinned messages")

View File

@ -284,6 +284,7 @@ RowLayout {
id: editChannelPopup
CreateChannelPopup {
isEdit: true
pinnedMessagesPopupComponent: chatLayoutContainer.chatColumn.pinnedMessagesPopupComponent
onClosed: {
destroy()
}