status-im/status-desktop
2
0
Fork 0
mirror of https://github.com/status-im/status-desktop.git synced 2025-03-04 00:11:12 +00:00
Code Issues Projects Releases Wiki Activity

feat: keycard log to file and only in development (#17363)

Browse Source
This commit is contained in:
Igor Sirotin 2025-02-24 13:02:24 +03:00 committed by GitHub
parent f024053e27
commit e8c69fa365
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/app_service/service/keycardV2/service.nim
View File

@ -113,7 +113,11 @@ QtObject:
error "error receiving a keycard signal", err=e.msg, data = signal
proc asyncStart(self: Service, storageDir: string) =
let params = %*{"storageFilePath": storageDir}
let params = %*{
"storageFilePath": storageDir,
"logEnabled": KEYCARD_LOGS_ENABLED,
"logFilePath": KEYCARD_LOG_FILE_PATH,
}
self.asyncCallRPC(KeycardAction.Start, params, proc (responseObj: JsonNode, err: string) =
if err.len > 0:
error "error starting keycard", err=err

5
src/constants.nim
View File

@ -31,7 +31,9 @@ let
ROOTKEYSTOREDIR* = joinPath(baseDir, "data", "keystore")
TMPDIR* = joinPath(baseDir, "tmp") & sep
LOGDIR* = joinPath(baseDir, "logs") & sep
KEYCARDPAIRINGDATAFILE* = joinPath(baseDir, "data", "keycard", "pairings.json")
KEYCARD_DATA_DIR* = joinPath(baseDir, "data", "keycard")
KEYCARD_LOG_FILE_PATH* = joinPath(KEYCARD_DATA_DIR, "keycard.log")
KEYCARDPAIRINGDATAFILE* = joinPath(KEYCARD_DATA_DIR, "pairings.json")
# runtime variables
TEST_MODE_ENABLED* = desktopConfig.testMode
@ -73,6 +75,7 @@ let
SENTRY_DSN_STATUS_GO* = BUILD_SENTRY_DSN_STATUS_GO
SENTRY_DSN_STATUS_GO_DESKTOP* = BUILD_SENTRY_DSN_STATUS_DESKTOP
API_LOGGING* = desktopConfig.apiLogging
KEYCARD_LOGS_ENABLED* = if defined(production): false else: true
proc hasLogLevelOption*(): bool =
for p in cliParams:

2
vendor/status-keycard-go vendored

@ -1 +1 @@
Subproject commit 6164aa4a829717eb3d745912403b59b32f5928c2
Subproject commit 695eab1a68455e366a1a11685840c59595007f94