From e75958d78d46dc675f59652439513bb920fe2f6f Mon Sep 17 00:00:00 2001 From: Richard Ramos Date: Wed, 16 Sep 2020 08:42:12 -0400 Subject: [PATCH] fix: code review --- .../ChatComponents/SignTransactionModal.qml | 13 ------------- .../Chat/components/StickerPackPurchaseModal.qml | 13 ------------- 2 files changed, 26 deletions(-) diff --git a/ui/app/AppLayouts/Chat/ChatColumn/ChatComponents/SignTransactionModal.qml b/ui/app/AppLayouts/Chat/ChatColumn/ChatComponents/SignTransactionModal.qml index 458fd2f002..4bd231288a 100644 --- a/ui/app/AppLayouts/Chat/ChatColumn/ChatComponents/SignTransactionModal.qml +++ b/ui/app/AppLayouts/Chat/ChatColumn/ChatComponents/SignTransactionModal.qml @@ -25,16 +25,6 @@ ModalPopup { icon: StandardIcon.Critical standardButtons: StandardButton.Ok } - property MessageDialog sendingSuccess: MessageDialog { - id: sendingSuccess - //% "Success sending the transaction" - title: qsTrId("success-sending-the-transaction") - icon: StandardIcon.NoIcon - standardButtons: StandardButton.Ok - onAccepted: { - root.close() - } - } onClosed: { stack.reset() @@ -58,9 +48,6 @@ ModalPopup { sendingError.text = response.error.message return sendingError.open() } - - sendingSuccess.text = qsTr("Transaction sent to the blockchain. You can watch the progress on Etherscan: %2%1").arg(response.result).arg(walletModel.etherscanLink) - sendingSuccess.open() } TransactionStackView { diff --git a/ui/app/AppLayouts/Chat/components/StickerPackPurchaseModal.qml b/ui/app/AppLayouts/Chat/components/StickerPackPurchaseModal.qml index f374f9258c..d8188ffea3 100644 --- a/ui/app/AppLayouts/Chat/components/StickerPackPurchaseModal.qml +++ b/ui/app/AppLayouts/Chat/components/StickerPackPurchaseModal.qml @@ -19,16 +19,6 @@ ModalPopup { icon: StandardIcon.Critical standardButtons: StandardButton.Ok } - property MessageDialog sendingSuccess: MessageDialog { - id: sendingSuccess - //% "Success sending the transaction" - title: qsTrId("success-sending-the-transaction") - icon: StandardIcon.NoIcon - standardButtons: StandardButton.Ok - onAccepted: { - root.close() - } - } onClosed: { stack.reset() @@ -51,9 +41,6 @@ ModalPopup { sendingError.text = response.error.message return sendingError.open() } - - sendingSuccess.text = qsTr("Transaction sent to the blockchain. You can watch the progress on Etherscan: %2%1").arg(response.result).arg(walletModel.etherscanLink) - sendingSuccess.open() } TransactionStackView {