status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

feat: settings cache efficiency update 

Current settings caching logic was inefficient when attempting to retrieve settings that contain the sensitive mnemonic. While those calls were limited to the login logic, each call would need to round trip to status-go to get all settings when they wanted to include sensitive data, as the cache was not being updated for these calls.

This PR updates the cache regardless if sensitive data is requested of not, effectively making the caching mechanism more efficient during login.
This commit is contained in:
Eric Mastro 2021-04-15 10:43:54 +10:00 committed by Iuri Matias
parent 0a108dd849
commit e47092cfd0
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/status/libstatus/settings.nim
View File

@ -35,11 +35,17 @@ proc getSettings*(useCached: bool = true, keepSensitiveData: bool = false): Json
if useCached and (not cacheIsDirty) and (not keepSensitiveData):
result = settings
else:
result = callPrivateRPC("settings_getSettings").parseJSON()["result"]
var
allSettings = callPrivateRPC("settings_getSettings").parseJSON()["result"]
var
noSensitiveData = allSettings.deepCopy
noSensitiveData.delete("mnemonic")
if not keepSensitiveData:
result = noSensitiveData
else:
result = allSettings
dirty.store(false)
delete(result, "mnemonic")
settings = result
settings = noSensitiveData # never include sensitive data in cache
settingsInited = true
proc getSetting*[T](name: Setting, defaultValue: T, useCached: bool = true): T =