feat(communities): re-enabled open membership communities

Closes #3410.

Re-enables open membership communities, with necessary changes in the Inivitation Bubble for one-on-one chats.

fix: add/edit communities components not appearing
On add/edit community popup load, some components below the thumbnail image picker were not appearing until the app window was resized. Removing the height of the ScrollView fixed the issue (on mac).

NOTE: this may require windows and linux users to test.

ui/app/AppLayouts/Chat/ChatColumn/MessageComponents/InvitationBubble.qml

@@ -132,7 +132,9 @@ Item {
                     },
                     State {
                         name: "joined"
-                        when: invitedCommunity.joined && invitedCommunity.isMember
+                        when: (invitedCommunity.joined && invitedCommunity.isMember) ||
+                              (invitedCommunity.access === Constants.communityChatPublicAccess &&
+                                invitedCommunity.joined)
                         PropertyChanges {
                             target: joinBtn
                             //% "View"
@@ -153,8 +155,10 @@ Item {
                     },
                     State {
                         name: "unjoined"
-                        when: invitedCommunity.access === Constants.communityChatOnRequestAccess &&
+                        when: (invitedCommunity.access === Constants.communityChatOnRequestAccess &&
-                              invitedCommunity.isMember
+                                invitedCommunity.isMember) ||
+                              (invitedCommunity.access === Constants.communityChatPublicAccess &&
+                                !invitedCommunity.joined)
                         PropertyChanges {
                             target: joinBtn
                             //% "Join"

ui/app/AppLayouts/Chat/CommunityComponents/CreateCommunityPopup.qml

@@ -23,6 +23,7 @@ StatusModal {
                                                    | Utils.Validate.TextHexColor
 
     id: popup
+    height: 509
 
     onOpened: {
         if (isEdit) {
@@ -65,7 +66,6 @@ StatusModal {
 
         contentHeight: content.height
         bottomPadding: 8
-        height: Math.min(content.height, 432)
         width: popup.width
 
         ScrollBar.horizontal.policy: ScrollBar.AlwaysOff
@@ -79,6 +79,7 @@ StatusModal {
         Column {
             id: content
             width: popup.width
+            spacing: 8
 
             Item {
                 height: 8
@@ -87,6 +88,7 @@ StatusModal {
 
             StatusInput {
                 id: nameInput
+                label: qsTr("Name your community")
                 charLimit: maxCommunityNameLength
                 input.placeholderText: qsTr("A catchy name")
                 validators: [StatusMinLengthValidator {
@@ -292,8 +294,6 @@ StatusModal {
                 visible: !isEdit
                 //% "Membership requirement"
                 title: qsTrId("membership-title")
-                // TODO: remove 'isEnabled: false' when we no longer need to force "request access" membership
-                enabled: false
                 label: {
                     switch (membershipRequirementSettingPopup.checkedMembership) {
                         //% "Require invite from another member"
@@ -315,8 +315,7 @@ StatusModal {
             }
 
             StatusBaseText {
-                // TODO: remove 'false' when we no longer need to force "request access" membership
+                visible: !isEdit
-                visible: false && !isEdit
                 height: visible ? implicitHeight : 0
                 wrapMode: Text.WordWrap
                 font.pixelSize: 13
@@ -455,9 +454,6 @@ StatusModal {
     MembershipRequirementPopup {
         anchors.centerIn: parent
         id: membershipRequirementSettingPopup
-        // TODO: remove the 'checkedMemership' setting when we no longer need
-        // to force "require approval" membership
-        checkedMembership: Constants.communityChatOnRequestAccess
     }
 }
 

ui/app/AppLayouts/Chat/CommunityComponents/MembershipRequirementPopup.qml

@@ -60,24 +60,26 @@ StatusModal {
             anchors.leftMargin: 32
         }
 
-        StatusListItem {
+        // TODO: uncomment this when we want to re-enable requiring invite from another member
-            anchors.horizontalCenter: parent.horizontalCenter
+        // for community creation
-            //% "Require invite from another member"
+        // StatusListItem {
-            title: qsTrId("membership-invite")
+        //     anchors.horizontalCenter: parent.horizontalCenter
-            sensor.onClicked: inviteOnlyRadio.checked = true
+        //     //% "Require invite from another member"
-            components: [
+        //     title: qsTrId("membership-invite")
-                StatusRadioButton {
+        //     sensor.onClicked: inviteOnlyRadio.checked = true
-                    id: inviteOnlyRadio
+        //     components: [
-                    checked: popup.checkedMembership === Constants.communityChatInvitationOnlyAccess
+        //         StatusRadioButton {
-                    ButtonGroup.group: membershipRequirementGroup
+        //             id: inviteOnlyRadio
-                    onCheckedChanged: {
+        //             checked: popup.checkedMembership === Constants.communityChatInvitationOnlyAccess
-                        if (checked) {
+        //             ButtonGroup.group: membershipRequirementGroup
-                            popup.checkedMembership = Constants.communityChatInvitationOnlyAccess
+        //             onCheckedChanged: {
-                        }
+        //                 if (checked) {
-                    }
+        //                     popup.checkedMembership = Constants.communityChatInvitationOnlyAccess
-                }
+        //                 }
-            ]
+        //             }
-        }
+        //         }
+        //     ]
+        // }
 
         StatusBaseText {
             wrapMode: Text.WordWrap