fix(wallet) use the all chains enabled state in filter

Optimization and fixes no chain ID for multi-transaction issue.

Updates: #12077

src/app/modules/main/wallet_section/activity/controller.nim

@@ -53,6 +53,7 @@ QtObject:
       addresses: seq[string]
       # call updateAssetsIdentities after updating chainIds
       chainIds: seq[int]
+      allChainsSelected: bool
 
       requestId: int32
 
@@ -152,7 +153,8 @@ QtObject:
     self.eventsHandler.updateSubscribedChainIDs(self.chainIds)
     self.status.setNewDataAvailable(false)
 
-    let response = backend_activity.filterActivityAsync(self.requestId, self.addresses, seq[backend_activity.ChainId](self.chainIds), self.currentActivityFilter, 0, FETCH_BATCH_COUNT_DEFAULT)
+    let chains = if not self.allChainsSelected: self.chainIds else: @[]
+    let response = backend_activity.filterActivityAsync(self.requestId, self.addresses, seq[backend_activity.ChainId](chains), self.currentActivityFilter, 0, FETCH_BATCH_COUNT_DEFAULT)
     if response.error != nil:
       error "error fetching activity entries: ", response.error
       self.status.setLoadingData(false)
@@ -160,7 +162,8 @@ QtObject:
 
   proc loadMoreItems(self: Controller) {.slot.} =
     self.status.setLoadingData(true)
-    let response = backend_activity.filterActivityAsync(self.requestId, self.addresses, seq[backend_activity.ChainId](self.chainIds), self.currentActivityFilter, self.model.getCount(), FETCH_BATCH_COUNT_DEFAULT)
+    let chains = if not self.allChainsSelected: self.chainIds else: @[]
+    let response = backend_activity.filterActivityAsync(self.requestId, self.addresses, seq[backend_activity.ChainId](chains), self.currentActivityFilter, self.model.getCount(), FETCH_BATCH_COUNT_DEFAULT)
     if response.error != nil:
       self.status.setLoadingData(false)
       error "error fetching activity entries: ", response.error
@@ -255,6 +258,7 @@ QtObject:
 
     result.addresses = @[]
     result.chainIds = @[]
+    result.allChainsSelected = true
 
     result.setup()
 
@@ -340,8 +344,9 @@ QtObject:
   proc setFilterToAddresses*(self: Controller, addresses: seq[string]) =
     self.currentActivityFilter.counterpartyAddresses = addresses
 
-  proc setFilterChains*(self: Controller, chainIds: seq[int]) =
+  proc setFilterChains*(self: Controller, chainIds: seq[int], allEnabled: bool) =
     self.chainIds = chainIds
+    self.allChainsSelected = allEnabled
     self.status.setIsFilterDirty(true)
 
     self.updateAssetsIdentities()
@@ -379,11 +384,11 @@ QtObject:
   QtProperty[QVariant] status:
     read = getStatus
 
-  proc globalFilterChanged*(self: Controller, addresses: seq[string], chainIds: seq[int]) = 
+  proc globalFilterChanged*(self: Controller, addresses: seq[string], chainIds: seq[int], allChainsEnabled: bool) =
     if (self.addresses == addresses and self.chainIds == chainIds):
       return
     self.setFilterAddresses(addresses)
-    self.setFilterChains(chainIds)
+    self.setFilterChains(chainIds, allChainsEnabled)
 
   proc noLimitTimestamp*(self: Controller): int {.slot.} =
     return backend_activity.noLimitTimestampForPeriod

src/app/modules/main/wallet_section/filter.nim

@@ -6,6 +6,7 @@ type Filter* = ref object
   controller: controller.Controller
   addresses*: seq[string]
   chainIds*: seq[int]
+  allChainsEnabled*: bool
   allAddresses*: bool
 
 proc initFilter*(
@@ -15,6 +16,7 @@ proc initFilter*(
   result.controller = controller
   result.addresses = @[]
   result.chainIds = @[]
+  result.allChainsEnabled = true
   result.allAddresses = false
 
 proc `$`*(self: Filter): string =
@@ -37,10 +39,6 @@ proc includeWatchOnlyToggled*(self: Filter) =
   else:
     self.addresses = self.controller.getWalletAccounts().filter(a => a.walletType != "watch").map(a => a.address)
 
-proc load*(self: Filter) =
-  self.includeWatchOnlyToggled()
-  self.chainIds = self.controller.getEnabledChainIds()
-
 proc setAddress*(self: Filter, address: string) =
   self.allAddresses = false
   self.addresses = @[address]
@@ -50,10 +48,15 @@ proc removeAddress*(self: Filter, address: string) =
     let accounts = self.controller.getWalletAccounts()
     self.addresses = @[accounts[0].address]
     return
-  
+
   let ind = self.addresses.find(address)
   if ind > -1:
     self.addresses.delete(ind)
-  
+
 proc updateNetworks*(self: Filter) =
   self.chainIds = self.controller.getEnabledChainIds()
+  self.allChainsEnabled = (self.chainIds.len == self.controller.getNetworks().len)
+
+proc load*(self: Filter) =
+  self.includeWatchOnlyToggled()
+  self.updateNetworks()

src/app/modules/main/wallet_section/module.nim

@@ -169,7 +169,7 @@ method notifyFilterChanged(self: Module) =
   self.assetsModule.filterChanged(self.filter.addresses, self.filter.chainIds)
   self.accountsModule.filterChanged(self.filter.addresses, self.filter.chainIds)
   self.sendModule.filterChanged(self.filter.addresses, self.filter.chainIds)
-  self.activityController.globalFilterChanged(self.filter.addresses, self.filter.chainIds)
+  self.activityController.globalFilterChanged(self.filter.addresses, self.filter.chainIds, self.filter.allChainsEnabled)
   self.collectiblesController.globalFilterChanged(self.filter.addresses, self.filter.chainIds)
   if self.filter.addresses.len > 0:
     self.view.filterChanged(self.filter.addresses[0], includeWatchOnly, self.filter.allAddresses)