From ce1436ac15b127cf1614af666ab69a0c6adce7ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Soko=C5=82owski?= Date: Fri, 15 Apr 2022 11:17:19 +0200 Subject: [PATCH] ci: remove caching of dependencies MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Upgrade of Jenkins to `2.343` has introduced a security fix that breaks caching plugin when it's configured to store cache on Master host: https://issues.jenkins.io/browse/JENKINS-67173 Sine the [Caching plugin](https://plugins.jenkins.io/jobcacher/) hasn't been upgraded in 5 years the only good temporary workaround is just drop caching of dependencies like Nim compiler entirely. In the future we can try some other caching methods. Related: https://github.com/status-im/nimbus-eth2/pull/3594 Signed-off-by: Jakub SokoĊ‚owski --- ci/Jenkinsfile.linux | 10 ++-------- ci/Jenkinsfile.macos | 24 +++++++++--------------- ci/Jenkinsfile.windows | 10 ++-------- 3 files changed, 13 insertions(+), 31 deletions(-) diff --git a/ci/Jenkinsfile.linux b/ci/Jenkinsfile.linux index b1bf49c8c6..bb71f3f180 100644 --- a/ci/Jenkinsfile.linux +++ b/ci/Jenkinsfile.linux @@ -53,14 +53,8 @@ pipeline { steps { /* trigger fetching of git submodules */ sh 'make check-pkg-target-linux' - /* avoid re-compiling Nim by using cache */ - cache(maxCacheSize: 250, caches: [[ - $class: 'ArbitraryFileCache', - includes: '**/*', - path: 'vendor/nimbus-build-system/vendor/Nim/bin' - ]]) { - sh 'make deps' - } + /* TODO: Re-add caching of Nim compiler. */ + sh 'make deps' } } diff --git a/ci/Jenkinsfile.macos b/ci/Jenkinsfile.macos index 6a81ae0770..8ef01e7a95 100644 --- a/ci/Jenkinsfile.macos +++ b/ci/Jenkinsfile.macos @@ -50,21 +50,15 @@ pipeline { steps { /* trigger fetching of git submodules */ sh 'make check-pkg-target-macos' - /* avoid re-compiling Nim by using cache */ - cache(maxCacheSize: 250, caches: [[ - $class: 'ArbitraryFileCache', - includes: '**/*', - path: 'vendor/nimbus-build-system/vendor/Nim/bin' - ]]) { - withCredentials([ - usernamePassword( /* For fetching HomeBrew bottles. */ - credentialsId: "status-im-auto-pkgs", - usernameVariable: 'GITHUB_USER', - passwordVariable: 'GITHUB_TOKEN' - ) - ]) { - sh 'make deps' - } + /* TODO: Re-add caching of Nim compiler. */ + withCredentials([ + usernamePassword( /* For fetching HomeBrew bottles. */ + credentialsId: "status-im-auto-pkgs", + usernameVariable: 'GITHUB_USER', + passwordVariable: 'GITHUB_TOKEN' + ) + ]) { + sh 'make deps' } } } diff --git a/ci/Jenkinsfile.windows b/ci/Jenkinsfile.windows index d30b35e2a4..8c58e5a0de 100644 --- a/ci/Jenkinsfile.windows +++ b/ci/Jenkinsfile.windows @@ -47,14 +47,8 @@ pipeline { steps { /* trigger fetching of git submodules */ sh 'make check-pkg-target-windows' - /* avoid re-compiling Nim by using cache */ - cache(maxCacheSize: 250, caches: [[ - $class: 'ArbitraryFileCache', - includes: '**/*', - path: 'vendor/nimbus-build-system/vendor/Nim/bin' - ]]) { - sh 'make deps' - } + /* TODO: Re-add caching of Nim compiler. */ + sh 'make deps' } }