chore(@test_wallet_edit_network): test both tabs (#173)

test/e2e/constants/wallet.py

@@ -10,13 +10,15 @@ class DerivationPath(Enum):
 
 
 class WalletNetworkSettings(Enum):
+    EDIT_NETWORK_LIVE_TAB = 'Live Network'
+    EDIT_NETWORK_TEST_TAB = 'Test Network'
     TESTNET_SUBTITLE = 'Switch entire Status app to testnet only mode'
     TESTNET_ENABLED_TOAST_MESSAGE = 'Testnet mode turned on'
     TESTNET_DISABLED_TOAST_MESSAGE = 'Testnet mode turned off'
     ACKNOWLEDGMENT_CHECKBOX_TEXT = ('I understand that changing network settings can cause unforeseen issues, errors, '
                                     'security risks and potentially even loss of funds.')
     REVERT_TO_DEFAULT_LIVE_MAINNET_TOAST_MESSAGE = 'Live network settings for Mainnet reverted to default'
-
+    REVERT_TO_DEFAULT_TEST_MAINNET_TOAST_MESSAGE = 'Test network settings for Mainnet reverted to default'
 
 class WalletNetworkNaming(Enum):
     LAYER1_ETHEREUM = 'Mainnet'
@@ -32,7 +34,9 @@ class WalletNetworkNaming(Enum):
 
 class WalletNetworkDefaultValues(Enum):
     ETHEREUM_LIVE_MAIN = 'https://eth-archival.gateway.pokt.network/v1/lb/************************'
+    ETHEREUM_TEST_MAIN = 'https://goerli-archival.gateway.pokt.network/v1/lb/************************'
     ETHEREUM_LIVE_FAILOVER = 'https://mainnet.infura.io/v3/********************************'
+    ETHEREUM_TEST_FAILOVER = 'https://goerli.infura.io/v3/********************************'
 
 
 class WalletEditNetworkErrorMessages(Enum):

test/e2e/gui/screens/settings.py

@@ -8,6 +8,7 @@ import configs.timeouts
 import driver
 from constants import UserCommunityInfo, wallet_account_list_item
 from constants.syncing import SyncingSettings
+from constants.wallet import WalletNetworkSettings, WalletNetworkDefaultValues
 from driver import objects_access
 from driver.objects_access import walk_children
 from gui.components.back_up_your_seed_phrase_popup import BackUpYourSeedPhrasePopUp
@@ -18,6 +19,7 @@ from gui.components.settings.sync_new_device_popup import SyncNewDevicePopup
 from gui.components.social_links_popup import SocialLinksPopup
 from gui.components.wallet.testnet_mode_popup import TestnetModePopup
 from gui.components.wallet.wallet_account_popups import AccountPopup
+from gui.components.wallet.wallet_toast_message import WalletToastMessage
 from gui.elements.button import Button
 from gui.elements.check_box import CheckBox
 from gui.elements.list import List
@@ -453,42 +455,114 @@ class EditNetworkSettings(WalletSettingsView):
         self._network_edit_main_rpc_url_error_message = QObject('mainRpcUrlInputObject')
         self._network_edit_failover_rpc_url_error_message = QObject('failoverRpcUrlInputObject')
 
+    @allure.step('Select Live Network tab')
+    def click_live_network_tab(self):
+        self._live_network_tab.click()
+
+    @allure.step('Select Test Network tab')
+    def click_test_network_tab(self):
+        self._test_network_tab.click()
+
+    @allure.step('Click Revert to default button and redirect to Networks screen')
+    def click_revert_to_default_and_go_to_networks_main_screen(self):
+        self._network_edit_scroll.vertical_down_to(self._network_revert_to_default)
+        self._network_revert_to_default.click()
+        return NetworkWalletSettings().wait_until_appears()
+
+    @allure.step('Check toast message')
+    def check_toast_message(self, network_tab):
+        match network_tab:
+            case WalletNetworkSettings.EDIT_NETWORK_LIVE_TAB.value:
+                WalletToastMessage().get_toast_message(
+                    WalletNetworkSettings.REVERT_TO_DEFAULT_LIVE_MAINNET_TOAST_MESSAGE.value)
+            case WalletNetworkSettings.EDIT_NETWORK_TEST_TAB.value:
+                WalletToastMessage().get_toast_message(
+                    WalletNetworkSettings.REVERT_TO_DEFAULT_TEST_MAINNET_TOAST_MESSAGE.value)
+
     @allure.step('Verify elements for the edit network view')
-    def check_available_elements_on_edit_view(self):
+    def check_available_elements_on_edit_view(self, network_tab):
-        assert self._network_edit_view_back_button.exists, f"Back button is not present"
+        match network_tab:
-        assert self._live_network_tab.exists, f"Live tab is not present"
+            case WalletNetworkSettings.EDIT_NETWORK_LIVE_TAB.value:
-        assert self._test_network_tab.exists, f"Test tab is not present"
+                self._live_network_tab.click()
-        assert self._network_name.exists, f"Network name input field is not present"
+                assert self._network_edit_view_back_button.exists, f"Back button is not present"
-        assert self._network_short_name.exists, f"Short name input field is not present"
+                assert self._live_network_tab.exists, f"Live tab is not present"
-        assert self._network_chaid_id.exists, f"Chaid Id input field is not present"
+                assert self._test_network_tab.exists, f"Test tab is not present"
-        assert self._network_native_token_symbol.exists, f"Native token symbol input field is not present"
+                assert self._network_name.exists, f"Network name input field is not present"
-        assert self._network_main_json_rpc_url.exists, f"Main JSON RPC URL input field is not present"
+                assert self._network_short_name.exists, f"Short name input field is not present"
-        assert self._network_failover_json_rpc_url.exists, f"Failover JSON RPC URL input field is not present"
+                assert self._network_chaid_id.exists, f"Chaid Id input field is not present"
-        assert self._network_block_explorer.exists, f"Block explorer input field is not present"
+                assert self._network_native_token_symbol.exists, f"Native token symbol input field is not present"
+                assert self._network_main_json_rpc_url.exists, f"Main JSON RPC URL input field is not present"
+                assert self._network_failover_json_rpc_url.exists, f"Failover JSON RPC URL input field is not present"
+                assert self._network_block_explorer.exists, f"Block explorer input field is not present"
 
-        self._network_edit_scroll.vertical_down_to(self._network_acknowledgment_checkbox)
+                self._network_edit_scroll.vertical_down_to(self._network_acknowledgment_checkbox)
-        assert driver.waitFor(lambda: self._network_acknowledgment_checkbox.exists,
+                assert driver.waitFor(lambda: self._network_acknowledgment_checkbox.exists,
-                              configs.timeouts.UI_LOAD_TIMEOUT_MSEC), f"Acknowldegment checkbox is not present"
+                                      configs.timeouts.UI_LOAD_TIMEOUT_MSEC), f"Acknowldegment checkbox is not present"
 
-        assert not driver.waitForObjectExists(self._network_revert_to_default.real_name,
+                assert not driver.waitForObjectExists(self._network_revert_to_default.real_name,
-                                              configs.timeouts.UI_LOAD_TIMEOUT_MSEC).enabled, \
+                                                      configs.timeouts.UI_LOAD_TIMEOUT_MSEC).enabled, \
-            f"Revert to default button is enabled"
+                    f"Revert to default button is enabled"
 
-        assert not driver.waitForObjectExists(self._network_save_changes.real_name,
+                assert not driver.waitForObjectExists(self._network_save_changes.real_name,
-                                              configs.timeouts.UI_LOAD_TIMEOUT_MSEC).enabled, \
+                                                      configs.timeouts.UI_LOAD_TIMEOUT_MSEC).enabled, \
-            f"Save changes button is enabled"
+                    f"Save changes button is enabled"
+
+            case WalletNetworkSettings.EDIT_NETWORK_TEST_TAB.value:
+                self._test_network_tab.click()
+                assert self._network_edit_view_back_button.exists, f"Back button is not present"
+                assert self._live_network_tab.exists, f"Live tab is not present"
+                assert self._test_network_tab.exists, f"Test tab is not present"
+                assert self._network_name.exists, f"Network name input field is not present"
+                assert self._network_short_name.exists, f"Short name input field is not present"
+                assert self._network_chaid_id.exists, f"Chaid Id input field is not present"
+                assert self._network_native_token_symbol.exists, f"Native token symbol input field is not present"
+                assert self._network_main_json_rpc_url.exists, f"Main JSON RPC URL input field is not present"
+                assert self._network_failover_json_rpc_url.exists, f"Failover JSON RPC URL input field is not present"
+                assert self._network_block_explorer.exists, f"Block explorer input field is not present"
+
+                self._network_edit_scroll.vertical_down_to(self._network_acknowledgment_checkbox)
+                assert driver.waitFor(lambda: self._network_acknowledgment_checkbox.exists,
+                                      configs.timeouts.UI_LOAD_TIMEOUT_MSEC), f"Acknowldegment checkbox is not present"
+
+                assert not driver.waitForObjectExists(self._network_revert_to_default.real_name,
+                                                      configs.timeouts.UI_LOAD_TIMEOUT_MSEC).enabled, \
+                    f"Revert to default button is enabled"
+
+                assert not driver.waitForObjectExists(self._network_save_changes.real_name,
+                                                      configs.timeouts.UI_LOAD_TIMEOUT_MSEC).enabled, \
+                    f"Save changes button is enabled"
 
     @allure.step('Edit Main RPC url input field')
-    def edit_network_main_json_rpc_url_input(self, test_value):
+    def edit_network_main_json_rpc_url_input(self, test_value, network_tab):
-        self._network_main_json_rpc_url.text = test_value
+        match network_tab:
+            case WalletNetworkSettings.EDIT_NETWORK_LIVE_TAB.value:
+                self._live_network_tab.click()
+                self._network_main_json_rpc_url.text = test_value
+            case WalletNetworkSettings.EDIT_NETWORK_TEST_TAB.value:
+                self._test_network_tab.click()
+                self._network_main_json_rpc_url.text = test_value
 
     @allure.step('Edit Failover RPC url input field')
-    def edit_network_failover_json_rpc_url_input(self, test_value):
+    def edit_network_failover_json_rpc_url_input(self, test_value, network_tab):
-        self._network_failover_json_rpc_url.text = test_value
+        match network_tab:
+            case WalletNetworkSettings.EDIT_NETWORK_LIVE_TAB.value:
+                self._live_network_tab.click()
+                self._network_failover_json_rpc_url.text = test_value
+            case WalletNetworkSettings.EDIT_NETWORK_TEST_TAB.value:
+                self._test_network_tab.click()
+                self._network_failover_json_rpc_url.text = test_value
 
     @allure.step('Check acknowledgment checkbox')
-    def check_acknowledgement_checkbox(self, value: bool):
+    def check_acknowledgement_checkbox(self, value: bool, network_tab):
-        self._network_acknowledgment_checkbox.set(value)
+        match network_tab:
+            case WalletNetworkSettings.EDIT_NETWORK_LIVE_TAB.value:
+                self._live_network_tab.click()
+                self._network_edit_scroll.vertical_down_to(self._network_acknowledgment_checkbox)
+                self._network_acknowledgment_checkbox.set(value)
+            case WalletNetworkSettings.EDIT_NETWORK_TEST_TAB.value:
+                self._test_network_tab.click()
+                self._network_edit_scroll.vertical_down_to(self._network_acknowledgment_checkbox)
+                self._network_acknowledgment_checkbox.set(value)
         return self
 
     @allure.step('Get the text for consent when changing RPC urls')
@@ -532,6 +606,26 @@ class EditNetworkSettings(WalletSettingsView):
     def get_edit_network_failover_json_rpc_url_value(self):
         return self._network_failover_json_rpc_url.text
 
+    @allure.step('Verify value in Main JSON RPC input')
+    def verify_edit_network_main_json_rpc_url_value(self, network_tab):
+        match network_tab:
+            case WalletNetworkSettings.EDIT_NETWORK_LIVE_TAB.value:
+                self._live_network_tab.click()
+                assert self.get_edit_network_main_json_rpc_url_value() == WalletNetworkDefaultValues.ETHEREUM_LIVE_MAIN.value
+            case WalletNetworkSettings.EDIT_NETWORK_TEST_TAB.value:
+                self._test_network_tab.click()
+                assert self.get_edit_network_main_json_rpc_url_value() == WalletNetworkDefaultValues.ETHEREUM_TEST_MAIN.value
+
+    @allure.step('Verify value in Failover JSON RPC input')
+    def verify_edit_network_failover_json_rpc_url_value(self, network_tab):
+        match network_tab:
+            case WalletNetworkSettings.EDIT_NETWORK_LIVE_TAB.value:
+                self._live_network_tab.click()
+                assert self.get_edit_network_failover_json_rpc_url_value() == WalletNetworkDefaultValues.ETHEREUM_LIVE_FAILOVER.value
+            case WalletNetworkSettings.EDIT_NETWORK_TEST_TAB.value:
+                self._test_network_tab.click()
+                assert self.get_edit_network_failover_json_rpc_url_value() == WalletNetworkDefaultValues.ETHEREUM_TEST_FAILOVER.value
+
 
 class EditAccountOrderSettings(WalletSettingsView):
 

test/e2e/tests/settings/settings_wallet/test_wallet_settings_networks_edit_network.py

@@ -3,16 +3,21 @@ import pytest
 from allure_commons._allure import step
 
 import driver
-from constants.wallet import WalletNetworkNaming, WalletEditNetworkErrorMessages, WalletNetworkSettings, \
+
-    WalletNetworkDefaultValues
+from constants.wallet import WalletNetworkNaming, WalletEditNetworkErrorMessages, WalletNetworkSettings
-from gui.components.wallet.wallet_toast_message import WalletToastMessage
+
 from gui.main_window import MainWindow
 
 
 @allure.testcase('https://ethstatus.testrail.net/index.php?/cases/view/703515',
                  'Network:  Network: Editing network -> Restore defaults')
 @pytest.mark.case(703515)
-def test_settings_networks_edit_restore_defaults(main_screen: MainWindow):
+@pytest.mark.parametrize('network_tab', [
+    pytest.param(WalletNetworkSettings.EDIT_NETWORK_LIVE_TAB.value),
+    pytest.param(WalletNetworkSettings.EDIT_NETWORK_TEST_TAB.value)
+])
+def test_settings_networks_edit_restore_defaults(main_screen: MainWindow, network_tab: str):
+
     networks = main_screen.left_panel.open_settings().left_panel.open_wallet_settings().open_networks()
 
     with step('Check network items titles'):
@@ -28,24 +33,24 @@ def test_settings_networks_edit_restore_defaults(main_screen: MainWindow):
             WalletNetworkNaming.ETHEREUM_MAINNET_NETWORK_ID.value)
 
     with step('Check the elements on the form'):
-        edit_network_form.wait_until_appears().check_available_elements_on_edit_view()
+        edit_network_form.wait_until_appears().check_available_elements_on_edit_view(network_tab)
 
     with step('Click in Main JSON RPC URL and paste incorrect URL'):
-        edit_network_form.edit_network_main_json_rpc_url_input("https://eth-archival.gateway.pokt.network/v1/lb/")
+        edit_network_form.edit_network_main_json_rpc_url_input("https://google.com", network_tab)
 
     with step('Check error message for Main JSON RPC URL input'):
         assert driver.waitFor(
             lambda: edit_network_form.get_main_rpc_url_error_message_text() == WalletEditNetworkErrorMessages.PINGUNSUCCESSFUL.value)
 
     with step('Click in Failover JSON RPC URL and paste incorrect URL'):
-        edit_network_form.edit_network_failover_json_rpc_url_input("https://eth-archival.gateway.pokt.network/v1/lb/")
+        edit_network_form.edit_network_failover_json_rpc_url_input("https://google.com", network_tab)
 
     with step('Check error message for Failover JSON RPC URL input'):
         assert driver.waitFor(
             lambda: edit_network_form.get_failover_rpc_url_error_message_text() == WalletEditNetworkErrorMessages.PINGUNSUCCESSFUL.value)
 
     with step('Check the acknowledgment checkbox'):
-        edit_network_form.check_acknowledgement_checkbox(True)
+        edit_network_form.check_acknowledgement_checkbox(True, network_tab)
 
     with step('Check the acknowledgment text'):
         assert edit_network_form.get_acknowledgement_checkbox_text(
@@ -55,17 +60,17 @@ def test_settings_networks_edit_restore_defaults(main_screen: MainWindow):
         edit_network_form.click_revert_to_default_and_go_to_networks_main_screen()
 
     with step('Verify toast message appears for reverting to defaults'):
-        assert WalletToastMessage().get_toast_message(WalletNetworkSettings.REVERT_TO_DEFAULT_LIVE_MAINNET_TOAST_MESSAGE.value)
+        edit_network_form.check_toast_message(network_tab)
 
     with step('Open Ethereum Mainnet network item to edit'):
         edit_network_form = networks.click_network_item_to_open_edit_view(
             WalletNetworkNaming.ETHEREUM_MAINNET_NETWORK_ID.value)
 
-    with step('Check value in Main JSON RPC URL input'):
+    with step('Verify value in Main JSON RPC URL input'):
-        assert edit_network_form.get_edit_network_main_json_rpc_url_value() == WalletNetworkDefaultValues.ETHEREUM_LIVE_MAIN.value
+        edit_network_form.verify_edit_network_main_json_rpc_url_value(network_tab)
 
-    with (step('Check value in Failover JSON RPC URL input')):
+    with (step('Verify value in Failover JSON RPC URL input')):
-        assert edit_network_form.get_edit_network_failover_json_rpc_url_value() == WalletNetworkDefaultValues.ETHEREUM_LIVE_FAILOVER.value
+        edit_network_form.verify_edit_network_failover_json_rpc_url_value(network_tab)
 
     with step('Verify the acknowledgment checkbox is unchecked'):
-        assert edit_network_form.check_acknowledgement_checkbox(False)
+        assert edit_network_form.check_acknowledgement_checkbox(False, network_tab)