From bdc625ea17b8802be38ae3838618aeb6c20e8f9f Mon Sep 17 00:00:00 2001
From: Jonathan Rainville <rainville.jonathan@gmail.com>
Date: Thu, 16 Jul 2020 11:20:06 -0400
Subject: [PATCH] fix code review comments

---
 scripts/translationScripts/README.md    | 2 +-
 scripts/translationScripts/package.json | 1 +
 scripts/translationScripts/utils.js     | 6 +++---
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/scripts/translationScripts/README.md b/scripts/translationScripts/README.md
index 2cc3b772c6..86d9334807 100644
--- a/scripts/translationScripts/README.md
+++ b/scripts/translationScripts/README.md
@@ -48,7 +48,7 @@ Some translations will not be done, check the next section to know how to transl
 
 Since not all strings used in the desktop app are also used in Status-React, the remaining will need to be translated manually.
 
-If the strings are not translated, it is not the end f the world, the English strings will be shown instead.
+If the strings are not translated, it is not the end of the world, the English strings will be shown instead.
 
 To do so, you can use QT Linguist to help with the process. Check here to see the Linguist docs: https://doc.qt.io/qt-5/linguist-translators.html
 
diff --git a/scripts/translationScripts/package.json b/scripts/translationScripts/package.json
index 35c52b9215..66a6929c77 100644
--- a/scripts/translationScripts/package.json
+++ b/scripts/translationScripts/package.json
@@ -1,5 +1,6 @@
 {
   "name": "translationscripts",
+  "private": true,
   "version": "1.0.0",
   "description": "These scripts are used to translate the app automatically by reusing the existing translation found in the Status-React repo: https://github.com/status-im/status-react/tree/develop/translations",
   "main": "qstrConverter.js",
diff --git a/scripts/translationScripts/utils.js b/scripts/translationScripts/utils.js
index 9bc57f39bb..7b19890287 100644
--- a/scripts/translationScripts/utils.js
+++ b/scripts/translationScripts/utils.js
@@ -5,10 +5,10 @@ const getAllFiles = function(dirPath, ext, arrayOfFiles = []) {
     const files = fs.readdirSync(dirPath)
 
     files.forEach(file => {
-        if (fs.statSync(dirPath + "/" + file).isDirectory()) {
-            arrayOfFiles = getAllFiles(dirPath + "/" + file, ext, arrayOfFiles)
+        if (fs.statSync(path.join(dirPath, file)).isDirectory()) {
+            arrayOfFiles = getAllFiles(path.join(dirPath, file), ext, arrayOfFiles)
         } else if (!ext || file.endsWith(ext)) {
-            arrayOfFiles.push(path.join(__dirname, dirPath, "/", file))
+            arrayOfFiles.push(path.join(__dirname, dirPath, file))
         }
     })