status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(@desktop/community)!: missing error messages 

Remove ValidationMode.Always for StatusInputs because by default they
are invalid and validate input when dirty
Remove condition from errorMessage of BackupSeedStepBase as not needed.

Fixes #6825

Requires https://github.com/status-im/StatusQ/pull/858

BREAKING CHANGE: StatusInputs are invalid by default and validate when
dirty.
This commit is contained in:
PavelS 2022-08-16 19:22:59 +03:00 committed by PavelS
parent 48b7f1c277
commit ba50c69b76
9 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/StatusQ

@ -1 +1 @@
Subproject commit a22d8252b104b25459d4cb7c387e1ca5cf4fc00a
Subproject commit 9f6f9905e988bb98689a4157dc7ad1fd42ea88c2

1
ui/app/AppLayouts/Chat/controls/community/CommunityDescriptionInput.qml
View File

@ -30,5 +30,4 @@ StatusInput {
qsTr("community description"))
}
]
validationMode: StatusInput.ValidationMode.Always
}

1
ui/app/AppLayouts/Chat/controls/community/CommunityIntroMessageInput.qml
View File

@ -29,5 +29,4 @@ StatusInput {
qsTr("community intro message"))
}
]
validationMode: StatusInput.ValidationMode.Always
}

1
ui/app/AppLayouts/Chat/controls/community/CommunityNameInput.qml
View File

@ -22,5 +22,4 @@ StatusInput {
qsTr("community name"))
}
]
validationMode: StatusInput.ValidationMode.Always
}

1
ui/app/AppLayouts/Chat/controls/community/CommunityOutroMessageInput.qml
View File

@ -25,5 +25,4 @@ StatusInput {
qsTr("community intro message"))
}
]
validationMode: StatusInput.ValidationMode.Always
}

2
ui/app/AppLayouts/Chat/popups/community/CreateChannelPopup.qml
View File

@ -131,7 +131,6 @@ StatusDialog {
root.emojiPopup.y = root.y + root.header.height + root.topPadding + nameInput.height + Style.current.smallPadding;
}
}
validationMode: StatusInput.ValidationMode.Always
validators: [
StatusMinLengthValidator {
minLength: 1
@ -214,7 +213,6 @@ StatusDialog {
input.multiline: true
minimumHeight: 88
maximumHeight: 88
validationMode: StatusInput.ValidationMode.Always
validators: [StatusMinLengthValidator {
minLength: 1
errorMessage: Utils.getErrorMessage(descriptionTextArea.errors, qsTr("channel description"))

1
ui/app/AppLayouts/Profile/popups/SendContactRequestModal.qml
View File

@ -137,7 +137,6 @@ StatusModal {
minLength: d.minMsgLength
errorMessage: Utils.getErrorMessage(messageInput.errors, qsTr("who are you"))
}]
validationMode: StatusInput.ValidationMode.Always
}
}
}

3
ui/app/AppLayouts/Profile/popups/backupseed/BackupSeedStepBase.qml
View File

@ -39,13 +39,12 @@ StatusScrollView {
id: inputText
visible: (wordRandomNumber > -1)
implicitWidth: 448
validationMode: StatusInput.ValidationMode.Always
label: qsTr("Word #%1").arg(wordRandomNumber + 1)
placeholderText: qsTr("Enter word")
validators: [
StatusValidator {
validate: function (t) { return (root.wordAtRandomNumber === inputText.text); }
errorMessage: (inputText.text.length) > 0 ? qsTr("Wrong word") : ""
errorMessage: qsTr("Wrong word")
}
]
Layout.fillWidth: true

1
ui/imports/shared/popups/SendContactRequestModal.qml
View File

@ -63,7 +63,6 @@ StatusModal {
minLength: d.minMsgLength
errorMessage: Utils.getErrorMessage(messageInput.errors, qsTr("who are you"))
}
validationMode: StatusInput.ValidationMode.Always
Layout.fillWidth: true
}
}