From b9c65be808c6a06ecfafd9066f305c8e0a52cdc9 Mon Sep 17 00:00:00 2001
From: Pascal Precht <445106+PascalPrecht@users.noreply.github.com>
Date: Fri, 3 Jun 2022 10:04:37 +0200
Subject: [PATCH] fix(AppNavBar): make navbar buttons render correctly again

We've introduced a regression in
https://github.com/status-im/status-desktop/commit/9f633f0fcce234dcda9968c71a614d60a9cd55f2
where model data for navbar buttons are malformed, which results in them being rendered
incorrectly (as letter identicons, instead of icon buttons)

The reason this was happening was because the model data for the
navbar buttons was not properly initialized due to a mixed usage of
positioned and named arguments of the `initItem()` APIs in `SectionItem`
models.

Fixes #5949
---
 src/app/modules/main/module.nim | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/app/modules/main/module.nim b/src/app/modules/main/module.nim
index f5180f8ba3..f1eb0eeabf 100644
--- a/src/app/modules/main/module.nim
+++ b/src/app/modules/main/module.nim
@@ -292,7 +292,7 @@ method load*[T](
   amISectionAdmin = false,
   description = "",
   image = "",
-  conf.COMMUNITIESPORTAL_SECTION_ICON,
+  icon = conf.COMMUNITIESPORTAL_SECTION_ICON,
   color = "",
   hasNotification = false,
   notificationsCount = 0,
@@ -307,7 +307,7 @@ method load*[T](
   amISectionAdmin = false,
   description = "",
   image = "",
-  conf.WALLET_SECTION_ICON,
+  icon = conf.WALLET_SECTION_ICON,
   color = "",
   hasNotification = false,
   notificationsCount = 0,
@@ -322,7 +322,7 @@ method load*[T](
   amISectionAdmin = false,
   description = "",
   image = "",
-  conf.BROWSER_SECTION_ICON,
+  icon = conf.BROWSER_SECTION_ICON,
   color = "",
   hasNotification = false,
   notificationsCount = 0,
@@ -338,7 +338,7 @@ method load*[T](
   amISectionAdmin = false,
   description = "",
   image = "",
-  conf.NODEMANAGEMENT_SECTION_ICON,
+  icon = conf.NODEMANAGEMENT_SECTION_ICON,
   color = "",
   hasNotification = false,
   notificationsCount = 0,
@@ -354,7 +354,7 @@ method load*[T](
   amISectionAdmin = false,
   description = "",
   image = "",
-  conf.SETTINGS_SECTION_ICON,
+  icon = conf.SETTINGS_SECTION_ICON,
   color = "",
   hasNotification = self.calculateProfileSectionHasNotification(),
   notificationsCount = 0,