status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(wallet): fixed precision loss for balance amount in nimqml 

fixed currency amount property type to be handled by QMetatype properly
This commit is contained in:
Ivan Belyakov 2024-04-11 19:27:04 +02:00 committed by IvanBelyakoff
parent b9271005cd
commit b9268d8f1e
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/app/modules/shared_models/currency_amount.nim
View File

@ -39,13 +39,11 @@ QtObject:
stripTrailingZeroes: {self.stripTrailingZeroes} stripTrailingZeroes: {self.stripTrailingZeroes}
)""" )"""
proc getAmount*(self: CurrencyAmount): float64 = proc getAmount*(self: CurrencyAmount): float {.slot.} =
return self.amount return self.amount
proc getAmountFloat*(self: CurrencyAmount): float {.slot.} =
return self.amount
QtProperty[float] amount: QtProperty[float] amount:
read = getAmountFloat read = getAmount
proc getSymbol*(self: CurrencyAmount): string {.slot.} = proc getSymbol*(self: CurrencyAmount): string {.slot.} =
return self.symbol return self.symbol

2
src/app_service/service/community_tokens/service.nim
View File

@ -1362,7 +1362,7 @@ QtObject:
dataToEmit.errorCode = ComputeFeeErrorCode.Balance # set total error code to balance error dataToEmit.errorCode = ComputeFeeErrorCode.Balance # set total error code to balance error
var args = self.createComputeFeeArgsFromEthAndBalance(ethValue, balance) var args = self.createComputeFeeArgsFromEthAndBalance(ethValue, balance)
totalEthVal = totalEthVal + ethValue totalEthVal = totalEthVal + ethValue
totalFiatVal = totalFiatVal + args.fiatCurrency.getAmountFloat() totalFiatVal = totalFiatVal + args.fiatCurrency.getAmount()
args.contractUniqueKey = common_utils.contractUniqueKey(collectibleAndAmount.communityToken.chainId, collectibleAndAmount.communityToken.address) args.contractUniqueKey = common_utils.contractUniqueKey(collectibleAndAmount.communityToken.chainId, collectibleAndAmount.communityToken.address)
allComputeFeeArgs.add(args) allComputeFeeArgs.add(args)

2
vendor/nimqml vendored

@ -1 +1 @@
Subproject commit 13a8890db484d3ff40b410c2ff4b3e3bd2e0e880 Subproject commit 20d4db12bb40dcf1c549ab3149ca0b4b791e90b7