status-im/status-desktop
2
0
Fork 0
mirror of https://github.com/status-im/status-desktop.git synced 2025-02-27 05:51:09 +00:00
Code Issues Projects Releases Wiki Activity

Debug trail for UI thread blocking on activeItemChanged()

Browse Source
This commit is contained in:
Teodor M. Ionita 2023-11-06 11:25:46 +02:00
parent 1eab90173e
commit b30b3e4df3
No known key found for this signature in database
GPG Key ID: 062D853392376829
5 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/modules/main/chat_section/controller.nim
View File

@ -1,4 +1,4 @@
import Tables, sugar, sequtils, strutils import Tables, sugar, sequtils, strutils, times
import io_interface import io_interface
@ -450,7 +450,9 @@ proc setActiveItem*(self: Controller, itemId: string) =
self.messageService.asyncLoadInitialMessagesForChat(self.activeItemId) self.messageService.asyncLoadInitialMessagesForChat(self.activeItemId)
# We need to take other actions here like notify status go that unviewed mentions count is updated and so... # We need to take other actions here like notify status go that unviewed mentions count is updated and so...
var time = cpuTime()
self.delegate.activeItemSet(self.activeItemId) self.delegate.activeItemSet(self.activeItemId)
echo "Time taken: ", cpuTime() - time
proc removeCommunityChat*(self: Controller, itemId: string) = proc removeCommunityChat*(self: Controller, itemId: string) =
self.communityService.deleteCommunityChat(self.getMySectionId(), itemId) self.communityService.deleteCommunityChat(self.getMySectionId(), itemId)

8
src/app/modules/main/chat_section/module.nim
View File

@ -1,4 +1,4 @@
import NimQml, Tables, chronicles, json, sequtils, strutils, strformat, sugar, marshal import NimQml, Tables, chronicles, json, sequtils, strutils, strformat, sugar, marshal, times
import io_interface import io_interface
import ../io_interface as delegate_interface import ../io_interface as delegate_interface
@ -14,9 +14,7 @@ import ../../shared_models/token_criteria_model
import ../../shared_models/token_permission_chat_list_model import ../../shared_models/token_permission_chat_list_model
import chat_content/module as chat_content_module import chat_content/module as chat_content_module
import chat_content/users/module as users_module
import ../../../global/app_sections_config as conf
import ../../../global/global_singleton import ../../../global/global_singleton
import ../../../core/eventemitter import ../../../core/eventemitter
import ../../../core/unique_event_emitter import ../../../core/unique_event_emitter
@ -406,13 +404,15 @@ method activeItemSet*(self: Module, itemId: string) =
# update view maintained by this module # update view maintained by this module
self.view.chatsModel().setActiveItem(itemId) self.view.chatsModel().setActiveItem(itemId)
var time = cpuTime()
self.view.activeItemSet(chat_item) self.view.activeItemSet(chat_item)
echo "view update duration: ", cpuTime() - time
self.updateActiveChatMembership() self.updateActiveChatMembership()
let activeChatId = self.controller.getActiveChatId() let activeChatId = self.controller.getActiveChatId()
# # update child modules # update child modules
for chatId, chatContentModule in self.chatContentModules: for chatId, chatContentModule in self.chatContentModules:
if chatId == activeChatId: if chatId == activeChatId:
chatContentModule.onMadeActive() chatContentModule.onMadeActive()

6
src/app/modules/main/chat_section/view.nim
View File

@ -1,4 +1,4 @@
import NimQml, json, sequtils, strutils import NimQml, json, sequtils, strutils, times
import model as chats_model import model as chats_model
import item, active_item import item, active_item
import ../../shared_models/user_model as user_model import ../../shared_models/user_model as user_model
@ -148,7 +148,9 @@ QtObject:
proc activeItemSet*(self: View, item: Item) = proc activeItemSet*(self: View, item: Item) =
self.activeItem.setActiveItemData(item) self.activeItem.setActiveItemData(item)
self.activeItemChanged() var time = cpuTime()
self.activeItemChanged() # UI block happens after emitting this signal
echo "activeItemSet duration: ", cpuTime() - time
proc setActiveItem*(self: View, itemId: string) {.slot.} = proc setActiveItem*(self: View, itemId: string) {.slot.} =
self.delegate.setActiveItem(itemId) self.delegate.setActiveItem(itemId)

3
src/app_service/service/message/async_tasks.nim
View File

@ -1,4 +1,4 @@
import std/uri, uuids import std/uri, uuids, os
include ../../common/json_utils include ../../common/json_utils
include ../../../app/core/tasks/common include ../../../app/core/tasks/common
@ -28,6 +28,7 @@ const asyncFetchChatMessagesTask: Task = proc(argEncoded: string) {.gcsafe, nimc
var messagesArr: JsonNode var messagesArr: JsonNode
var messagesCursor: JsonNode var messagesCursor: JsonNode
let msgsResponse = status_go.fetchMessages(arg.chatId, arg.msgCursor, arg.limit) let msgsResponse = status_go.fetchMessages(arg.chatId, arg.msgCursor, arg.limit)
# sleep(3000)
discard msgsResponse.result.getProp("cursor", messagesCursor) discard msgsResponse.result.getProp("cursor", messagesCursor)
discard msgsResponse.result.getProp("messages", messagesArr) discard msgsResponse.result.getProp("messages", messagesArr)
responseJson["messages"] = messagesArr responseJson["messages"] = messagesArr

3
ui/app/AppLayouts/Chat/views/ChatView.qml
View File

@ -99,7 +99,8 @@ StatusSectionLayout {
ignoreUnknownSignals: true ignoreUnknownSignals: true
function onActiveItemChanged() { function onActiveItemChanged() {
Global.closeCreateChatView() // Connection from activeItemChanged signal of ChatSectionModule
Global.closeCreateChatView() // Commenting this one out doesn't have any effect
} }
} }