fix(Chat): ensure message context menu preserve mentions in copied messages

Because the context menu relied on `unparsedTex` it was unable to preserve the pubkey<->displayName conversion when
copying messages to the clipboard.

This commit fixes it by introducing a new `replacePubKeysWithMentions` utility
which is used when message items are initialized, resulting in `unparsedText`
to keep th`@`mentions around.

Closes #9168

src/app/modules/main/activity_center/controller.nim

@@ -106,6 +106,9 @@ proc acceptActivityCenterNotifications*(self: Controller, notificationIds: seq[s
 proc dismissActivityCenterNotifications*(self: Controller, notificationIds: seq[string]): string =
    return self.activityCenterService.dismissActivityCenterNotifications(notificationIds)
 
+proc replacePubKeysWithDisplayNames*(self: Controller, message: string): string =
+  return self.messageService.replacePubKeysWithDisplayNames(message)
+
 proc getRenderedText*(self: Controller, parsedTextArray: seq[ParsedText], communityChats: seq[ChatDto]): string =
   return self.messageService.getRenderedText(parsedTextArray, communityChats)
 
@@ -127,4 +130,4 @@ proc getMessageById*(self: Controller, chatId, messageId: string): MessageDto =
   let (message, _, err) = self.messageService.getDetailsForMessage(chatId, messageId)
   if(err.len > 0):
     return MessageDto()
-  return message
+  return message

src/app/modules/main/activity_center/module.nim

@@ -95,7 +95,7 @@ proc createMessageItemFromDto(self: Module, message: MessageDto, chatDetails: Ch
     contactDetails.details.added,
     message.outgoingStatus,
     self.controller.getRenderedText(message.parsedText, communityChats),
-    message.text,
+    self.controller.replacePubKeysWithDisplayNames(message.text),
     message.image,
     message.containsContactMentions(),
     message.seen,

src/app/modules/main/chat_section/chat_content/controller.nim

@@ -238,6 +238,9 @@ proc getContactDetails*(self: Controller, contactId: string): ContactDetails =
 proc getCurrentFleet*(self: Controller): string =
   return self.nodeConfigurationService.getFleetAsString()
 
+proc replacePubKeysWithDisplayNames*(self: Controller, message: string): string =
+  return self.messageService.replacePubKeysWithDisplayNames(message)
+
 proc getRenderedText*(self: Controller, parsedTextArray: seq[ParsedText], communityChats: seq[ChatDto]): string =
   return self.messageService.getRenderedText(parsedTextArray, communityChats)
 

src/app/modules/main/chat_section/chat_content/messages/controller.nim

@@ -257,6 +257,9 @@ proc getNumOfPinnedMessages*(self: Controller): int =
 proc getRenderedText*(self: Controller, parsedTextArray: seq[ParsedText], communityChats: seq[ChatDto]): string =
   return self.messageService.getRenderedText(parsedTextArray, communityChats)
 
+proc replacePubKeysWithDisplayNames*(self: Controller, message: string): string =
+  return self.messageService.replacePubKeysWithDisplayNames(message)
+
 proc getMessageDetails*(self: Controller, messageId: string):
   tuple[message: MessageDto, reactions: seq[ReactionDto], error: string] =
   return self.messageService.getDetailsForMessage(self.chatId, messageId)

src/app/modules/main/chat_section/chat_content/messages/module.nim

@@ -237,7 +237,7 @@ method newMessagesLoaded*(self: Module, messages: seq[MessageDto], reactions: se
         sender.details.added,
         message.outgoingStatus,
         renderedMessageText,
-        message.text,
+        self.controller.replacePubKeysWithDisplayNames(message.text),
         message.image,
         message.containsContactMentions(),
         message.seen,
@@ -358,7 +358,7 @@ method messagesAdded*(self: Module, messages: seq[MessageDto]) =
       sender.details.added,
       message.outgoingStatus,
       renderedMessageText,
-      message.text,
+      self.controller.replacePubKeysWithDisplayNames(message.text),
       message.image,
       message.containsContactMentions(),
       message.seen,
@@ -556,7 +556,7 @@ method onMessageEdited*(self: Module, message: MessageDto) =
   self.view.model().updateEditedMsg(
     message.id,
     self.controller.getRenderedText(message.parsedText, communityChats),
-    message.text,
+    self.controller.replacePubKeysWithDisplayNames(message.text),
     message.contentType,
     message.containsContactMentions(),
     message.links,

src/app/modules/main/chat_section/chat_content/module.nim

@@ -184,7 +184,7 @@ proc buildPinnedMessageItem(self: Module, messageId: string, actionInitiatedBy:
     contactDetails.details.added,
     message.outgoingStatus,
     self.controller.getRenderedText(message.parsedText, communityChats),
-    message.text,
+    self.controller.replacePubKeysWithDisplayNames(message.text),
     message.image,
     message.containsContactMentions(),
     message.seen,

src/app/modules/main/chat_section/view.nim

@@ -316,4 +316,4 @@ QtObject:
     self.loadingHistoryMessagesInProgressChanged()
 
   proc downloadMessages*(self: View, chatId: string, filePath: string) {.slot.} =
-    self.delegate.downloadMessages(chatId, filePath)
+    self.delegate.downloadMessages(chatId, filePath)

src/app_service/common/message.nim

@@ -2,6 +2,22 @@ import sequtils, strutils, sugar, re
 import ../service/contacts/dto/contacts
 from conversion import SystemTagMapping
 
+
+proc replacePubKeysWithDisplayNames*(allKnownContacts: seq[ContactsDto], message: string): string =
+  let pubKeyPattern = re(r"(@0x[a-f0-9]+)", flags = {reStudy, reIgnoreCase})
+  let pubKeys = findAll(message, pubKeyPattern)
+  var updatedMessage = message
+
+  for pair in SystemTagMapping:
+    updatedMessage = updatedMessage.replaceWord(pair[1], pair[0])
+
+  for pk in pubKeys:
+    let listOfMatched = allKnownContacts.filter(x => "@" & x.id == pk)
+    if(listOfMatched.len > 0):
+      updatedMessage = updatedMessage.replaceWord(pk, "@" & listOfMatched[0].userDefaultDisplayName())
+
+  return updatedMessage
+
 proc replaceMentionsWithPubKeys*(allKnownContacts: seq[ContactsDto], message: string): string =
   let aliasPattern = re(r"(@[A-z][a-z]+ [A-z][a-z]* [A-z][a-z]*)", flags = {reStudy, reIgnoreCase})
   let ensPattern = re(r"(@\w+((\.stateofus)?\.eth))", flags = {reStudy, reIgnoreCase})

src/app_service/service/message/service.nim

@@ -775,6 +775,10 @@ proc deleteMessage*(self: Service, messageId: string) =
   except Exception as e:
     error "error: ", procName="deleteMessage", errName = e.name, errDesription = e.msg
 
+proc replacePubKeysWithDisplayNames*(self: Service, message: string): string =
+  let allKnownContacts = self.contactService.getContactsByGroup(ContactsGroup.AllKnownContacts)
+  return message_common.replacePubKeysWithDisplayNames(allKnownContacts, message)
+
 proc editMessage*(self: Service, messageId: string, contentType: int, msg: string) =
   try:
     let allKnownContacts = self.contactService.getContactsByGroup(ContactsGroup.AllKnownContacts)