status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor(@desktop/general): warnings caused due to inconsistent return types between service and interface are fixed

This commit is contained in:
Sale Djenic 2021-12-16 12:13:56 +01:00
parent 63b4397670
commit a9e4944eb2
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/modules/main/activity_center/io_interface.nim
View File

@ -27,7 +27,7 @@ method unreadActivityCenterNotificationsCount*(self: AccessInterface): int {.bas
method convertToItems*(self: AccessInterface, activityCenterNotifications: seq[ActivityCenterNotificationDto]): seq[Item] {.base.} = method convertToItems*(self: AccessInterface, activityCenterNotifications: seq[ActivityCenterNotificationDto]): seq[Item] {.base.} =
raise newException(ValueError, "No implementation available") raise newException(ValueError, "No implementation available")
method getActivityCenterNotifications*(self: AccessInterface) {.base.} = method getActivityCenterNotifications*(self: AccessInterface): seq[Item] {.base.} =
raise newException(ValueError, "No implementation available") raise newException(ValueError, "No implementation available")
method markAllActivityCenterNotificationsRead*(self: AccessInterface): string {.base.} = method markAllActivityCenterNotificationsRead*(self: AccessInterface): string {.base.} =

2
src/app/modules/main/activity_center/module.nim
View File

@ -107,7 +107,7 @@ method getActivityCenterNotifications*[T](self: Module[T]): seq[notification_ite
method markAllActivityCenterNotificationsRead*[T](self: Module[T]): string = method markAllActivityCenterNotificationsRead*[T](self: Module[T]): string =
self.controller.markAllActivityCenterNotificationsRead() self.controller.markAllActivityCenterNotificationsRead()
method markAllActivityCenterNotificationsReadDone*[T](self: Module[T]): string = method markAllActivityCenterNotificationsReadDone*[T](self: Module[T]) =
self.view.markAllActivityCenterNotificationsReadDone() self.view.markAllActivityCenterNotificationsReadDone()
method markActivityCenterNotificationRead*[T]( method markActivityCenterNotificationRead*[T](

2
src/app/modules/main/activity_center/view.nim
View File

@ -51,7 +51,7 @@ QtObject:
self.model.updateUnreadCount(count) self.model.updateUnreadCount(count)
proc loadMoreNotifications(self: View) {.slot.} = proc loadMoreNotifications(self: View) {.slot.} =
self.delegate.getActivityCenterNotifications() discard self.delegate.getActivityCenterNotifications()
proc markAllActivityCenterNotificationsRead(self: View): string {.slot.} = proc markAllActivityCenterNotificationsRead(self: View): string {.slot.} =
result = self.delegate.markAllActivityCenterNotificationsRead() result = self.delegate.markAllActivityCenterNotificationsRead()