status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

chore(ci): change RELEASE into INCLUDE_DEBUG_SYMBOLS 

This way it actually reflects the purpose accurately and allows us to
build without debug symbols in CI without pulling in release credentials.
https://github.com/status-im/status-desktop/issues/13079

The only utility for `RELEASE` parameter is inheriting it
from the parent meta-job(`ci/Jenkinsfile.combined`).

Signed-off-by: Jakub Sokołowski <jakub@status.im>
This commit is contained in:
Jakub Sokołowski 2024-02-23 10:19:57 +01:00
parent 3386ce74e7
commit a27e447f11
No known key found for this signature in database
GPG Key ID: FE65CD384D5BF7B4
7 changed files with 39 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Makefile
View File

@ -209,8 +209,8 @@ ifeq ($(detected_OS),Darwin)
endif endif
endif endif
RELEASE ?= false INCLUDE_DEBUG_SYMBOLS ?= false
ifeq ($(RELEASE),false) ifeq ($(INCLUDE_DEBUG_SYMBOLS),true)
# We need `-d:debug` to get Nim's default stack traces # We need `-d:debug` to get Nim's default stack traces
NIM_PARAMS += -d:debug NIM_PARAMS += -d:debug
# Enable debugging symbols in DOtherSide, in case we need GDB backtraces # Enable debugging symbols in DOtherSide, in case we need GDB backtraces

9
ci/Jenkinsfile.linux
View File

@ -18,9 +18,14 @@ pipeline {
parameters { parameters {
booleanParam( booleanParam(
name: 'RELEASE', name: 'RELEASE',
description: 'Decides whether binaries are built with debug symbols.', description: 'Decides whether release credentials are used.',
defaultValue: params.RELEASE ?: false defaultValue: params.RELEASE ?: false
) )
booleanParam(
name: 'INCLUDE_DEBUG_SYMBOLS',
description: 'Decides whether binaries are built with debug symbols.',
defaultValue: params.INCLUDE_DEBUG_SYMBOLS ?: false
)
choice( choice(
name: 'VERBOSE', name: 'VERBOSE',
description: 'Level of verbosity based on nimbus-build-system setup.', description: 'Level of verbosity based on nimbus-build-system setup.',
@ -129,4 +134,4 @@ def getArch() {
for (def arch in ['x86_64', 'aarch64']) { for (def arch in ['x86_64', 'aarch64']) {
if (tokens.contains(arch)) { return arch } if (tokens.contains(arch)) { return arch }
} }
} }

7
ci/Jenkinsfile.macos
View File

@ -13,9 +13,14 @@ pipeline {
parameters { parameters {
booleanParam( booleanParam(
name: 'RELEASE', name: 'RELEASE',
description: 'Decides whether binaries are built with debug symbols.', description: 'Decides whether release credentials are used.',
defaultValue: params.RELEASE ?: false defaultValue: params.RELEASE ?: false
) )
booleanParam(
name: 'INCLUDE_DEBUG_SYMBOLS',
description: 'Decides whether binaries are built with debug symbols.',
defaultValue: params.INCLUDE_DEBUG_SYMBOLS ?: false
)
choice( choice(
name: 'VERBOSE', name: 'VERBOSE',
description: 'Level of verbosity based on nimbus-build-system setup.', description: 'Level of verbosity based on nimbus-build-system setup.',

7
ci/Jenkinsfile.windows
View File

@ -10,9 +10,14 @@ pipeline {
parameters { parameters {
booleanParam( booleanParam(
name: 'RELEASE', name: 'RELEASE',
description: 'Decides whether binaries are built with debug symbols.', description: 'Decides whether release credentials are used.',
defaultValue: params.RELEASE ?: false defaultValue: params.RELEASE ?: false
) )
booleanParam(
name: 'INCLUDE_DEBUG_SYMBOLS',
description: 'Decides whether binaries are built with debug symbols.',
defaultValue: params.INCLUDE_DEBUG_SYMBOLS ?: false
)
choice( choice(
name: 'VERBOSE', name: 'VERBOSE',
description: 'Level of verbosity based on nimbus-build-system setup.', description: 'Level of verbosity based on nimbus-build-system setup.',

7
ci/cpp/Jenkinsfile.linux
View File

@ -18,9 +18,14 @@ pipeline {
parameters { parameters {
booleanParam( booleanParam(
name: 'RELEASE', name: 'RELEASE',
description: 'Decides whether binaries are built with debug symbols.', description: 'Decides whether release credentials are used.',
defaultValue: params.RELEASE ?: false defaultValue: params.RELEASE ?: false
) )
booleanParam(
name: 'INCLUDE_DEBUG_SYMBOLS',
description: 'Decides whether binaries are built with debug symbols.',
defaultValue: params.INCLUDE_DEBUG_SYMBOLS ?: false
)
} }
options { options {

7
ci/cpp/Jenkinsfile.macos
View File

@ -15,9 +15,14 @@ pipeline {
parameters { parameters {
booleanParam( booleanParam(
name: 'RELEASE', name: 'RELEASE',
description: 'Decides whether binaries are built with debug symbols.', description: 'Decides whether release credentials are used.',
defaultValue: params.RELEASE ?: false defaultValue: params.RELEASE ?: false
) )
booleanParam(
name: 'INCLUDE_DEBUG_SYMBOLS',
description: 'Decides whether binaries are built with debug symbols.',
defaultValue: params.INCLUDE_DEBUG_SYMBOLS ?: false
)
} }
options { options {

7
ci/cpp/Jenkinsfile.windows
View File

@ -15,9 +15,14 @@ pipeline {
parameters { parameters {
booleanParam( booleanParam(
name: 'RELEASE', name: 'RELEASE',
description: 'Decides whether binaries are built with debug symbols.', description: 'Decides whether release credentials are used.',
defaultValue: params.RELEASE ?: false defaultValue: params.RELEASE ?: false
) )
booleanParam(
name: 'INCLUDE_DEBUG_SYMBOLS',
description: 'Decides whether binaries are built with debug symbols.',
defaultValue: params.INCLUDE_DEBUG_SYMBOLS ?: false
)
} }
options { options {