From 9f8caa00bbfce57e958877e4e0edcd48f681a78c Mon Sep 17 00:00:00 2001 From: Iuri Matias Date: Tue, 28 Jun 2022 11:03:17 -0400 Subject: [PATCH] bug(@status-q): only run animations when they are visible to avoid cpu issues (#744) bug(@status-q): only run animations when they are visible to avoid cpu issues remove prop that doesn't exist --- ui/StatusQ/src/StatusQ/Animations/SkeletonGradientStop.qml | 1 + ui/StatusQ/src/StatusQ/Components/StatusChatInfoToolBar.qml | 2 ++ ui/StatusQ/src/StatusQ/Components/StatusExpandableItem.qml | 4 ++-- ui/StatusQ/src/StatusQ/Components/StatusLoadingIndicator.qml | 2 +- .../Components/private/statusMessage/StatusAudioMessage.qml | 1 + ui/StatusQ/src/StatusQ/Controls/StatusPinInput.qml | 5 +++-- ui/StatusQ/src/StatusQ/Controls/StatusSwitch.qml | 2 +- .../src/StatusQ/Controls/StatusTokenInlineSelector.qml | 3 ++- 8 files changed, 13 insertions(+), 7 deletions(-) diff --git a/ui/StatusQ/src/StatusQ/Animations/SkeletonGradientStop.qml b/ui/StatusQ/src/StatusQ/Animations/SkeletonGradientStop.qml index a9119931f3..231bc066c0 100644 --- a/ui/StatusQ/src/StatusQ/Animations/SkeletonGradientStop.qml +++ b/ui/StatusQ/src/StatusQ/Animations/SkeletonGradientStop.qml @@ -16,6 +16,7 @@ GradientStop { NumberAnimation on position { easing.type: Easing.Linear loops: Animation.Infinite + running: visible from: root.from to: from + 4 duration: 2000 diff --git a/ui/StatusQ/src/StatusQ/Components/StatusChatInfoToolBar.qml b/ui/StatusQ/src/StatusQ/Components/StatusChatInfoToolBar.qml index df293bdec1..a9cff3affa 100644 --- a/ui/StatusQ/src/StatusQ/Components/StatusChatInfoToolBar.qml +++ b/ui/StatusQ/src/StatusQ/Components/StatusChatInfoToolBar.qml @@ -73,6 +73,7 @@ Item { duration: 150 direction: RotationAnimation.Clockwise easing.type: Easing.InCubic + running: visible } }, Transition { @@ -82,6 +83,7 @@ Item { duration: 150 direction: RotationAnimation.Counterclockwise easing.type: Easing.OutCubic + running: visible } } ] diff --git a/ui/StatusQ/src/StatusQ/Components/StatusExpandableItem.qml b/ui/StatusQ/src/StatusQ/Components/StatusExpandableItem.qml index 5384776065..ac0b1d3a19 100644 --- a/ui/StatusQ/src/StatusQ/Components/StatusExpandableItem.qml +++ b/ui/StatusQ/src/StatusQ/Components/StatusExpandableItem.qml @@ -217,12 +217,12 @@ Rectangle { Transition { from: "COLLAPSED" to: "EXPANDED" - NumberAnimation { properties: "height"; duration: 200 } + NumberAnimation { properties: "height"; duration: 200; running: visible } }, Transition { from: "EXPANDED" to: "COLLAPSED" - NumberAnimation { properties: "height"; duration: 200 } + NumberAnimation { properties: "height"; duration: 200; running: visible } } ] } diff --git a/ui/StatusQ/src/StatusQ/Components/StatusLoadingIndicator.qml b/ui/StatusQ/src/StatusQ/Components/StatusLoadingIndicator.qml index a0e54fd418..4a0ce0ad06 100644 --- a/ui/StatusQ/src/StatusQ/Components/StatusLoadingIndicator.qml +++ b/ui/StatusQ/src/StatusQ/Components/StatusLoadingIndicator.qml @@ -11,7 +11,7 @@ StatusIcon { from: 0; to: 360; duration: 1200 - running: true + running: visible loops: Animation.Infinite } } diff --git a/ui/StatusQ/src/StatusQ/Components/private/statusMessage/StatusAudioMessage.qml b/ui/StatusQ/src/StatusQ/Components/private/statusMessage/StatusAudioMessage.qml index a2299c3a10..9f2fa3a839 100644 --- a/ui/StatusQ/src/StatusQ/Components/private/statusMessage/StatusAudioMessage.qml +++ b/ui/StatusQ/src/StatusQ/Components/private/statusMessage/StatusAudioMessage.qml @@ -115,6 +115,7 @@ Rectangle { properties: "scale"; duration: 100; easing.type: Easing.InOutQuad + running: visible } } diff --git a/ui/StatusQ/src/StatusQ/Controls/StatusPinInput.qml b/ui/StatusQ/src/StatusQ/Controls/StatusPinInput.qml index bd6185e288..96a3c1d4b3 100644 --- a/ui/StatusQ/src/StatusQ/Controls/StatusPinInput.qml +++ b/ui/StatusQ/src/StatusQ/Controls/StatusPinInput.qml @@ -211,8 +211,9 @@ Item { SequentialAnimation { id: blinkingAnimation loops: Animation.Infinite - NumberAnimation { target: inner; property: "opacity"; to: 0; duration: 800 } - NumberAnimation { target: inner; property: "opacity"; to: 1; duration: 800 } + running: visible + NumberAnimation { target: inner; property: "opacity"; to: 0; duration: 800; running: visible } + NumberAnimation { target: inner; property: "opacity"; to: 1; duration: 800; running: visible } } } } diff --git a/ui/StatusQ/src/StatusQ/Controls/StatusSwitch.qml b/ui/StatusQ/src/StatusQ/Controls/StatusSwitch.qml index 370b8d8754..cd86899881 100644 --- a/ui/StatusQ/src/StatusQ/Controls/StatusSwitch.qml +++ b/ui/StatusQ/src/StatusQ/Controls/StatusSwitch.qml @@ -52,7 +52,7 @@ Switch { transitions: Transition { reversible: true - NumberAnimation { properties: "x"; easing.type: Easing.Linear; duration: 120; } + NumberAnimation { properties: "x"; easing.type: Easing.Linear; duration: 120; running: visible } } } } diff --git a/ui/StatusQ/src/StatusQ/Controls/StatusTokenInlineSelector.qml b/ui/StatusQ/src/StatusQ/Controls/StatusTokenInlineSelector.qml index 650066bdc9..10695e6184 100644 --- a/ui/StatusQ/src/StatusQ/Controls/StatusTokenInlineSelector.qml +++ b/ui/StatusQ/src/StatusQ/Controls/StatusTokenInlineSelector.qml @@ -108,6 +108,7 @@ RowLayout { Behavior on color { ColorAnimation { + running: visible } } @@ -155,7 +156,7 @@ RowLayout { from: 0 to: parent.width duration: 800 - running: mouseArea.containsPress + running: visible && mouseArea.containsPress onStopped: { if (pressIndicator.width == parent.width) {