status-im/status-desktop
2
0
Fork 0
mirror of https://github.com/status-im/status-desktop.git synced 2025-03-03 16:00:50 +00:00
Code Issues Projects Releases Wiki Activity

fix(TransactionSettings): fix component height jumping around

Browse Source 
- use the correct icon size
- fix some forgotten qsTr()
- silence some warnings; a plain `return` returns `undefined` whereas a
`bool` is expected
This commit is contained in:
Lukáš Tinkl 2025-02-27 17:11:23 +01:00 committed by Lukáš Tinkl
parent caf0447574
commit 9bbb7c989c
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/StatusQ/src/StatusQ/Controls/StatusFeeOption.qml
View File

@ -167,8 +167,8 @@ Control {
StatusImage { StatusImage {
id: image id: image
visible: root.selected || root.hovered visible: root.selected || root.hovered
width: 22 width: 20
height: 22 height: 20
source: root.icon source: root.icon
} }
} }

10
ui/app/AppLayouts/Wallet/views/TransactionSettings.qml
View File

@ -160,7 +160,7 @@ Rectangle {
ColumnLayout { ColumnLayout {
Layout.margins: 20 Layout.margins: 20
spacing: 16 spacing: Theme.padding
StatusBaseText { StatusBaseText {
Layout.preferredWidth: parent.width Layout.preferredWidth: parent.width
@ -210,7 +210,7 @@ Rectangle {
selected: root.selectedFeeMode === StatusFeeOption.Type.Custom selected: root.selectedFeeMode === StatusFeeOption.Type.Custom
showSubText: !!selected showSubText: !!selected
showAdditionalText: !!selected showAdditionalText: !!selected
unselectedText: "Set your own fees & nonce" unselectedText: qsTr("Set your own fees & nonce")
onClicked: root.selectedFeeMode = StatusFeeOption.Type.Custom onClicked: root.selectedFeeMode = StatusFeeOption.Type.Custom
} }
@ -242,7 +242,7 @@ Rectangle {
readonly property bool displayLowBaseFeeWarning: { readonly property bool displayLowBaseFeeWarning: {
if (!customBaseFeeInput.text) { if (!customBaseFeeInput.text) {
return return false
} }
const weiCurrentValue = SQUtils.AmountsArithmetic.fromString(root.currentBaseFee) const weiCurrentValue = SQUtils.AmountsArithmetic.fromString(root.currentBaseFee)
const decreasedCurrentValue = SQUtils.AmountsArithmetic.times(weiCurrentValue, SQUtils.AmountsArithmetic.fromString("0.9")) // up to -10% is acceptable const decreasedCurrentValue = SQUtils.AmountsArithmetic.times(weiCurrentValue, SQUtils.AmountsArithmetic.fromString("0.9")) // up to -10% is acceptable
@ -252,7 +252,7 @@ Rectangle {
readonly property bool displayHighBaseFeeWarning: { readonly property bool displayHighBaseFeeWarning: {
if (!customBaseFeeInput.text) { if (!customBaseFeeInput.text) {
return return false
} }
const weiCurrentValue = SQUtils.AmountsArithmetic.fromString(root.currentBaseFee) const weiCurrentValue = SQUtils.AmountsArithmetic.fromString(root.currentBaseFee)
const increasedCurrentValue = SQUtils.AmountsArithmetic.times(weiCurrentValue, SQUtils.AmountsArithmetic.fromString("1.2")) // up to 20% higher value is acceptable const increasedCurrentValue = SQUtils.AmountsArithmetic.times(weiCurrentValue, SQUtils.AmountsArithmetic.fromString("1.2")) // up to 20% higher value is acceptable
@ -401,7 +401,7 @@ Rectangle {
: qsTr("Current: %1").arg(root.currentGasAmount) : qsTr("Current: %1").arg(root.currentGasAmount)
rightPadding: leftPadding rightPadding: leftPadding
input.rightComponent: StatusBaseText { input.rightComponent: StatusBaseText {
text: "UNITS" text: qsTr("UNITS")
color: Theme.palette.baseColor1 color: Theme.palette.baseColor1
} }