From 89408adc00f69c389c5dbb9a28e4981bcfe726af Mon Sep 17 00:00:00 2001
From: Igor Sirotin <sirotin@status.im>
Date: Wed, 3 Apr 2024 14:47:41 +0100
Subject: [PATCH] chore: fill holes in ChatType enum (#14257)

* chore: fill holes in ChatType enum
* chore: fix Spacing warning
---
 config.nims                                                 | 4 ++++
 src/app/modules/shared_modules/keycard_popup/controller.nim | 2 +-
 src/app_service/service/chat/dto/chat.nim                   | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/config.nims b/config.nims
index 640ba6c5af..3d0493961c 100644
--- a/config.nims
+++ b/config.nims
@@ -55,7 +55,11 @@ switch("warning", "UnreachableElse:off")
 # Those are popular to miss in our app, and quickly make build log unreadable, so we want to prevent them
 switch("warningAsError", "UseBase:on")
 switch("warningAsError", "UnusedImport:on")
+switch("warningAsError", "Deprecated:on")
+switch("warningAsError", "HoleEnumConv:on")
 
 # Workaround for https://github.com/nim-lang/Nim/issues/23429
 switch("warning", "UseBase:on")
 switch("warning", "UnusedImport:on")
+switch("warning", "Deprecated:on")
+switch("warning", "HoleEnumConv:on")
diff --git a/src/app/modules/shared_modules/keycard_popup/controller.nim b/src/app/modules/shared_modules/keycard_popup/controller.nim
index 81136db9f1..e2d68712d3 100644
--- a/src/app/modules/shared_modules/keycard_popup/controller.nim
+++ b/src/app/modules/shared_modules/keycard_popup/controller.nim
@@ -650,7 +650,7 @@ proc terminateCurrentFlow*(self: Controller, lastStepInTheCurrentFlow: bool, nex
         exportedEncryptionPubKey = flowEvent.generatedWalletAccounts[0].publicKey # encryption key is at position 0
         if exportedEncryptionPubKey.len > 0:
           self.tmpFlowData.password = exportedEncryptionPubKey
-          for i in 0..< self.tmpRequestedPathsAlongWithAuthentication.len:
+          for i in 0..<self.tmpRequestedPathsAlongWithAuthentication.len:
             var path = self.tmpRequestedPathsAlongWithAuthentication[i]
             self.tmpFlowData.additinalPathsDetails[path] = KeyDetails(
               address: flowEvent.generatedWalletAccounts[i].address,
diff --git a/src/app_service/service/chat/dto/chat.nim b/src/app_service/service/chat/dto/chat.nim
index b7c87d57b6..74885807ab 100644
--- a/src/app_service/service/chat/dto/chat.nim
+++ b/src/app_service/service/chat/dto/chat.nim
@@ -13,6 +13,7 @@ type ChatType* {.pure.}= enum
   Public = 2,
   PrivateGroupChat = 3,
   Profile = 4,
+  Timeline {.deprecated.} = 5,
   CommunityChat = 6
 
 type ChannelGroupType* {.pure.}= enum