status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

chore: add dummy ListView to ChatMessages to avoid app crash 

For an unknown reason, when the `chatLogView` ListView uses
a `verticalLayoutDirection: BottomToTop`, it prevents the application
from successfully rendering during login and crashes.

From debugging this, we know that this only happens when the above
condition applies *and* when a `DelegateModel` is used.
The delegate doesn't even need proper data, it application would still
crash.

We found out that the crash can be avoided when another `ListView` exists
in this component (however it's unclear why).

For now this commit adds such a placeholder `ListView` until it
we know more about what's going on.
This commit is contained in:
Pascal Precht 2021-03-01 10:44:19 +01:00 committed by Iuri Matias
parent 608455f563
commit 7b07a31fa6
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ui/app/AppLayouts/Chat/ChatColumn/ChatMessages.qml
View File

@ -29,6 +29,28 @@ ScrollView {
ScrollBar.vertical.policy: chatLogView.contentHeight > chatLogView.height ? ScrollBar.AlwaysOn : ScrollBar.AlwaysOff ScrollBar.vertical.policy: chatLogView.contentHeight > chatLogView.height ? ScrollBar.AlwaysOn : ScrollBar.AlwaysOff
ScrollBar.horizontal.policy: ScrollBar.AlwaysOff ScrollBar.horizontal.policy: ScrollBar.AlwaysOff
/**
* This ListView is prevents a crash of the application during
* login *DO NOT REMOVE IT*.
*
* For an unknown reason, when the `chatLogView` ListView uses
* a `verticalLayoutDirection: BottomToTop`, it prevents the application
* from successfully rendering during login and crashes.
*
* From debugging this, we know that this only happens when the above
* condition applies *and* when a `DelegateModel` is used.
* The delegate doesn't even need proper data, it application would still
* crash.
*
* We found out that the crash can be avoided when another `ListView` exists
* in this component (however it's unclear why).
*
* TODO(pascal): remove this once we know what's exactly going on here.
*/
ListView {
id: dummy
}
ListView { ListView {
property string currentNotificationChatId property string currentNotificationChatId