status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(WritableProxyModel): Insert in a single step to avoid providing undefined roles to ListViews

This commit is contained in:
Alex Jbanca 2024-02-07 12:31:35 +02:00 committed by Alex Jbanca
parent 87d3dcb113
commit 74bcdbe2c3
1 changed files with 29 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
ui/StatusQ/src/writableproxymodel.cpp
View File

@ -421,7 +421,6 @@ QVariantMap WritableProxyModel::toVariantMap() const
return result;
}
QVariantList WritableProxyModel::getInsertedItems() const
{
if (!d->dirty || !sourceModel())
@ -444,6 +443,7 @@ QVariantList WritableProxyModel::getInsertedItems() const
return result;
}
QVariantList WritableProxyModel::getEditedItems() const
{
if (!d->dirty || !sourceModel())
@ -466,6 +466,7 @@ QVariantList WritableProxyModel::getEditedItems() const
return result;
}
QVariantList WritableProxyModel::getRemovedItems() const
{
if (!d->dirty || !sourceModel())
@ -490,17 +491,40 @@ QVariantList WritableProxyModel::getRemovedItems() const
bool WritableProxyModel::insert(int at, const QVariantMap& data)
{
if(!sourceModel())
return false;
auto rowCount = this->rowCount();
if (at < 0 || at > rowCount)
return false;
auto success = insertRows(at, 1);
beginInsertRows({}, at, at);
if (success)
set(at, data);
auto roleNames = this->roleNames();
QMap<int/*role*/, QVariant/*value*/> rowMap;
for (auto it = data.begin(); it != data.end(); ++it)
{
auto role = roleNames.key(it.key().toUtf8(), -1);
if (role == -1)
continue;
return success;
rowMap.insert(role, it.value());
}
d->adjustInsertedRowsBy(at, 1);
auto index = createIndex(at, 0);
d->insertedRows.insert(index, rowMap);
d->createProxyToSourceRowMap();
endInsertRows();
setDirty(true);
return true;
}
bool WritableProxyModel::append(const QVariantMap& data)