chore(@desktop/general): signal names aligned

When we started with refactor we had to somehow separate "new"
and "old" signals that's why most of signals had prefix "new-", now
since we don't collide any more with "old" signal names (since we
removed all old code) we are free to sort out that signals naming,
what this commit does.

src/app_service/service/about/service.nim

@@ -20,7 +20,8 @@ type
   VersionArgs* = ref object of Args
     version*: string
 
-const SIGNAL_VERSION_FETCHED* = "SIGNAL_VERSION_FETCHED"
+# Signals which may be emitted by this service:
+const SIGNAL_VERSION_FETCHED* = "versionFetched"
 
 QtObject:
   type 

src/app_service/service/activity_center/service.nim

@@ -44,10 +44,9 @@ type
     notificationTypes*: seq[ActivityCenterNotificationType]
 
 # Signals which may be emitted by this service:
-# TODO remove new when refactor is done
-const SIGNAL_ACTIVITY_CENTER_NOTIFICATIONS_LOADED* = "activityCenterNotificationsLoaded-new"
-const SIGNAL_MARK_NOTIFICATIONS_AS_READ* = "markNotificationsAsRead-new"
-const SIGNAL_MARK_NOTIFICATIONS_AS_UNREAD* = "markNotificationsAsUnread-new"
+const SIGNAL_ACTIVITY_CENTER_NOTIFICATIONS_LOADED* = "activityCenterNotificationsLoaded"
+const SIGNAL_MARK_NOTIFICATIONS_AS_READ* = "markNotificationsAsRead"
+const SIGNAL_MARK_NOTIFICATIONS_AS_UNREAD* = "markNotificationsAsUnread"
 const SIGNAL_MARK_NOTIFICATIONS_AS_ACCEPTED* = "markNotificationsAsAccepted"
 const SIGNAL_MARK_NOTIFICATIONS_AS_DISMISSED* = "markNotificationsAsDismissed"
 

src/app_service/service/chat/service.nim

@@ -45,16 +45,15 @@ type
     id*: string
     channel*: string
 
-# Events this service emits
-# TODO remove new when refactor is done
+# Signals which may be emitted by this service:
 const SIGNAL_CHAT_UPDATE* = "chatUpdate_new"
 const SIGNAL_CHAT_LEFT* = "channelLeft_new"
-const SIGNAL_SENDING_FAILED* = "messageSendingFailed_new"
-const SIGNAL_SENDING_SUCCESS* = "messageSendingSuccess_new"
-const SIGNAL_MESSAGE_DELETED* = "messageDeleted_new"
-const SIGNAL_CHAT_MUTED* = "new-chatMuted"
-const SIGNAL_CHAT_UNMUTED* = "new-chatUnmuted"
-const SIGNAL_CHAT_HISTORY_CLEARED* = "new-chatHistoryCleared"
+const SIGNAL_SENDING_FAILED* = "messageSendingFailed"
+const SIGNAL_SENDING_SUCCESS* = "messageSendingSuccess"
+const SIGNAL_MESSAGE_DELETED* = "messageDeleted"
+const SIGNAL_CHAT_MUTED* = "chatMuted"
+const SIGNAL_CHAT_UNMUTED* = "chatUnmuted"
+const SIGNAL_CHAT_HISTORY_CLEARED* = "chatHistoryCleared"
 
 QtObject:
   type Service* = ref object of QObject

src/app_service/service/community/service.nim

@@ -43,18 +43,18 @@ type
     channels*: seq[string]
 
 # Signals which may be emitted by this service:
-const SIGNAL_COMMUNITY_JOINED* = "SIGNAL_COMMUNITY_JOINED"
-const SIGNAL_COMMUNITY_MY_REQUEST_ADDED* = "SIGNAL_COMMUNITY_MY_REQUEST_ADDED"
-const SIGNAL_COMMUNITY_LEFT* = "SIGNAL_COMMUNITY_LEFT"
-const SIGNAL_COMMUNITY_CREATED* = "SIGNAL_COMMUNITY_CREATED"
-const SIGNAL_COMMUNITY_EDITED* = "SIGNAL_COMMUNITY_EDITED"
-const SIGNAL_COMMUNITY_CHANNEL_CREATED* = "SIGNAL_COMMUNITY_CHANNEL_CREATED"
-const SIGNAL_COMMUNITY_CHANNEL_EDITED* = "SIGNAL_COMMUNITY_CHANNEL_EDITED"
-const SIGNAL_COMMUNITY_CHANNEL_REORDERED* = "SIGNAL_COMMUNITY_CHANNEL_REORDERED"
-const SIGNAL_COMMUNITY_CHANNEL_DELETED* = "SIGNAL_COMMUNITY_CHANNEL_DELETED"
-const SIGNAL_COMMUNITY_CATEGORY_CREATED* = "SIGNAL_COMMUNITY_CATEGORY_CREATED"
-const SIGNAL_COMMUNITY_CATEGORY_EDITED* = "SIGNAL_COMMUNITY_CATEGORY_EDITED"
-const SIGNAL_COMMUNITY_CATEGORY_DELETED* = "SIGNAL_COMMUNITY_CATEGORY_DELETED"
+const SIGNAL_COMMUNITY_JOINED* = "communityJoined"
+const SIGNAL_COMMUNITY_MY_REQUEST_ADDED* = "communityMyRequestAdded"
+const SIGNAL_COMMUNITY_LEFT* = "communityLeft"
+const SIGNAL_COMMUNITY_CREATED* = "communityCreated"
+const SIGNAL_COMMUNITY_EDITED* = "communityEdited"
+const SIGNAL_COMMUNITY_CHANNEL_CREATED* = "communityChannelCreated"
+const SIGNAL_COMMUNITY_CHANNEL_EDITED* = "communityChannelEdited"
+const SIGNAL_COMMUNITY_CHANNEL_REORDERED* = "communityChannelReordered"
+const SIGNAL_COMMUNITY_CHANNEL_DELETED* = "communityChannelDeleted"
+const SIGNAL_COMMUNITY_CATEGORY_CREATED* = "communityCategoryCreated"
+const SIGNAL_COMMUNITY_CATEGORY_EDITED* = "communityCategoryEdited"
+const SIGNAL_COMMUNITY_CATEGORY_DELETED* = "communityCategoryDeleted"
 
 QtObject:
   type 

src/app_service/service/contacts/service.nim

@@ -39,15 +39,14 @@ const IdleLimitInSeconds = int(7 * 60) # 7 minutes
 
 # Signals which may be emitted by this service:
 const SIGNAL_ENS_RESOLVED* = "ensResolved"
-# Remove new when old code is removed
-const SIGNAL_CONTACT_ADDED* = "new-contactAdded"
-const SIGNAL_CONTACT_BLOCKED* = "new-contactBlocked"
-const SIGNAL_CONTACT_UNBLOCKED* = "new-contactUnblocked"
-const SIGNAL_CONTACT_REMOVED* = "new-contactRemoved"
-const SIGNAL_CONTACT_NICKNAME_CHANGED* = "new-contactNicknameChanged"
-const SIGNAL_CONTACTS_STATUS_UPDATED* = "new-contactsStatusUpdated"
-const SIGNAL_CONTACT_UPDATED* = "new-contactUpdated"
-const SIGNAL_LOGGEDIN_USER_IMAGE_CHANGED* = "new-loggedInUserImageChanged"
+const SIGNAL_CONTACT_ADDED* = "contactAdded"
+const SIGNAL_CONTACT_BLOCKED* = "contactBlocked"
+const SIGNAL_CONTACT_UNBLOCKED* = "contactUnblocked"
+const SIGNAL_CONTACT_REMOVED* = "contactRemoved"
+const SIGNAL_CONTACT_NICKNAME_CHANGED* = "contactNicknameChanged"
+const SIGNAL_CONTACTS_STATUS_UPDATED* = "contactsStatusUpdated"
+const SIGNAL_CONTACT_UPDATED* = "contactUpdated"
+const SIGNAL_LOGGEDIN_USER_IMAGE_CHANGED* = "loggedInUserImageChanged"
 
 
 QtObject:

src/app_service/service/message/service.nim

@@ -22,15 +22,15 @@ const MESSAGES_PER_PAGE = 20
 const CURSOR_VALUE_IGNORE = "ignore"
 
 # Signals which may be emitted by this service:
-const SIGNAL_MESSAGES_LOADED* = "new-messagesLoaded" #Once we are done with refactoring we should remove "new-" from all signals
-const SIGNAL_NEW_MESSAGE_RECEIVED* = "SIGNAL_NEW_MESSAGE_RECEIVED"
-const SIGNAL_MESSAGE_PINNED* = "new-messagePinned"
-const SIGNAL_MESSAGE_UNPINNED* = "new-messageUnpinned"
-const SIGNAL_SEARCH_MESSAGES_LOADED* = "new-searchMessagesLoaded"
-const SIGNAL_MESSAGES_MARKED_AS_READ* = "new-messagesMarkedAsRead"
-const SIGNAL_MESSAGE_REACTION_ADDED* = "new-messageReactionAdded"
-const SIGNAL_MESSAGE_REACTION_REMOVED* = "new-messageReactionRemoved"
-const SIGNAL_MESSAGE_DELETION* = "new-messageDeleted"
+const SIGNAL_MESSAGES_LOADED* = "messagesLoaded"
+const SIGNAL_NEW_MESSAGE_RECEIVED* = "newMessageReceived"
+const SIGNAL_MESSAGE_PINNED* = "messagePinned"
+const SIGNAL_MESSAGE_UNPINNED* = "messageUnpinned"
+const SIGNAL_SEARCH_MESSAGES_LOADED* = "searchMessagesLoaded"
+const SIGNAL_MESSAGES_MARKED_AS_READ* = "messagesMarkedAsRead"
+const SIGNAL_MESSAGE_REACTION_ADDED* = "messageReactionAdded"
+const SIGNAL_MESSAGE_REACTION_REMOVED* = "messageReactionRemoved"
+const SIGNAL_MESSAGE_DELETION* = "messageDeleted"
 
 include async_tasks
 

src/app_service/service/node/service.nim

@@ -12,9 +12,9 @@ logScope:
   topics = "node-service"
 
 # Signals which may be emitted by this service:
-const SIGNAL_BITS_SET_FETCHED* = "SIGNAL_BITS_SET_FETCHED" 
-const SIGNAL_NETWORK_DISCONNECTED* = "SIGNAL_NETWORK_DISCONNECTED"
-const SIGNAL_NETWORK_CONNECTED* = "SIGNAL_NETWORK_CONNECTED"
+const SIGNAL_BITS_SET_FETCHED* = "bitsSetFetched" 
+const SIGNAL_NETWORK_DISCONNECTED* = "networkDisconnected"
+const SIGNAL_NETWORK_CONNECTED* = "networkConnected"
 
 type
     BitsSet* = ref object of Args

src/app_service/service/os_notification/service.nim

@@ -7,7 +7,7 @@ logScope:
   topics = "os-notification-service"
 
 # Signals which may be emitted by this service:
-const SIGNAL_OS_NOTIFICATION_CLICKED* = "new-osNotificationClicked" #Once we are done with refactoring we should remove "new-" from all signals
+const SIGNAL_OS_NOTIFICATION_CLICKED* = "osNotificationClicked"
 
 type 
   OsNotificationsArgs* = ref object of Args

src/app_service/service/privacy/service.nim

@@ -12,6 +12,7 @@ import status/statusgo_backend_new/privacy as status_privacy
 logScope:
   topics = "privacy-service"
 
+# Signals which may be emitted by this service:
 const SIGNAL_MNEMONIC_REMOVAL* = "menmonicRemoval"
 const SIGNAL_PASSWORD_CHANGED* = "passwordChanged"
 

src/app_service/service/saved_address/service.nim

@@ -10,7 +10,8 @@ export service_interface
 logScope:
   topics = "saved-address-service"
 
-const SIGNAL_SAVED_ADDRESS_CHANGED* = "savedAddress/changed"
+# Signals which may be emitted by this service:
+const SIGNAL_SAVED_ADDRESS_CHANGED* = "savedAddressChanged"
 
 type 
   Service* = ref object of service_interface.ServiceInterface

src/app_service/service/stickers/service.nim

@@ -45,9 +45,9 @@ type
     uuid*: string
 
 # Signals which may be emitted by this service:
-const SIGNAL_STICKER_PACK_LOADED* = "SIGNAL_STICKER_PACK_LOADED"
-const SIGNAL_ALL_STICKER_PACKS_LOADED* = "SIGNAL_ALL_STICKER_PACKS_LOADED"
-const SIGNAL_STICKER_GAS_ESTIMATED* = "SIGNAL_STICKER_GAS_ESTIMATED"
+const SIGNAL_STICKER_PACK_LOADED* = "stickerPackLoaded"
+const SIGNAL_ALL_STICKER_PACKS_LOADED* = "allStickerPacksLoaded"
+const SIGNAL_STICKER_GAS_ESTIMATED* = "stickerGasEstimated"
 
 QtObject:
   type Service* = ref object of QObject

src/app_service/service/token/service.nim

@@ -18,7 +18,7 @@ logScope:
 include async_tasks
 
 # Signals which may be emitted by this service:
-const SIGNAL_TOKEN_DETAILS_LOADED* = "SIGNAL_TOKEN_DETAILS_LOADED"
+const SIGNAL_TOKEN_DETAILS_LOADED* = "tokenDetailsLoaded"
 
 type
   TokenDetailsLoadedArgs* = ref object of Args

src/app_service/service/transaction/service.nim

@@ -16,7 +16,7 @@ logScope:
 include async_tasks
 
 # Signals which may be emitted by this service:
-const SIGNAL_TRANSACTIONS_LOADED* = "SIGNAL_TRANSACTIONS_LOADED"
+const SIGNAL_TRANSACTIONS_LOADED* = "transactionsLoaded"
 
 type
   TransactionsLoadedArgs* = ref object of Args