fix: Fix and rework "start chat" text field input (#10450)

src/app_service/common/conversion.nim

@@ -8,7 +8,10 @@ const SystemMentionChars* = {'0'..'9', 'x'}
 const SystemTagMapping* = [("@everyone", "@0x00001")]
 
 proc isCompressedPubKey*(strPubKey: string): bool =
-  return strPubKey.startsWith("zQ3") and allCharsInSet(strPubKey, CompressedKeyChars)
+  let length = len(strPubKey)
+  return length >= 48 and length <= 50 and
+         strPubKey.startsWith("zQ3sh") and
+         allCharsInSet(strPubKey, CompressedKeyChars)
 
 proc isSystemMention*(mention: string) : bool =
   mention.startsWith("0x") and allCharsInSet(mention, SystemMentionChars)

src/app_service/service/contacts/async_tasks.nim

@@ -68,8 +68,10 @@ const asyncRequestContactInfoTask: Task = proc(argEncoded: string) {.gcsafe, nim
     arg.finish(%* {
       "publicKey": arg.pubkey,
       "response": response,
+      "error": nil,
     })
   except Exception as e:
     arg.finish(%* {
+      "publicKey": arg.pubkey,
       "error": e.msg,
     })

src/app_service/service/contacts/service.nim

@@ -319,12 +319,12 @@ QtObject:
   proc getContactById*(self: Service, id: string): ContactsDto =
     var pubkey = id
 
-    if len(pubkey) == 0:
-        return
-
     if service_conversion.isCompressedPubKey(id):
         pubkey = status_accounts.decompressPk(id).result
 
+    if len(pubkey) == 0:
+        return
+
     if(pubkey == singletonInstance.userProfile.getPubKey()):
       # If we try to get the contact details of ourselves, just return our own info
       return ContactsDto(
@@ -779,10 +779,18 @@ QtObject:
   proc asyncContactInfoLoaded*(self: Service, pubkeyAndRpcResponse: string) {.slot.} =
     let rpcResponseObj = pubkeyAndRpcResponse.parseJson
     let publicKey = $rpcResponseObj{"publicKey"}
+    let requestError = rpcResponseObj{"error"}
+    var error : string
 
-    if (rpcResponseObj{"response"}{"error"}.kind != JNull):
-      let error = Json.decode($rpcResponseObj["response"]["error"], RpcError)
-      error "Error requesting contact info", msg = error.message, publicKey
+    if requestError.kind != JNull:
+      error = $requestError
+    else:
+      let responseError = rpcResponseObj{"response"}{"error"}
+      if responseError.kind != JNull:
+        error = Json.decode($responseError, RpcError).message
+
+    if len(error) != 0:
+      error "error requesting contact info", msg = error, publicKey
       self.events.emit(SIGNAL_CONTACT_INFO_REQUEST_FINISHED, ContactInfoRequestArgs(publicKey: publicKey, ok: false))
       return
 

ui/app/AppLayouts/Chat/panels/InlineSelectorPanel.qml

@@ -41,6 +41,18 @@ Item {
     implicitWidth: mainLayout.implicitWidth
     implicitHeight: mainLayout.implicitHeight
 
+    QtObject {
+        id: d
+
+        function paste() {
+            root.suggestionsDialog.forceHide = true
+            edit.pasteOperation = true
+            edit.paste()
+            root.textPasted(edit.text)
+            edit.pasteOperation = false
+        }
+    }
+
     RowLayout {
         id: mainLayout
         anchors.fill: parent
@@ -118,13 +130,17 @@ Item {
                                     cursorVisible: edit.cursorVisible
                                 }
 
-                                onTextEdited: if (suggestionsDialog.forceHide && !pasteOperation)
+                                onTextEdited: {
+                                    if (suggestionsDialog.forceHide && !pasteOperation)
                                         suggestionsDialog.forceHide = false
+                                }
+
+                                Keys.onPressed: (event) => {
 
-                                Keys.onPressed: {
                                     if (event.matches(StandardKey.Paste)) {
-                                        pasteOperation = true
-                                        root.suggestionsDialog.forceHide = true
+                                        event.accepted = true
+                                        d.paste()
+                                        return
                                     }
 
                                     if (suggestionsDialog.visible) {
@@ -149,17 +165,6 @@ Item {
                                         }
                                     }
                                 }
-
-                                Keys.onReleased: {
-                                    if (event.matches(StandardKey.Paste)) {
-                                        event.accepted = true
-                                        pasteOperation = false
-                                        if (text) {
-                                            root.textPasted(text)
-                                        }
-
-                                    }
-                                }
                             }
 
                             // ensure edit cursor is visible

ui/app/AppLayouts/Chat/views/MembersSelectorView.qml

@@ -33,7 +33,14 @@ MembersSelectorBase {
     }
 
     edit.onTextChanged: {
-        d.lookupContact(edit.text)
+        // When edited, give a small delay in case next character is printed soon
+        contactLookupDelayTimer.start()
+    }
+
+    onTextPasted: (text) => {
+        // When pated, process text immediately
+        contactLookupDelayTimer.stop() // when pasting, textChanged is still emited first
+        d.lookupContact(text)
     }
 
     model: SortFilterProxyModel {
@@ -55,11 +62,52 @@ MembersSelectorBase {
         property ListModel selectedMembers: ListModel {}
 
         function lookupContact(value) {
+
+            value = value.trim()
+
             if (value.startsWith(Constants.userLinkPrefix))
                 value = value.slice(Constants.userLinkPrefix.length)
 
-            if (Utils.isCompressedPubKey(value))
+            if (Utils.isChatKey(value)) {
+                processContact(value)
+                return
+            }
+
+            if (Utils.isValidEns(value)) {
                 root.rootStore.contactsStore.resolveENS(value)
+                return
+            }
+
+            root.suggestionsDialog.forceHide = false
+        }
+
+        function processContact(publicKey) {
+            const contactDetails = Utils.getContactDetailsAsJson(publicKey, false)
+
+            if (contactDetails.publicKey === "") {
+                // not a valid key given
+                root.suggestionsDialog.forceHide = false
+                return
+            }
+
+            if (contactDetails.publicKey === root.rootStore.contactsStore.myPublicKey ||
+                contactDetails.isBlocked) {
+                root.suggestionsDialog.forceHide = false
+                return
+            };
+
+            if (contactDetails.isContact) {
+                root.rootStore.mainModuleInst.switchTo(root.rootStore.getMySectionId(), contactDetails.publicKey)
+                return
+            }
+
+            if (root.model.count === 0 && !root.rootStore.contactsStore.hasPendingContactRequest(contactDetails.publicKey)) {
+                Global.openContactRequestPopup(contactDetails.publicKey,
+                                               popup => popup.closed.connect(root.rejected))
+                return
+            }
+
+            root.suggestionsDialog.forceHide = false
         }
 
         function addMember(pubKey, displayName, localNickname) {
@@ -87,6 +135,15 @@ MembersSelectorBase {
         }
     }
 
+    Timer {
+        id: contactLookupDelayTimer
+        repeat: false
+        interval: 500
+        onTriggered: {
+            d.lookupContact(edit.text)
+        }
+    }
+
     Connections {
         enabled: root.visible
         target: root.rootStore.contactsStore.mainModuleInst
@@ -95,28 +152,7 @@ MembersSelectorBase {
                 root.suggestionsDialog.forceHide = false
                 return
             }
-
-            const contactDetails = Utils.getContactDetailsAsJson(resolvedPubKey, false)
-
-
-            if (contactDetails.publicKey === root.rootStore.contactsStore.myPublicKey ||
-                contactDetails.isBlocked) {
-                root.suggestionsDialog.forceHide = false
-                return
-            };
-
-            if (contactDetails.isContact) {
-                root.rootStore.mainModuleInst.switchTo(root.rootStore.getMySectionId(), contactDetails.publicKey)
-                return
-            }
-
-            if (root.model.count === 0 && !root.rootStore.contactsStore.hasPendingContactRequest(contactDetails.publicKey)) {
-                Global.openContactRequestPopup(contactDetails.publicKey,
-                                               popup => popup.closed.connect(root.rejected))
-                return
-            }
-
-            root.suggestionsDialog.forceHide = false
+            d.processContact(resolvedPubKey)
         }
     }
 }