code review
This commit is contained in:
parent
7d1e9212ca
commit
6e7bb6ba1c
|
@ -6,12 +6,17 @@ proc storeBookmark*(url: string, name: string): Bookmark =
|
||||||
try:
|
try:
|
||||||
let resp = callPrivateRPC("browsers_storeBookmark", payload).parseJson["result"]
|
let resp = callPrivateRPC("browsers_storeBookmark", payload).parseJson["result"]
|
||||||
result.imageUrl = resp["imageUrl"].getStr
|
result.imageUrl = resp["imageUrl"].getStr
|
||||||
except:
|
except Exception as e:
|
||||||
|
error "Error updating bookmark", msg = e.msg
|
||||||
discard
|
discard
|
||||||
|
|
||||||
proc updateBookmark*(ogUrl: string, url: string, name: string) =
|
proc updateBookmark*(ogUrl: string, url: string, name: string) =
|
||||||
let payload = %* [ogUrl, {"url": url, "name": name}]
|
let payload = %* [ogUrl, {"url": url, "name": name}]
|
||||||
discard callPrivateRPC("browsers_updateBookmark", payload)
|
try:
|
||||||
|
discard callPrivateRPC("browsers_updateBookmark", payload)
|
||||||
|
except Exception as e:
|
||||||
|
error "Error updating bookmark", msg = e.msg
|
||||||
|
discard
|
||||||
|
|
||||||
proc getBookmarks*(): string =
|
proc getBookmarks*(): string =
|
||||||
let payload = %* []
|
let payload = %* []
|
||||||
|
|
|
@ -1,5 +1,5 @@
|
||||||
import core, ./types, ../signals/types as statusgo_types, ./accounts/constants, ./utils
|
import core, ./types, ../signals/types as statusgo_types, ./accounts/constants, ./utils
|
||||||
import json, tables, sugar, sequtils, chronicles, strutils
|
import json, tables, sugar, sequtils, strutils
|
||||||
import json_serialization
|
import json_serialization
|
||||||
import locks
|
import locks
|
||||||
|
|
||||||
|
@ -28,7 +28,6 @@ proc getSettings*(useCached: bool = true, keepSensitiveData: bool = false): Json
|
||||||
withLock settingsLock:
|
withLock settingsLock:
|
||||||
if useCached and not dirty and not keepSensitiveData:
|
if useCached and not dirty and not keepSensitiveData:
|
||||||
result = settings
|
result = settings
|
||||||
# debug "setting", settings
|
|
||||||
else:
|
else:
|
||||||
result = callPrivateRPC("settings_getSettings").parseJSON()["result"]
|
result = callPrivateRPC("settings_getSettings").parseJSON()["result"]
|
||||||
if (keepSensitiveData):
|
if (keepSensitiveData):
|
||||||
|
|
|
@ -18,8 +18,8 @@ PopupMenu {
|
||||||
Action {
|
Action {
|
||||||
text: qsTr("Open in new Tab")
|
text: qsTr("Open in new Tab")
|
||||||
icon.source: "../../img/generate_account.svg"
|
icon.source: "../../img/generate_account.svg"
|
||||||
icon.width: 12
|
icon.width: 16
|
||||||
icon.height: 12
|
icon.height: 16
|
||||||
onTriggered: {
|
onTriggered: {
|
||||||
openInNewTab(root.url)
|
openInNewTab(root.url)
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue