From 6cfef32204a92e17bf46831ff81a4e3ec98a9134 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Cie=C5=9Blak?= <michalcieslak@status.im>
Date: Thu, 13 Jun 2024 13:58:18 +0200
Subject: [PATCH] feat(GenericListView): Ability to display images, option for
 skipping empty roles

---
 storybook/src/Storybook/GenericListView.qml | 37 ++++++++++++++++++---
 1 file changed, 33 insertions(+), 4 deletions(-)

diff --git a/storybook/src/Storybook/GenericListView.qml b/storybook/src/Storybook/GenericListView.qml
index 8fb02b8926..b77ac3cf2b 100644
--- a/storybook/src/Storybook/GenericListView.qml
+++ b/storybook/src/Storybook/GenericListView.qml
@@ -18,6 +18,9 @@ ListView {
     // custom delegate height, when set to 0, delegate's implicitHeight is used
     property int delegateHeight: 0
 
+    // skip role for given row if is empty or undefined
+    property bool skipEmptyRoles: false
+
     // text to be displayed in a list view's header
     property string label
 
@@ -29,7 +32,7 @@ ListView {
     ScrollBar.vertical: ScrollBar {}
 
     clip: true
-    spacing: 5
+    spacing: 10
 
     leftMargin: margin
     rightMargin: margin
@@ -141,21 +144,29 @@ ListView {
             Flow {
                 Layout.fillWidth: true
                 Layout.fillHeight: true
+
                 Repeater {
                     model: rowModel
 
-                    Label {
+                    delegate: Label {
                         readonly property var value:
                             delegateRoot.topModel[roleName]
 
+                        readonly property bool mayBeImage: !!value &&
+                            (value.toString().startsWith("file:")
+                             || value.toString().startsWith("data:image"))
+
                         readonly property var valueSanitized:
                             value === undefined ? "-" : value
 
                         readonly property bool last: index === rowModel.count - 1
-                        readonly property string separator: last ? "" : ","
+                        readonly property string separator: last ? "" : ",&nbsp;&nbsp;"
 
-                        text: `${roleName}: ${valueSanitized}${separator}`
+                        visible: (value !== undefined && value !== "")
+                                 || !root.skipEmptyRoles
 
+                        text: `<u>${roleName}</u>: ${mayBeImage ? `<img src="${value}" width="15" height="15">`
+                                                         : valueSanitized}${separator}`
                         MouseArea {
                             anchors.fill: parent
 
@@ -185,5 +196,23 @@ ListView {
                 root.moveRequested(from, to)
             }
         }
+
+        Rectangle {
+            anchors.top: parent.top
+            anchors.topMargin: -2
+
+            width: parent.width
+            height: 1
+            color: "lightgray"
+        }
+
+        Rectangle {
+            anchors.bottom: parent.bottom
+            anchors.bottomMargin: -2
+
+            width: parent.width
+            height: 1
+            color: "lightgray"
+        }
     }
 }