status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(notifications): The sound of notifications is harsh and annoying 

Use logarithmic sound volume scale instead of linear when interpreting
the sound volume value

TLDR; we were literally overblowing the speakers with absolute sound
volume levels; for the whole story I recommend reading:
https://www.dr-lex.be/info-stuff/volumecontrols.html

Also play a sound preview when changing the volume in Settings

Needs https://github.com/status-im/dotherside/pull/83

Fixes #8426
This commit is contained in:
Lukáš Tinkl 2022-12-09 16:17:56 +01:00 committed by Lukáš Tinkl
parent 2087a5322b
commit 668ea868c4
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ui/app/AppLayouts/Profile/views/NotificationsView.qml
View File

@ -468,6 +468,11 @@ SettingsContentBase {
Component.onCompleted: {
value = appSettings.volume
volumeSlider.valueChanged.connect(() => {
// play a sound preview, but not on startup
Global.notificationSound.stop()
Global.notificationSound.play()
});
}
}

4
ui/imports/utils/Audio.qml
View File

@ -7,7 +7,9 @@ T.Audio {
property var store
audioRole: Audio.NotificationRole
volume: store.volume
volume: T.QtMultimedia.convertVolume(store.volume,
T.QtMultimedia.LogarithmicVolumeScale,
T.QtMultimedia.LinearVolumeScale)
muted: !store.notificationSoundsEnabled
onError: console.warn("Audio error:", errorString, "; code:", error)
}

2
vendor/DOtherSide vendored

@ -1 +1 @@
Subproject commit 5fecb811aa471c609f06534775599ff245f12c83
Subproject commit 75b70971caf863629b4af83be254c04a84ef8c1e