From 655918a279e718a7eebc9bd74282a7d70b3b9d4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Tinkl?= Date: Wed, 25 Sep 2024 12:19:27 +0200 Subject: [PATCH] fix(SlippageSelector): cant do Swap with 100% slippage - set the max custom limit to < 100% - add a regression test Fixes #16394 --- storybook/qmlTests/tests/tst_SlippageSelector.qml | 1 + ui/imports/shared/controls/SlippageSelector.qml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/storybook/qmlTests/tests/tst_SlippageSelector.qml b/storybook/qmlTests/tests/tst_SlippageSelector.qml index bae960f669..43a870f48c 100644 --- a/storybook/qmlTests/tests/tst_SlippageSelector.qml +++ b/storybook/qmlTests/tests/tst_SlippageSelector.qml @@ -120,6 +120,7 @@ Item { {tag: "valid", value: 1.42, valid: true, isDefault: false}, {tag: "default", value: 0.5, valid: true, isDefault: true}, {tag: "invalid", value: 111.42, valid: false, isDefault: false}, + {tag: "hundred", value: 100, valid: false, isDefault: false}, ] } diff --git a/ui/imports/shared/controls/SlippageSelector.qml b/ui/imports/shared/controls/SlippageSelector.qml index 45b4379d50..73e37d1af5 100644 --- a/ui/imports/shared/controls/SlippageSelector.qml +++ b/ui/imports/shared/controls/SlippageSelector.qml @@ -102,7 +102,7 @@ Control { visible: !customButton.visible minValue: 0.01 - maxValue: 100.0 + maxValue: 99.99 maximumLength: 6 // 3 integral + separator + 2 decimals (e.g. "999.99") currencySymbol: d.customSymbol onValueChanged: d.update(value)